[GitHub] [helix] narendly merged pull request #611: Add REST API endpoints for WAGED Rebalancer

2019-11-25 Thread GitBox
narendly merged pull request #611: Add REST API endpoints for WAGED Rebalancer URL: https://github.com/apache/helix/pull/611 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [helix] narendly commented on a change in pull request #611: Add REST API endpoints for WAGED Rebalancer

2019-11-25 Thread GitBox
narendly commented on a change in pull request #611: Add REST API endpoints for WAGED Rebalancer URL: https://github.com/apache/helix/pull/611#discussion_r350560438 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java ##

[GitHub] [helix] jiajunwang commented on a change in pull request #611: Add REST API endpoints for WAGED Rebalancer

2019-11-25 Thread GitBox
jiajunwang commented on a change in pull request #611: Add REST API endpoints for WAGED Rebalancer URL: https://github.com/apache/helix/pull/611#discussion_r350558676 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java

[GitHub] [helix] i3wangyi commented on issue #516: Implement the propertyStore read endpoint

2019-11-25 Thread GitBox
i3wangyi commented on issue #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#issuecomment-558423038 latest mvn test under helix-rest folder, [INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 31.416 s - in TestSuite

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-25 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r350505964 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-25 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r350506030 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java ## @@ -117,9 +121,20

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-25 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r350505658 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-25 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r350505428 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-25 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r350505239 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] narendly commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
narendly commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350500034 ## File path: helix-core/src/test/java/org/apache/helix/integration/TestDrop.java ## @@ -55,16 +55,26 @@ * @param

[GitHub] [helix] narendly commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
narendly commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350500093 ## File path: helix-core/src/test/java/org/apache/helix/controller/dataproviders/TestWorkflowControllerDataProvider.java ##

[GitHub] [helix] narendly commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
narendly commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350499858 ## File path: helix-core/src/test/java/org/apache/helix/task/TestGetLastScheduledTaskExecInfo.java ## @@ -29,10 +29,14 @@

[GitHub] [helix] narendly commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
narendly commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350499925 ## File path: helix-core/src/test/java/org/apache/helix/tools/TestClusterVerifier.java ## @@ -132,8 +132,14 @@ public void

[GitHub] [helix] alirezazamani commented on issue #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani commented on issue #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#issuecomment-558398687 Result of mvn test after the addressing the comments: [INFO] Tests run: 886, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3,262.438 s - in

[GitHub] [helix] alirezazamani edited a comment on issue #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani edited a comment on issue #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#issuecomment-558398687 Result of mvn test after addressing the comments: [INFO] Tests run: 886, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3,262.438 s - in

[GitHub] [helix] alirezazamani commented on issue #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani commented on issue #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#issuecomment-558390660 @dasahcc I did put some general information about the fixes in the PR description. Here are more detail: 1- TestWorkflowControllerDataProvider:

[GitHub] [helix] alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350461885 ## File path: helix-core/src/test/java/org/apache/helix/tools/TestClusterVerifier.java ## @@ -132,8 +132,14 @@ public

[GitHub] [helix] alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350460009 ## File path: helix-core/src/test/java/org/apache/helix/tools/TestClusterVerifier.java ## @@ -173,15 +179,15 @@ public

[GitHub] [helix] jiajunwang commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
jiajunwang commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350454502 ## File path: helix-core/src/test/java/org/apache/helix/tools/TestClusterVerifier.java ## @@ -132,8 +132,14 @@ public

[GitHub] [helix] jiajunwang commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
jiajunwang commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350455688 ## File path: helix-core/src/test/java/org/apache/helix/tools/TestClusterVerifier.java ## @@ -173,15 +179,15 @@ public

[GitHub] [helix] alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350451308 ## File path: helix-core/src/test/java/org/apache/helix/task/TestGetLastScheduledTaskExecInfo.java ## @@ -41,37 +42,47

[GitHub] [helix] alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350451193 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestStopWorkflow.java ## @@ -203,13 +202,20

[GitHub] [helix] alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350450988 ## File path: helix-core/src/test/java/org/apache/helix/task/TestGetLastScheduledTaskExecInfo.java ## @@ -41,37 +42,47

[GitHub] [helix] alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350450890 ## File path: helix-core/src/test/java/org/apache/helix/task/TestGetLastScheduledTaskExecInfo.java ## @@ -41,37 +42,47

[GitHub] [helix] alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350450890 ## File path: helix-core/src/test/java/org/apache/helix/task/TestGetLastScheduledTaskExecInfo.java ## @@ -41,37 +42,47

[GitHub] [helix] alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350450601 ## File path: helix-core/src/test/java/org/apache/helix/task/TestGetLastScheduledTaskExecInfo.java ## @@ -41,37 +42,47

[GitHub] [helix] alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350450421 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestStopWorkflow.java ## @@ -275,13 +281,16

[GitHub] [helix] alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
alirezazamani commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350450233 ## File path: helix-core/src/test/java/org/apache/helix/controller/dataproviders/TestWorkflowControllerDataProvider.java

[GitHub] [helix] zhangmeng916 removed a comment on issue #600: add Helix cloud interface and implementation skeleton methods

2019-11-25 Thread GitBox
zhangmeng916 removed a comment on issue #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#issuecomment-557224337 This PR is ready to be merged, approved by @dasahcc final commit message: Add Helix cloud interface and

[GitHub] [helix] alirezazamani removed a comment on issue #589: Add CloudConfig operations

2019-11-25 Thread GitBox
alirezazamani removed a comment on issue #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#issuecomment-558350725 This PR is ready to be merged, approved by @dasahcc. Title: Add CloudConfig Related Code Body: In order to move toward

[GitHub] [helix] dasahcc commented on issue #516: Implement the propertyStore read endpoint

2019-11-25 Thread GitBox
dasahcc commented on issue #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#issuecomment-558350340 > > > > > Why this PR contains customized serializer change? I would suggest to separate the PR. 1 for customized serializer change and another

[GitHub] [helix] alirezazamani commented on issue #589: Add CloudConfig operations

2019-11-25 Thread GitBox
alirezazamani commented on issue #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#issuecomment-558350725 This PR is ready to be merged, approved by @dasahcc. Title: Add CloudConfig Related Code Body: In order to move toward supporting cloud

[GitHub] [helix] dasahcc commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-25 Thread GitBox
dasahcc commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r350433017 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] dasahcc commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-25 Thread GitBox
dasahcc commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r350433638 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] dasahcc commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-25 Thread GitBox
dasahcc commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r350432594 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

2019-11-25 Thread GitBox
alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r350432158 ## File path: helix-core/src/main/java/org/apache/helix/PropertyKey.java ## @@ -214,6 +215,16 @@ public PropertyKey

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

2019-11-25 Thread GitBox
alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r350432211 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,253 @@ +package

[GitHub] [helix] jiajunwang commented on a change in pull request #611: Add REST API endpoints for WAGED Rebalancer

2019-11-25 Thread GitBox
jiajunwang commented on a change in pull request #611: Add REST API endpoints for WAGED Rebalancer URL: https://github.com/apache/helix/pull/611#discussion_r350374583 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/AbstractResource.java ##

[GitHub] [helix] dasahcc commented on issue #516: Implement the propertyStore read endpoint

2019-11-25 Thread GitBox
dasahcc commented on issue #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#issuecomment-558271790 > > > > Why this PR contains customized serializer change? I would suggest to separate the PR. 1 for customized serializer change and another for

[GitHub] [helix] narendly commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
narendly commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350325364 ## File path: helix-core/src/test/java/org/apache/helix/task/TestGetLastScheduledTaskExecInfo.java ## @@ -41,37 +42,47 @@

[GitHub] [helix] narendly commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
narendly commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350323625 ## File path: helix-core/src/test/java/org/apache/helix/controller/dataproviders/TestWorkflowControllerDataProvider.java ##

[GitHub] [helix] narendly commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
narendly commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350325013 ## File path: helix-core/src/test/java/org/apache/helix/task/TestGetLastScheduledTaskExecInfo.java ## @@ -41,37 +42,47 @@

[GitHub] [helix] narendly commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
narendly commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350325575 ## File path: helix-core/src/test/java/org/apache/helix/task/TestGetLastScheduledTaskExecInfo.java ## @@ -41,37 +42,47 @@

[GitHub] [helix] narendly commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
narendly commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350324383 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestStopWorkflow.java ## @@ -275,13 +281,16 @@

[GitHub] [helix] narendly commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
narendly commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350325918 ## File path: helix-core/src/test/java/org/apache/helix/task/TestGetLastScheduledTaskExecInfo.java ## @@ -41,37 +42,47 @@

[GitHub] [helix] narendly commented on a change in pull request #624: Stabilize 5 unstable tests

2019-11-25 Thread GitBox
narendly commented on a change in pull request #624: Stabilize 5 unstable tests URL: https://github.com/apache/helix/pull/624#discussion_r350324191 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestStopWorkflow.java ## @@ -203,13 +202,20 @@