jiajunwang commented on issue #378: Make the reservoir used in
ZkClientPathMonitor metric configurable.
URL: https://github.com/apache/helix/pull/378#issuecomment-522772493
Please try to run "mvn test".
This is an automated
jiajunwang commented on issue #378: Make the reservoir used in
ZkClientPathMonitor metric configurable.
URL: https://github.com/apache/helix/pull/378#issuecomment-521818405
> @chenboat @narendly I'm thinking about if there is a better way to test.
>
> My major concern is that we
jiajunwang commented on issue #378: Make the reservoir used in
ZkClientPathMonitor metric configurable.
URL: https://github.com/apache/helix/pull/378#issuecomment-521530508
@chenboat @narendly I'm thinking about if there is a better way to test.
My major concern is that we make the
jiajunwang commented on issue #378: Make the reservoir used in
ZkClientPathMonitor metric configurable.
URL: https://github.com/apache/helix/pull/378#issuecomment-520933866
One more thing, please also revisit the previous comments and resolve them
if the problem has been fixed or no
jiajunwang commented on issue #378: Make the reservoir used in
ZkClientPathMonitor metric configurable.
URL: https://github.com/apache/helix/pull/378#issuecomment-519638967
@chenboat Please refer to HelixManagerProperties. We should be able to do
something similar for the monitors.
jiajunwang commented on issue #378: Make the reservoir used in
ZkClientPathMonitor metric configurable.
URL: https://github.com/apache/helix/pull/378#issuecomment-519387017
Thanks for the PR. I have several comments.
1. I agree to make the window configurable. It makes sense.
2. The
