[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-20 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r382328754 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-20 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r382295383 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/ZkTestBase.java ##

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-20 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r382294994 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-20 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r382294994 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-20 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r382254641 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-20 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r382253396 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/ZkTestBase.java ##

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-20 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r382167264 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-20 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r382165967 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-20 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r382165967 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381819357 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/ZkTestBase.java

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381709786 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381707858 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381707940 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381706803 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381707183 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/ZkTestBase.java

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381707703 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381707445 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381707814 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381706747 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381539203 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381536898 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/TrieRoutingData.java

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381489584 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381475481 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381475481 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381431903 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-19 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r381430791 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-18 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r380862823 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/TrieRoutingData.java

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-18 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r380862823 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/TrieRoutingData.java

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-18 Thread GitBox
narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r380862050 ## File path: