[Impala-ASF-CR] KUDU-2237: Allow idle server connection scanning to be disabled

2017-12-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8909 ) Change subject: KUDU-2237: Allow idle server connection scanning to be disabled .. KUDU-2237: Allow idle server

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 ) Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

2017-12-22 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8910 to look at the new patch set (#2). Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms

[Impala-ASF-CR] IMPALA-5528: Add a flag to tune TCMalloc total thread caches size

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8906 ) Change subject: IMPALA-5528: Add a flag to tune TCMalloc total thread caches size .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-5528: Add a flag to tune TCMalloc total thread caches size

2017-12-22 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, Tim Armstrong, Joe McDonnell, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8906 to look at the new patch set (#2). Change subject: IMPALA-5528: Add a flag to tune TCMalloc total thread caches size

[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'

2017-12-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 ) Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf' .. Patch Set 3: Code-Review+1 -- To view, visit

[native-toolchain-CR] Add GPerfTools 2.6.3 to toolchain

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8918 ) Change subject: Add GPerfTools 2.6.3 to toolchain .. Add GPerfTools 2.6.3 to toolchain This is the latest release of GPerfTools.

[native-toolchain-CR] Add GPerfTools 2.6.3 to toolchain

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8918 ) Change subject: Add GPerfTools 2.6.3 to toolchain .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8918 To

[native-toolchain-CR] Add GPerfTools 2.6.3 to toolchain

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8918 ) Change subject: Add GPerfTools 2.6.3 to toolchain .. Patch Set 1: Verified the build with a private toolchain packaging Jenkins job. --

[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'

2017-12-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 ) Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf' .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'

2017-12-22 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8854 to look at the new patch set (#3). Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'

[Impala-ASF-CR] KUDU-2237: Allow idle server connection scanning to be disabled

2017-12-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8909 ) Change subject: KUDU-2237: Allow idle server connection scanning to be disabled .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to

[native-toolchain-CR] Add GPerfTools 2.6.3 to toolchain

2017-12-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8918 ) Change subject: Add GPerfTools 2.6.3 to toolchain .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8918

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 10: LGTM ! Will let Tim do a pass on it too. -- To

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 10: Code-Review+1 -- To view, visit

[native-toolchain-CR] Add GPerfTools 2.6.3 to toolchain

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8918 Change subject: Add GPerfTools 2.6.3 to toolchain .. Add GPerfTools 2.6.3 to toolchain This is the latest release of GPerfTools. It

[Impala-ASF-CR] IMPALA-3887: Wait for HDFS replication in data loading

2017-12-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8916 ) Change subject: IMPALA-3887: Wait for HDFS replication in data loading .. Patch Set 1: (1 comment) thanks for the fix-- I just have a

[Impala-ASF-CR] IMPALA-3887: Wait for HDFS replication in data loading

2017-12-22 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8916 Change subject: IMPALA-3887: Wait for HDFS replication in data loading .. IMPALA-3887: Wait for HDFS replication in data loading When the

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2017-12-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2017-12-22 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#6). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 9: (6 comments) Thanks for the comments, please see

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-22 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#10). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. IMPALA-5014: Part 1: Round when casting

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5528: Add a knob to tune TCMalloc total thread caches size

2017-12-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8906 ) Change subject: IMPALA-5528: Add a knob to tune TCMalloc total thread caches size .. Patch Set 1: (4 comments) Had only minor

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 5: Code-Review+2 Made a minor change to overflow benchmark.

[Impala-ASF-CR] KUDU-2237: Allow idle server connection scanning to be disabled

2017-12-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8909 ) Change subject: KUDU-2237: Allow idle server connection scanning to be disabled .. Patch Set 1: Code-Review+2 lgtm, manually compares

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

2017-12-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 ) Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms .. Patch Set 1: Code-Review+1 (1 comment) lgtm, had one minor