[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 3: (1 comment)

[Impala-ASF-CR] PREVIEW: IMPALA-6372: Go parallel for Hive dataload

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: PREVIEW: IMPALA-6372: Go parallel for Hive dataload .. Patch Set 6: (10 comments)

[Impala-ASF-CR] IMPALA-6231: Implement decimal v2 fuzz test

Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8898 ) Change subject: IMPALA-6231: Implement decimal_v2 fuzz test .. IMPALA-6231: Implement decimal_v2 fuzz test Implement a test that

[Impala-ASF-CR] IMPALA-6231: Implement decimal v2 fuzz test

Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8898 ) Change subject: IMPALA-6231: Implement decimal_v2 fuzz test .. Patch Set 1: (8 comments)

[Impala-ASF-CR] PREVIEW: IMPALA-6372: Go parallel for Hive dataload

Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8894 to look at the new patch set (#6). Change subject: PREVIEW: IMPALA-6372: Go parallel for Hive dataload ..

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. IMPALA-2248: Make idle_session_timeout a query

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 21: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 21: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. IMPALA-5522:Use tracked memory for

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8958 Change subject: IMPALA-5152: Introduce metadata loading phase .. IMPALA-5152: Introduce metadata loading phase Reworks the collection and

[Impala-ASF-CR] IMPALA-6307: CTAS statement fails with duplicate column exception.

Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8930 ) Change subject: IMPALA-6307: CTAS statement fails with duplicate column exception. .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 9: (4 comments)

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-6348: Redact only sensitive fields in runtime profiles

Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8934 ) Change subject: IMPALA-6348: Redact only sensitive fields in runtime profiles .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 9: Code-Review+2 Can you also an

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 3: (11 comments)

[Impala-ASF-CR] IMPALA-6348: Redact only sensitive fields in runtime profiles

Hello Sailesh Mukil, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8934 to look at the new patch set (#3). Change subject: IMPALA-6348: Redact only sensitive fields in runtime profiles

[Impala-ASF-CR] Draft: Add JSON output to MemTracker::LogUsage()

Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8955 Change subject: Draft: Add JSON output to MemTracker::LogUsage() .. Draft: Add JSON output to MemTracker::LogUsage() TODO: Function

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. IMPALA-6362: avoid Reservation/MemTracker

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 1: Can you please add a BE test for it ? -- To view,

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 4: (1 comment) Thanks for looking into it. I

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 21: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 21: Build started:

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 21: This solution and the behaviour seem reasonable

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 21: Build started:

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 21: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end .. Patch Set 2: (1 comment) We should get this moving

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: Sorry for the slow response. If I understand

[Impala-ASF-CR] IMPALA-6364: Bypass file handle cache for ineligible files

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8945 ) Change subject: IMPALA-6364: Bypass file handle cache for ineligible files .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6364: Bypass file handle cache for ineligible files

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8945 ) Change subject: IMPALA-6364: Bypass file handle cache for ineligible files .. IMPALA-6364: Bypass file handle cache for

Re: [Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

Thank you, everyone, for all the support and help. It was an amazing learning experience. Looking forward to making much more contributions in future. Regards! Mansi On Fri, Jan 5, 2018 at 3:09 PM, Tim Armstrong (Code Review) < ger...@cloudera.org> wrote: > Tim Armstrong *posted comments* on

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 2: Can we test all the cases fixed

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6370: fix partitioned parquet tables with nested types

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8947 ) Change subject: IMPALA-6370: fix partitioned parquet tables with nested types .. IMPALA-6370: fix partitioned parquet

[Impala-ASF-CR] IMPALA-6370: fix partitioned parquet tables with nested types

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8947 ) Change subject: IMPALA-6370: fix partitioned parquet tables with nested types .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. Patch Set 6: Thank you for the contribution

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 5: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5052: Read and write signed integer logical types in Parquet

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8548 ) Change subject: IMPALA-5052: Read and write signed integer logical types in Parquet .. Patch Set 2: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8950 Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. IMPALA-6346: Potential deadlock in KrpcDataStreamMgr In

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 4: I'm confident it fixes the problem we saw - the

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 4: Tim, thanks for this. Do you feel confident this

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

Pranay Singh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8949 Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. IMPALA-6075: Add Impala daemon metric for catalog version.

[Impala-ASF-CR] IMPALA-6364: Bypass file handle cache for ineligible files

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8945 ) Change subject: IMPALA-6364: Bypass file handle cache for ineligible files .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6364: Bypass file handle cache for ineligible files

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8945 ) Change subject: IMPALA-6364: Bypass file handle cache for ineligible files .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6364: Bypass file handle cache for ineligible files

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8945 ) Change subject: IMPALA-6364: Bypass file handle cache for ineligible files .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6370: fix partitioned parquet tables with nested types

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8947 ) Change subject: IMPALA-6370: fix partitioned parquet tables with nested types .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6370: fix partitioned parquet tables with nested types

Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8947 ) Change subject: IMPALA-6370: fix partitioned parquet tables with nested types .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8861 ) Change subject: IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be a

[Impala-ASF-CR] IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8861 ) Change subject: IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be a

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6370: fix partitioned parquet tables with nested types

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8947 ) Change subject: IMPALA-6370: fix partitioned parquet tables with nested types .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6370: fix partitioned parquet tables with nested types

Hello Thomas Tauber-Marshall, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8947 to look at the new patch set (#3). Change subject: IMPALA-6370: fix partitioned parquet tables with nested types

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 21: There are several ways to fix that test

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

Hello Michael Ho, Thomas Tauber-Marshall, Laszlo Gaal, Gabor Kaszab, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8490 to look at the new patch set (#20). Change subject:

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

Hello Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8820 to look at the new patch set (#9). Change subject: IMPALA-5654: Disallow setting Kudu

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 8: Code-Review-1 There is a test failing in