[Impala-ASF-CR] IMPALA-6384: RequestPoolService should honor custom group mapping config

2018-01-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9000 ) Change subject: IMPALA-6384: RequestPoolService should honor custom group mapping config .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6384: RequestPoolService should honor custom group mapping config

2018-01-10 Thread Bharath Vissapragada (Code Review)
Hello Dimitris Tsirogiannis, Zoram Thanga, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9000 to look at the new patch set (#2). Change subject: IMPALA-6384: RequestPoolService should honor custom group mapping config

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 7: (6 comments)

[Impala-ASF-CR] Fix typo in test observability.

2018-01-10 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9003 ) Change subject: Fix typo in test_observability. .. Patch Set 1: Code-Review+1 Looks good. Sorry for the typo! -- To view, visit

[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators

2018-01-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 8: (22 comments)

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 7: (5 comments) Minor updates for

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. IMPALA-4323: "SET ROW FORMAT" option added to

[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output

2018-01-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output

2018-01-10 Thread John Russell (Code Review)
Hello Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8865 to look at the new patch set (#3). Change subject: IMPALA-2181: [DOCS] Document changes to SET output

[Impala-ASF-CR] Fix typo in test observability.

2018-01-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9003 ) Change subject: Fix typo in test_observability. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9003 To

[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators

2018-01-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 7: I appreciate all your reviews! -- To view, visit

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 4:

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 4: The error

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 4:

[Impala-ASF-CR] IMPALA-6384: RequestPoolService should honor custom group mapping config

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9000 ) Change subject: IMPALA-6384: RequestPoolService should honor custom group mapping config .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6381: increase test exchange delays timeout for isilon

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8993 ) Change subject: IMPALA-6381: increase test_exchange_delays timeout for isilon .. IMPALA-6381: increase

[Impala-ASF-CR] IMPALA-6381: increase test exchange delays timeout for isilon

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8993 ) Change subject: IMPALA-6381: increase test_exchange_delays timeout for isilon .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Vuk Ercegovac (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#5). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 4: (1 comment) yes, missed adding the file when renaming.

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 17: Code-Review+2 rebase -- To view,

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 15: rebase -- To view, visit

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9002 Change subject: IMPALA-6383: free memory after skipping parquet row groups .. IMPALA-6383: free memory after skipping parquet row groups

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 4:

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-01-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 1: (19 comments) First round of comments. Overall

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 4:

[Impala-ASF-CR] Increment version to 2.12.0-SNAPSHOT

2018-01-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9001 Change subject: Increment version to 2.12.0-SNAPSHOT .. Increment version to 2.12.0-SNAPSHOT Change-Id:

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 4: (1 comment) Is there a file missing (tpch.test)?

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Vuk Ercegovac (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#4). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 3: Code-Review+1 Did Sailesh want to

[Impala-ASF-CR] IMPALA-6384: RequestPoolService should honor custom group mapping config

2018-01-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9000 Change subject: IMPALA-6384: RequestPoolService should honor custom group mapping config .. IMPALA-6384: RequestPoolService

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-10 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8991 to look at the new patch set (#3). Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

[Impala-ASF-CR] IMPALA-6371: Additional check for delimiters

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8959 ) Change subject: IMPALA-6371: Additional check for delimiters .. IMPALA-6371: Additional check for delimiters The check

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 12: Code-Review+2 Carry -- To view, visit

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 5: (6 comments) Applied updates.

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. IMPALA-4323: "SET ROW FORMAT" option added to

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-01-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8997 Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. IMPALA-6338: Fix flaky

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Philip Zeyliger (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/ to look at the new patch set (#3). Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

[Impala-ASF-CR] [DOCS] Add phony doc build targets 'html' and 'pdf'

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8994 ) Change subject: [DOCS] Add phony doc build targets 'html' and 'pdf' .. [DOCS] Add phony doc build targets 'html' and

[Impala-ASF-CR] [DOCS] Add phony doc build targets 'html' and 'pdf'

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8994 ) Change subject: [DOCS] Add phony doc build targets 'html' and 'pdf' .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6381: increase test exchange delays timeout for isilon

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8993 ) Change subject: IMPALA-6381: increase test_exchange_delays timeout for isilon .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 9: (4 comments)

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-10 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Lars Volker, Zoram Thanga, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8814 to look at the new patch set (#11). Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time

[Impala-ASF-CR] [DOCS] Add phony doc build targets 'html' and 'pdf'

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8994 ) Change subject: [DOCS] Add phony doc build targets 'html' and 'pdf' .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-10 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Lars Volker, Zoram Thanga, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8814 to look at the new patch set (#10). Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time

[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators

2018-01-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 4: Patch set 4 was just to fix a looming merge

[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators

2018-01-10 Thread John Russell (Code Review)
Hello Greg Rahn, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8942 to look at the new patch set (#4). Change subject: IMPALA-1767: [DOCS] Document new Boolean operators ..

[Impala-ASF-CR] [DOCS] Add phony doc build targets 'html' and 'pdf'

2018-01-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8994 ) Change subject: [DOCS] Add phony doc build targets 'html' and 'pdf' .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6278: [DOCS] Add release note subtopics

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8992 ) Change subject: IMPALA-6278: [DOCS] Add release note subtopics .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6278: [DOCS] Add release note subtopics

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8992 ) Change subject: IMPALA-6278: [DOCS] Add release note subtopics .. IMPALA-6278: [DOCS] Add release note subtopics

[Impala-ASF-CR] [DOCS] Add phony doc build targets 'html' and 'pdf'

2018-01-10 Thread John Russell (Code Review)
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8994 Change subject: [DOCS] Add phony doc build targets 'html' and 'pdf' .. [DOCS] Add phony doc build targets 'html' and 'pdf' The better to

[Impala-ASF-CR] IMPALA-6278: [DOCS] Add release note subtopics

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8992 ) Change subject: IMPALA-6278: [DOCS] Add release note subtopics .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 4: (11 comments)

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. IMPALA-3651: Adds murmur_hash() built-in function

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

2018-01-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8986 ) Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

2018-01-10 Thread John Russell (Code Review)
Hello Thomas Tauber-Marshall, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8986 to look at the new patch set (#2). Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-6278: [DOCS] Add release note subtopics

2018-01-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8992 ) Change subject: IMPALA-6278: [DOCS] Add release note subtopics .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6381: increase test exchange delays timeout for isilon

2018-01-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8993 ) Change subject: IMPALA-6381: increase test_exchange_delays timeout for isilon .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6381: increase test exchange delays timeout for isilon

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8993 Change subject: IMPALA-6381: increase test_exchange_delays timeout for isilon .. IMPALA-6381: increase test_exchange_delays timeout for

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 2: Code-Review+2

[Impala-ASF-CR] IMPALA-6371: Additional check for delimiters

2018-01-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8959 ) Change subject: IMPALA-6371: Additional check for delimiters .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Recommend using Kudu Java API for rapid DMLs

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8976 ) Change subject: [DOCS] Recommend using Kudu Java API for rapid DMLs .. [DOCS] Recommend using Kudu Java API for rapid

[Impala-ASF-CR] [DOCS] Recommend using Kudu Java API for rapid DMLs

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8976 ) Change subject: [DOCS] Recommend using Kudu Java API for rapid DMLs .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

[Impala-ASF-CR] [DOCS] Recommend using Kudu Java API for rapid DMLs

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8976 ) Change subject: [DOCS] Recommend using Kudu Java API for rapid DMLs .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 5: Build started:

[Impala-ASF-CR] [DOCS] Recommend using Kudu Java API for rapid DMLs

2018-01-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8976 ) Change subject: [DOCS] Recommend using Kudu Java API for rapid DMLs .. Patch Set 1: Code-Review+2 > JD are you an Impala

[Impala-ASF-CR] IMPALA-6371: Additional check for delimiters

2018-01-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8959 ) Change subject: IMPALA-6371: Additional check for delimiters .. Patch Set 3: (5 comments) Applied fixes.

[Impala-ASF-CR] IMPALA-6371: Additional check for delimiters

2018-01-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8959 ) Change subject: IMPALA-6371: Additional check for delimiters .. IMPALA-6371: Additional check for delimiters The check validates the

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 2: (1

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 8: thanks for the reviews! alex, pls have a look

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 8: Code-Review+1 Thanks, the backend part looks

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 4: Code-Review-1 (1 comment) Performance comparison:

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 12: I appreciate all your reviews! @John,

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2018-01-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2018-01-10 Thread Kim Jin Chul (Code Review)
Hello Thomas Tauber-Marshall, Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#6). Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2018-01-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output

2018-01-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 11: (4 comments)

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-10 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8820 to look at the new patch set (#11). Change subject: IMPALA-5654: Disallow setting

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-10 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#5). Change subject: IMPALA-3193: Show table's comment on show tables ..

  1   2   >