Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 )
Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command ...................................................................... Patch Set 5: (6 comments) Applied updates. http://gerrit.cloudera.org:8080/#/c/8928/3/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/8928/3/fe/src/main/cup/sql-parser.cup@1007 PS3, Line 1007: > I was not suggesting the hack as a solution. I was pointing out that the tw Ah, got it. Cleaned up and removed hack in L1015. http://gerrit.cloudera.org:8080/#/c/8928/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/8928/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2227 PS5, Line 2227: * operation, existing table data will not be converted to the new format. After > I suggest rephrasing the last sentence to: Done http://gerrit.cloudera.org:8080/#/c/8928/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2267 PS5, Line 2267: * reloaded. The return value is true if the fileMetadata needs to be reloaded. > Returns true if the file metadata to be reloaded. Done http://gerrit.cloudera.org:8080/#/c/8928/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2279 PS5, Line 2279: org.apache.hadoop.hive.metastore.api.Table msTbl = > fix indentation, we indent 2 Done http://gerrit.cloudera.org:8080/#/c/8928/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/8928/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@478 PS5, Line 478: String [] unsupportedFileFormatsStr = > unsupportedFileFormatDbs Done http://gerrit.cloudera.org:8080/#/c/8928/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@488 PS5, Line 488: > remove empty line Done -- To view, visit http://gerrit.cloudera.org:8080/8928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96e347463504915a6f33932552e4d1f61e9b1154 Gerrit-Change-Number: 8928 Gerrit-PatchSet: 5 Gerrit-Owner: Adam Holley <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Comment-Date: Wed, 10 Jan 2018 22:03:33 +0000 Gerrit-HasComments: Yes
