[Impala-ASF-CR] IMPALA-7466: Improve readability of describe authorization tests

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11278 ) Change subject: IMPALA-7466: Improve readability of describe authorization tests .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7466: Improve readability of describe authorization tests

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11278 ) Change subject: IMPALA-7466: Improve readability of describe authorization tests .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7466: Improve readability of describe authorization tests

2018-08-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11278 ) Change subject: IMPALA-7466: Improve readability of describe authorization tests .. Patch Set 3: > Patch Set 3: Verified-1 > > Build

[Impala-ASF-CR] IMPALA-7457. statestore: allow filtering by key prefix

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11253 ) Change subject: IMPALA-7457. statestore: allow filtering by key prefix .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7447. Evict LocalCatalog cache entries based on size

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11231 ) Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] cleanup: remove RuntimeState::exec env

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11269 ) Change subject: cleanup: remove RuntimeState::exec_env_ .. Patch Set 5: Build started:

[Impala-ASF-CR] cleanup: remove RuntimeState::exec env

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11269 ) Change subject: cleanup: remove RuntimeState::exec_env_ .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] cleanup: remove RuntimeState::exec env

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11269 ) Change subject: cleanup: remove RuntimeState::exec_env_ .. Patch Set 4: Hit IMPALA-7418 -- To view, visit

[Impala-ASF-CR] cleanup: remove RuntimeState::exec env

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11269 ) Change subject: cleanup: remove RuntimeState::exec_env_ .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7402: fix DCHECK when releasing reservation in scan

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11283 ) Change subject: IMPALA-7402: fix DCHECK when releasing reservation in scan .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7402: fix DCHECK when releasing reservation in scan

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11283 ) Change subject: IMPALA-7402: fix DCHECK when releasing reservation in scan .. IMPALA-7402: fix DCHECK when releasing

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7447. Evict LocalCatalog cache entries based on size

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11231 ) Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-7447. Evict LocalCatalog cache entries based on size

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11231 ) Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-7457. statestore: allow filtering by key prefix

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11253 ) Change subject: IMPALA-7457. statestore: allow filtering by key prefix .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7447. Evict LocalCatalog cache entries based on size

2018-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11231 ) Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-08-21 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11280 to look at the new patch set (#2). Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

[Impala-ASF-CR] IMPALA-7447. Evict LocalCatalog cache entries based on size

2018-08-21 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11231 to look at the new patch set (#6). Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size

[Impala-ASF-CR] IMPALA-7466: Improve readability of describe authorization tests

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11278 ) Change subject: IMPALA-7466: Improve readability of describe authorization tests .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-7349: Add Admission control support for automatically setting mem limit

2018-08-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 ) Change subject: IMPALA-7349: Add Admission control support for automatically setting mem_limit .. Patch Set 7: (5 comments)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 11: (15 comments)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-21 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Todd Lipcon, Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#11). Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

[Impala-ASF-CR] cleanup: remove RuntimeState::exec env

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11269 ) Change subject: cleanup: remove RuntimeState::exec_env_ .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] cleanup: remove RuntimeState::exec env

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11269 ) Change subject: cleanup: remove RuntimeState::exec_env_ .. Patch Set 4: Build started:

[native-toolchain-CR] IMPALA-6772: add ORC 1.5.2

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11254 ) Change subject: IMPALA-6772: add ORC 1.5.2 .. Patch Set 2: Build ID is 191-78f370624a -- To view, visit

[Impala-ASF-CR] cleanup: remove RuntimeState::exec env

2018-08-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/11269 ) Change subject: cleanup: remove RuntimeState::exec_env_ .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-08-21 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-08-21 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 10: (2 comments) > (4

[Impala-ASF-CR] IMPALA-7349: Add Admission control support for automatically setting mem limit

2018-08-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 ) Change subject: IMPALA-7349: Add Admission control support for automatically setting mem_limit .. Patch Set 7: (3 comments)

[Impala-ASF-CR] IMPALA-7349: Add Admission control support for automatically setting mem limit

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 ) Change subject: IMPALA-7349: Add Admission control support for automatically setting mem_limit .. Patch Set 7: (3 comments) I think

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11282 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 1: Code-Review+2 Might be good to run the fuzz

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-21 Thread David Knupp (Code Review)
Hello Lars Volker, Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11257 to look at the new patch set (#9). Change subject: IMPALA-7399: Emit a junit xml report when

[Impala-ASF-CR] IMPALA-7402: fix DCHECK when releasing reservation in scan

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11283 ) Change subject: IMPALA-7402: fix DCHECK when releasing reservation in scan .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7402: fix DCHECK when releasing reservation in scan

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11283 ) Change subject: IMPALA-7402: fix DCHECK when releasing reservation in scan .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7399: Sample usage of junit xml reporting

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Sample usage of junit xml reporting .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-7402: fix DCHECK when releasing reservation in scan

2018-08-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11283 ) Change subject: IMPALA-7402: fix DCHECK when releasing reservation in scan .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7349: Add Admission control support for automatically setting mem limit

2018-08-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 ) Change subject: IMPALA-7349: Add Admission control support for automatically setting mem_limit .. Patch Set 7: @Dan Any thoughts on

[Impala-ASF-CR] IMPALA-7399: Sample usage of junit xml reporting

2018-08-21 Thread David Knupp (Code Review)
Hello Lars Volker, Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11257 to look at the new patch set (#7). Change subject: IMPALA-7399: Sample usage of junit xml

[Impala-ASF-CR] IMPALA-7399: Sample usage of junit xml reporting

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Sample usage of junit xml reporting .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7399: Sample usage of junit xml reporting

2018-08-21 Thread David Knupp (Code Review)
Hello Lars Volker, Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11257 to look at the new patch set (#6). Change subject: IMPALA-7399: Sample usage of junit xml reporting

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11286 ) Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin .. IMPALA-6844: Fix possible NULL dereference

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11286 ) Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11286 ) Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7433: reduce logging on executors

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 ) Change subject: IMPALA-7433: reduce logging on executors .. Patch Set 4: (1 comment) I think there are good ideas but I was hoping

[Impala-ASF-CR] IMPALA-7465: fix test kudu scan mem usage

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11285 ) Change subject: IMPALA-7465: fix test_kudu_scan_mem_usage .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11241 ) Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11241 ) Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender .. IMPALA-7449: Fix network

[Impala-ASF-CR] [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls

2018-08-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10696 ) Change subject: [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls .. Patch Set 4: I was looking into other stuff and

[Impala-ASF-CR] IMPALA-7447. Evict LocalCatalog cache entries based on size

2018-08-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11231 ) Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7470: SentryServicePinger logs error messages on success

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11281 ) Change subject: IMPALA-7470: SentryServicePinger logs error messages on success .. IMPALA-7470: SentryServicePinger

[Impala-ASF-CR] IMPALA-7470: SentryServicePinger logs error messages on success

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11281 ) Change subject: IMPALA-7470: SentryServicePinger logs error messages on success .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11286 ) Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7433: reduce logging on executors

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 ) Change subject: IMPALA-7433: reduce logging on executors .. Patch Set 4: I don't think so, IMPALA-5845 is a can of worms that would

[Impala-ASF-CR] IMPALA-7465: fix test kudu scan mem usage

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11285 ) Change subject: IMPALA-7465: fix test_kudu_scan_mem_usage .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7433: reduce logging on executors

2018-08-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 ) Change subject: IMPALA-7433: reduce logging on executors .. Patch Set 4: Should we also looks at

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11286 ) Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Vincent Tran (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11286 to look at the new patch set (#3). Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11286 ) Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11286 ) Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11286 ) Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11286 ) Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11286 ) Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin .. Patch Set 2: Thanks for fixing -- To view, visit

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Vincent Tran (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11286 to look at the new patch set (#2). Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin

[native-toolchain-CR] IMPALA-6772: add ORC 1.5.2

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11254 ) Change subject: IMPALA-6772: add ORC 1.5.2 .. Patch Set 1: Verified+1 I did a test build on all platforms earlier. -- To view,

[native-toolchain-CR] IMPALA-6772: add ORC 1.5.2

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11254 ) Change subject: IMPALA-6772: add ORC 1.5.2 .. IMPALA-6772: add ORC 1.5.2 This version has some fixes that are needed for

[Impala-ASF-CR] IMPALA-6844: Fix possible NULL dereference in to date() builtin

2018-08-21 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11286 Change subject: IMPALA-6844: Fix possible NULL dereference in to_date() builtin .. IMPALA-6844: Fix possible NULL dereference in

[Impala-ASF-CR] IMPALA-7465: fix test kudu scan mem usage

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11285 ) Change subject: IMPALA-7465: fix test_kudu_scan_mem_usage .. Patch Set 1: Build Successful

[native-toolchain-CR] IMPALA-6772: add ORC 1.5.2

2018-08-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11254 ) Change subject: IMPALA-6772: add ORC 1.5.2 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11254

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11241 ) Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender .. Patch Set 5: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11241 ) Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7465: fix test kudu scan mem usage

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11285 ) Change subject: IMPALA-7465: fix test_kudu_scan_mem_usage .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7465: fix test kudu scan mem usage

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11285 ) Change subject: IMPALA-7465: fix test_kudu_scan_mem_usage .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7465: fix test kudu scan mem usage

2018-08-21 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11285 to look at the new patch set (#2). Change subject: IMPALA-7465: fix test_kudu_scan_mem_usage

[Impala-ASF-CR] IMPALA-7465: fix test kudu scan mem usage

2018-08-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11285 ) Change subject: IMPALA-7465: fix test_kudu_scan_mem_usage .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7465: fix test kudu scan mem usage

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11285 Change subject: IMPALA-7465: fix test_kudu_scan_mem_usage .. IMPALA-7465: fix test_kudu_scan_mem_usage The issue was that the row

[Impala-ASF-CR] IMPALA-6373: Allow primitive type widening on parquet tables

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11268 ) Change subject: IMPALA-6373: Allow primitive type widening on parquet tables .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-6373: Allow primitive type widening on parquet tables

2018-08-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11268 ) Change subject: IMPALA-6373: Allow primitive type widening on parquet tables .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 3: > Thanks. I'm considering this

[Impala-ASF-CR] IMPALA-6373: Allow primitive type widening on parquet tables

2018-08-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11268 ) Change subject: IMPALA-6373: Allow primitive type widening on parquet tables .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-6373: Allow primitive type widening on parquet tables

2018-08-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11268 ) Change subject: IMPALA-6373: Allow primitive type widening on parquet tables .. IMPALA-6373: Allow primitive type widening on parquet

[Impala-ASF-CR] docs: typo fix in PARQUET ARRAY RESOLUTION

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11284 ) Change subject: docs: typo fix in PARQUET_ARRAY_RESOLUTION .. Patch Set 1: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11282 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 1: Code-Review+1 lgtm The review would have

[Impala-ASF-CR] docs: typo fix in PARQUET ARRAY RESOLUTION

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11284 ) Change subject: docs: typo fix in PARQUET_ARRAY_RESOLUTION .. Patch Set 1: Build Started

[Impala-ASF-CR] docs: typo fix in PARQUET ARRAY RESOLUTION

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11284 Change subject: docs: typo fix in PARQUET_ARRAY_RESOLUTION .. docs: typo fix in PARQUET_ARRAY_RESOLUTION Change-Id:

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 9: (3 comments) Thanks for your response!

[Impala-ASF-CR] IMPALA-7470: SentryServicePinger logs error messages on success

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11281 ) Change subject: IMPALA-7470: SentryServicePinger logs error messages on success .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7402: fix DCHECK when releasing reservation in scan

2018-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11283 ) Change subject: IMPALA-7402: fix DCHECK when releasing reservation in scan .. Patch Set 3: Failure looks like it's due to a stale

[Impala-ASF-CR] IMPALA-7402: fix DCHECK when releasing reservation in scan

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11283 ) Change subject: IMPALA-7402: fix DCHECK when releasing reservation in scan .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-7402: fix DCHECK when releasing reservation in scan

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11283 ) Change subject: IMPALA-7402: fix DCHECK when releasing reservation in scan .. Patch Set 3: Build Failed

[Impala-ASF-CR] IMPALA-7433: reduce logging on executors

2018-08-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 ) Change subject: IMPALA-7433: reduce logging on executors .. Patch Set 4: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-7437. LRU caching of partitions in impalad

2018-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11208 ) Change subject: IMPALA-7437. LRU caching of partitions in impalad .. IMPALA-7437. LRU caching of partitions in impalad This

[Impala-ASF-CR] IMPALA-7402: fix DCHECK when releasing reservation in scan

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11283 ) Change subject: IMPALA-7402: fix DCHECK when releasing reservation in scan .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7436: initial fetch-from-catalogd implementation

2018-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11182 ) Change subject: IMPALA-7436: initial fetch-from-catalogd implementation .. IMPALA-7436: initial fetch-from-catalogd

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 3: Build Successful

  1   2   >