[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 15: (6 comments) I did a pass up to be/s

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-04-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/12481

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-04-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 23: Code-Review+2 Todd is out right now, but I took a look

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 8: Build Successful https://jenkins.imp

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 8: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-04-19 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Philip Zeyliger, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12299 to look at the new patch set (#8). Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-04-19 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 8: (6 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13016 ) Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev .. IMPALA-8414: Skip header when parsing /proc/net/

[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13016 ) Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev .. Patch Set 2: Verified+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 ) Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. Patch Set 5: Verified+1 -- To view, v

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13065 ) Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. IMPALA-8293 (Part 1): Move Sent

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. IMPALA-8270: fix MemTracker teardown in FeSupport This pa

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 23: Verified-1 Build failed: https

[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13016 ) Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev .. Patch Set 2: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 ) Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. Patch Set 4: Build Successful https:/

[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13016 ) Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev .. Patch Set 2: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev

2019-04-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13016 ) Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev .. Patch Set 2: Code-Review+2 (1 comment) Rebased, addressed commen

[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev

2019-04-19 Thread Lars Volker (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13016 to look at the new patch set (#2). Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 10: Build Successful https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 ) Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. Patch Set 4: Code-Review+2 (3 comments) Carry

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 ) Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. Patch Set 5: Build started: https://je

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 ) Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. Patch Set 5: Code-Review+2 -- To view

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13065 ) Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. IMPALA-8293 (Part 1): Move SentryProxy out of Cata

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 ) Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. Patch Set 3: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 23: Build started: https://jenkins

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 23: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 10: (12 comments) Thanks for the review. See patch set 10. http

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRet

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 4: Build Successful https://jenkins.impala.io/

[native-toolchain-CR] POC: IMPALA-7085: Extend CCTZ's interface with get offset()

2019-04-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12992 ) Change subject: POC: IMPALA-7085: Extend CCTZ's interface with get_offset() .. Patch Set 2: I think this makes sense. Are you consider

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 5: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Tim Armstrong (Code Review)
Hello Thomas Marshall, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13057 to look at the new patch set (#4). Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport ..

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 4: Code-Review+1 (1 comment) Carry http://gerrit.clou

[Impala-ASF-CR] IMPALA-7957: Fix slot equivalences may be enforced multiple times

2019-04-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13051 ) Change subject: IMPALA-7957: Fix slot equivalences may be enforced multiple times .. Patch Set 2: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8386: Fix incorrect equivalence conjuncts not treated as identity

2019-04-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12939 ) Change subject: IMPALA-8386: Fix incorrect equivalence conjuncts not treated as identity .. Patch Set 4: (2 comments) http://gerrit