[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 17: Build Successful

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-28 Thread wangsheng (Code Review)
wangsheng has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. IMPALA-10164: Supporting HadoopCatalog for Iceberg table This

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-28 Thread wangsheng (Code Review)
wangsheng has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. IMPALA-10164: Supporting HadoopCatalog for Iceberg table This

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

2020-09-28 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16291 ) Change subject: IMPALA-9180 (part 1): Remove legacy ImpalaInternalService .. Patch Set 11: It hits IMPALA-9923, failed in

[Impala-ASF-CR] IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16291 ) Change subject: IMPALA-9180 (part 1): Remove legacy ImpalaInternalService .. Patch Set 11: Verified-1 Build failed:

[Impala-ASF-CR] WIP: IMPALA-10189: don't reload partitions for stat operations

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16516 ) Change subject: WIP: IMPALA-10189: don't reload partitions for stat operations .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9664: Support hive replication

2020-09-28 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16439 ) Change subject: IMPALA-9664: Support hive replication .. IMPALA-9664: Support hive replication This patch makes some

[Impala-ASF-CR] IMPALA-9664: Support hive replication

2020-09-28 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16439 ) Change subject: IMPALA-9664: Support hive replication .. Patch Set 7: Code-Review+2 Carrying forward Zoltan's +2 from earlier.

[Impala-ASF-CR] IMPALA-9664: Support hive replication

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16439 ) Change subject: IMPALA-9664: Support hive replication .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. Patch Set 1: (2 comments) Thanks for doing this, nice to see

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-28 Thread Thomas Tauber-Marshall (Code Review)
Hello Sahil Takiar, Joe McDonnell, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16411 to look at the new patch set (#5). Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service

[Impala-ASF-CR] IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16291 ) Change subject: IMPALA-9180 (part 1): Remove legacy ImpalaInternalService .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16291 ) Change subject: IMPALA-9180 (part 1): Remove legacy ImpalaInternalService .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

2020-09-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16291 ) Change subject: IMPALA-9180 (part 1): Remove legacy ImpalaInternalService .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-28 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16517 Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

[Impala-ASF-CR] WIP: IMPALA-10189: don't reload partitions for stat operations

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16516 ) Change subject: WIP: IMPALA-10189: don't reload partitions for stat operations .. Patch Set 1: Build Successful

[Impala-ASF-CR] WIP: IMPALA-10189: don't reload partitions for stat operations

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16516 ) Change subject: WIP: IMPALA-10189: don't reload partitions for stat operations .. Patch Set 1: Build started:

[Impala-ASF-CR] WIP: IMPALA-10189: don't reload partitions for stat operations

2020-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16516 Change subject: WIP: IMPALA-10189: don't reload partitions for stat operations .. WIP: IMPALA-10189: don't reload partitions for stat

[Impala-ASF-CR] IMPALA-9664: Support hive replication

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16439 ) Change subject: IMPALA-9664: Support hive replication .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-9664: Support hive replication

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16439 ) Change subject: IMPALA-9664: Support hive replication .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-9664: Support hive replication

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16439 ) Change subject: IMPALA-9664: Support hive replication .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-9664: Support hive replication

2020-09-28 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/16439 ) Change subject: IMPALA-9664: Support hive replication .. IMPALA-9664: Support hive replication This patch makes some improvements

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 31: Build Successful

[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.04

2020-09-28 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16241 ) Change subject: IMPALA-10007: Impala development environment does not support Ubuntu 20.04 .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.04

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16241 ) Change subject: IMPALA-10007: Impala development environment does not support Ubuntu 20.04 .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-28 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#31). ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. IMPALA-10178 Run-time profile shall report skews This fix addresses

[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.04

2020-09-28 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/16241 ) Change subject: IMPALA-10007: Impala development environment does not support Ubuntu 20.04 .. IMPALA-10007: Impala development environment

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 ) Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query' .. Patch Set 1: Verified-1

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9952: Fix page index filtering for empty pages

2020-09-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16503 ) Change subject: IMPALA-9952: Fix page index filtering for empty pages .. Patch Set 1: Code-Review+1 (5 comments)

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 ) Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query' .. Patch Set 2: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 ) Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query' .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 30: Build Successful

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-28 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16511 to look at the new patch set (#2). Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-28 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#30). ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. IMPALA-10178 Run-time profile shall report skews This fix addresses

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-28 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16473 ) Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE .. IMPALA-10175: Extend error msg when

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16473 ) Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 15: Code-Review+1 (6 comments) Thanks for

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16512 ) Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-28 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16512 Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables .. IMPALA-10187: Add PARTITON BY SPEC to

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 ) Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query' .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16511 Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query' .. IMPALA-9923: Load ORC files as

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 ) Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query' .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-28 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 15: > Hi WangSheng, > > Yes, it's what I meant, I

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-28 Thread wangsheng (Code Review)
wangsheng has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. IMPALA-10164: Supporting HadoopCatalog for Iceberg table This