Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16503 )
Change subject: IMPALA-9952: Fix page index filtering for empty pages ...................................................................... Patch Set 1: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/16503/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16503/1//COMMIT_MSG@11 PS1, Line 11: date typo: data http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/hdfs-parquet-scanner.cc@637 PS1, Line 637: nit: extra line http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/hdfs-parquet-scanner.cc@724 PS1, Line 724: filter_pages Maybe make filter_pages a member, and reset it in ResetPageFiltering? http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/parquet-common.cc File be/src/exec/parquet/parquet-common.cc: http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/parquet-common.cc@142 PS1, Line 142: auto& last_valid_page = page_locations[last_valid_idx]; : can you add some comment in this block? e.g. first_row_index must have progressed in a non-empty page http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/parquet-common.cc@172 PS1, Line 172: while (next_page_idx < page_locations.size() && : page_locations[next_page_idx].compressed_page_size == 0) { : ++next_page_idx; : } I may have missed something, but wouldn't it be simpler to create a copy of the page_location vector and omit empty pages during ValidatePageLocations? -- To view, visit http://gerrit.cloudera.org:8080/16503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4db493fc7c383ed5ef492da29c9b15eeb3d17bb0 Gerrit-Change-Number: 16503 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 28 Sep 2020 15:45:10 +0000 Gerrit-HasComments: Yes
