[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-11 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 3: (8 comments)

[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter

2021-03-11 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 ) Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter .. Patch Set 3: Code-Review+1 Hi Shajini, thanks for the

[Impala-ASF-CR] IMPALA-7712: Support Google Cloud Storage

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17121 ) Change subject: IMPALA-7712: Support Google Cloud Storage .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-10377: Improve the accuracy of resource estimation

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 ) Change subject: IMPALA-10377: Improve the accuracy of resource estimation .. Patch Set 21: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7712: Support Google Cloud Storage

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17121 ) Change subject: IMPALA-7712: Support Google Cloud Storage .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables

2021-03-11 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/17130 ) Change subject: IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables .. Patch Set 3: Code-Review+1 Thanks for change, this patch LGTM!

[Impala-ASF-CR] IMPALA-7712: Support Google Cloud Storage

2021-03-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17121 ) Change subject: IMPALA-7712: Support Google Cloud Storage .. Patch Set 10: Finished the analysis on IMPALA-10563. The timeout issues

[Impala-ASF-CR] IMPALA-7712: Support Google Cloud Storage

2021-03-11 Thread Quanlong Huang (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17121 to look at the new patch set (#10). Change subject: IMPALA-7712: Support Google Cloud Storage

[Impala-ASF-CR] IMPALA-7712: Support Google Cloud Storage

2021-03-11 Thread Quanlong Huang (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17121 to look at the new patch set (#9). Change subject: IMPALA-7712: Support Google Cloud Storage

[Impala-ASF-CR] IMPALA-10579: Fix usage of RemoteIterator in FileSystemUtil

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17171 ) Change subject: IMPALA-10579: Fix usage of RemoteIterator in FileSystemUtil .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. IMPALA-9218: Add support for locally compiled

[Impala-ASF-CR] IMPALA-10377: Improve the accuracy of resource estimation

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 ) Change subject: IMPALA-10377: Improve the accuracy of resource estimation .. Patch Set 21: Build started:

[Impala-ASF-CR] IMPALA-10546: Add ImpalaServer interface to retrieve BackendConfig from impalad

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17116 ) Change subject: IMPALA-10546: Add ImpalaServer interface to retrieve BackendConfig from impalad .. Patch Set 16: Verified+1

[Impala-ASF-CR] IMPALA-10579: Fix usage of RemoteIterator in FileSystemUtil

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17171 ) Change subject: IMPALA-10579: Fix usage of RemoteIterator in FileSystemUtil .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-10579: Fix usage of RemoteIterator in FileSystemUtil

2021-03-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17171 ) Change subject: IMPALA-10579: Fix usage of RemoteIterator in FileSystemUtil .. Patch Set 4: > Patch Set 4: Verified-1 > > Build

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 3: Following up on private

[Impala-ASF-CR] IMPALA-10576: Add refresh authorization to make a test case less flaky

2021-03-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17165 ) Change subject: IMPALA-10576: Add refresh authorization to make a test case less flaky .. IMPALA-10576: Add refresh

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-11 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17166 to look at the new patch set (#3). Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit

[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-10579: Fix usage of RemoteIterator in FileSystemUtil

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17171 ) Change subject: IMPALA-10579: Fix usage of RemoteIterator in FileSystemUtil .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-03-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 ) Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. Patch Set 3: Code-Review+1

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17144 ) Change subject: IMPALA-10551: Add result sink support for external frontends .. Patch Set 6: (4 comments) This is making sense to

[Impala-ASF-CR] IMPALA-10377: Improve the accuracy of resource estimation

2021-03-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 ) Change subject: IMPALA-10377: Improve the accuracy of resource estimation .. Patch Set 21: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10546: Add ImpalaServer interface to retrieve BackendConfig from impalad

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17116 ) Change subject: IMPALA-10546: Add ImpalaServer interface to retrieve BackendConfig from impalad .. Patch Set 16: Build

[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 ) Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter .. Patch Set 3: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 ) Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter .. Patch Set 3: Build Started

[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter

2021-03-11 Thread Shajini Thayasingh (Code Review)
Hello Tamas Mate, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17131 to look at the new patch set (#3). Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter

[Impala-ASF-CR] IMPALA-10576: Add refresh authorization to make a test case less flaky

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17165 ) Change subject: IMPALA-10576: Add refresh authorization to make a test case less flaky .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-10576: Add refresh authorization to make a test case less flaky

2021-03-11 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17165 ) Change subject: IMPALA-10576: Add refresh authorization to make a test case less flaky .. IMPALA-10576: Add refresh authorization to make

[Impala-ASF-CR] IMPALA-10579: Fix usage of RemoteIterator in FileSystemUtil

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17171 ) Change subject: IMPALA-10579: Fix usage of RemoteIterator in FileSystemUtil .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 ) Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1 .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 ) Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1 .. Patch Set 16: (182 comments)

[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1

2021-03-11 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/17026 ) Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1 .. IMPALA-9470: Use Parquet Bloom filters - Part 1 This change adds

[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter

2021-03-11 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 ) Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter .. Patch Set 2: (5 comments) Hi Shajini, thank you for the

[Impala-ASF-CR] IMPALA-10367: Impala-shell internal error - UnboundLocalError, local variable 'retry msg' referenced before assign

2021-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17172 ) Change subject: IMPALA-10367: Impala-shell internal error - UnboundLocalError, local variable 'retry_msg' referenced before assign