[Impala-ASF-CR] IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18366 ) Change subject: IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue .. Patch Set 10: Build started: ht

[Impala-ASF-CR] IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18366 ) Change subject: IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue .. Patch Set 10: Code-Review+2 --

[Impala-ASF-CR] IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue

2022-04-04 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18366 ) Change subject: IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue .. Patch Set 9: > Patch Set 9: Verified-1

[Impala-ASF-CR] IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18366 ) Change subject: IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue .. Patch Set 9: Verified-1 Build f

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 15: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#15). Change subject: IMPALA-11123: Optimize count(star) for ORC scans .

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 14: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 14: Patch set 14 modify test_file_parser.py to allow mult

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#14). Change subject: IMPALA-11123: Optimize count(star) for ORC scans .

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-10737: Optimize the number of Iceberg API Metadata requests

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18353 ) Change subject: IMPALA-10737: Optimize the number of Iceberg API Metadata requests .. IMPALA-10737: Optimize the numbe

[Impala-ASF-CR] IMPALA-10737: Optimize the number of Iceberg API Metadata requests

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18353 ) Change subject: IMPALA-10737: Optimize the number of Iceberg API Metadata requests .. Patch Set 6: Verified+1 -- To view, vi

[Impala-ASF-CR] IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18366 ) Change subject: IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue .. Patch Set 9: Code-Review+2 --

[Impala-ASF-CR] IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18366 ) Change subject: IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue .. Patch Set 9: Build started: htt

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 13: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 13: Patch set 13 address test breakage due to 'RowsRead'

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#13). Change subject: IMPALA-11123: Optimize count(star) for ORC scans .

[Impala-ASF-CR] IMPALA-11115: Fix hitting DCHECK for brotli and deflate compressions

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18242 ) Change subject: IMPALA-5: Fix hitting DCHECK for brotli and deflate compressions .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-11115: Fix hitting DCHECK for brotli and deflate compressions

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18242 ) Change subject: IMPALA-5: Fix hitting DCHECK for brotli and deflate compressions .. IMPALA-5: Fix hitting DCHE

[Impala-ASF-CR] IMPALA-11153: Make lock wait time configurable for the users

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18289 ) Change subject: IMPALA-11153: Make lock wait time configurable for the users .. Patch Set 11: Verified+1 -- To view, visit ht

[Impala-ASF-CR] IMPALA-10737: Optimize the number of Iceberg API Metadata requests

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18353 ) Change subject: IMPALA-10737: Optimize the number of Iceberg API Metadata requests .. Patch Set 6: Build started: https://jen

[Impala-ASF-CR] IMPALA-10737: Optimize the number of Iceberg API Metadata requests

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18353 ) Change subject: IMPALA-10737: Optimize the number of Iceberg API Metadata requests .. Patch Set 6: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10737: Optimize the number of Iceberg API Metadata requests

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18353 ) Change subject: IMPALA-10737: Optimize the number of Iceberg API Metadata requests .. Patch Set 5: Build Successful https://

[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18094 ) Change subject: IMPALA-11038: Zipping unnest from view .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-10737: Optimize the number of Iceberg API Metadata requests

2022-04-04 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18353 ) Change subject: IMPALA-10737: Optimize the number of Iceberg API Metadata requests .. IMPALA-10737: Optimize the number of Iceberg API Meta

[Impala-ASF-CR] IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18366 ) Change subject: IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue .. Patch Set 8: Build failed: http

[Impala-ASF-CR] IMPALA-11153: Make lock wait time configurable for the users

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18289 ) Change subject: IMPALA-11153: Make lock wait time configurable for the users .. Patch Set 13: Build Successful https://jenkin

[Impala-ASF-CR] IMPALA-11153: Make lock wait time configurable for the users

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18289 ) Change subject: IMPALA-11153: Make lock wait time configurable for the users .. Patch Set 12: Build Successful https://jenkin

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 12: > Patch Set 12: Verified-1 > > Build failed: https://

[Impala-ASF-CR] IMPALA-11153: Make lock wait time configurable for the users

2022-04-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18289 ) Change subject: IMPALA-11153: Make lock wait time configurable for the users .. Patch Set 10: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-11153: Make lock wait time configurable for the users

2022-04-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18289 to look at the new patch set (#13). Change subject: IMPALA-11153: Make lock wait time configurable for the users .

[Impala-ASF-CR] IMPALA-11153: Make lock wait time configurable for the users

2022-04-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18289 ) Change subject: IMPALA-11153: Make lock wait time configurable for the users .. Patch Set 10: (3 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-11153: Make lock wait time configurable for the users

2022-04-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18289 to look at the new patch set (#12). Change subject: IMPALA-11153: Make lock wait time configurable for the users .

[Impala-ASF-CR] IMPALA-11115: Fix hitting DCHECK for brotli and deflate compressions

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18242 ) Change subject: IMPALA-5: Fix hitting DCHECK for brotli and deflate compressions .. Patch Set 2: Build started: https://j

[Impala-ASF-CR] IMPALA-11115: Fix hitting DCHECK for brotli and deflate compressions

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18242 ) Change subject: IMPALA-5: Fix hitting DCHECK for brotli and deflate compressions .. Patch Set 2: Code-Review+2 -- To vie

[Impala-ASF-CR] IMPALA-11153: Make lock wait time configurable for the users

2022-04-04 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18289 ) Change subject: IMPALA-11153: Make lock wait time configurable for the users .. Patch Set 10: (4 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-11115: Fix hitting DCHECK for brotli and deflate compressions

2022-04-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18242 ) Change subject: IMPALA-5: Fix hitting DCHECK for brotli and deflate compressions .. Patch Set 1: Code-Review+2 LGTM! -- To

[Impala-ASF-CR] IMPALA-11153: Make lock wait time configurable for the users

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18289 ) Change subject: IMPALA-11153: Make lock wait time configurable for the users .. Patch Set 11: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-11115: Fix hitting DCHECK for brotli and deflate compressions

2022-04-04 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18242 ) Change subject: IMPALA-5: Fix hitting DCHECK for brotli and deflate compressions .. Patch Set 1: Code-Review+1 Looks good to

[Impala-ASF-CR] IMPALA-10272: LOAD DATA should respect Ranger-HDFS policies

2022-04-04 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18373 ) Change subject: IMPALA-10272: LOAD DATA should respect Ranger-HDFS policies .. Patch Set 3: Code-Review+1 (1 comment) Looks great! Than

[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view

2022-04-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18094 ) Change subject: IMPALA-11038: Zipping unnest from view .. Patch Set 9: carry +2 from Csaba -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18094 ) Change subject: IMPALA-11038: Zipping unnest from view .. Patch Set 9: Build started: https://jenkins.impala.io/job/gerrit-ver

[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18094 ) Change subject: IMPALA-11038: Zipping unnest from view .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-

[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view

2022-04-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18094 ) Change subject: IMPALA-11038: Zipping unnest from view .. Patch Set 9: PS9 is rebase with master -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view

2022-04-04 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18094 to look at the new patch set (#9). Change subject: IMPALA-11038: Zipping unnest from view .

[Impala-ASF-CR] IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18366 ) Change subject: IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue .. Patch Set 8: Build started: htt

[Impala-ASF-CR] IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18366 ) Change subject: IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue .. Patch Set 8: Verified-1 Build f

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 12: Verified-1 Build failed: https://jenkins.imp

[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view

2022-04-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18094 ) Change subject: IMPALA-11038: Zipping unnest from view .. Patch Set 8: Code-Review+2 (3 comments) I still think that there are poss

[Impala-ASF-CR] IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18366 ) Change subject: IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue .. Patch Set 8: Build started: htt

[Impala-ASF-CR] IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue

2022-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18366 ) Change subject: IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue .. Patch Set 8: Code-Review+2 --

[native-toolchain-CR] IMPALA-11220: Bump ORC to 1.7.0-p8 for ORC-1137

2022-04-04 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18380 ) Change subject: IMPALA-11220: Bump ORC to 1.7.0-p8 for ORC-1137 .. IMPALA-11220: Bump ORC to 1.7.0-p8 for ORC-1137 ORC-1137 i

[native-toolchain-CR] IMPALA-11220: Bump ORC to 1.7.0-p8 for ORC-1137

2022-04-04 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18380 ) Change subject: IMPALA-11220: Bump ORC to 1.7.0-p8 for ORC-1137 .. Patch Set 1: Verified+1 Thank Csaba for the quick review! -- To

[native-toolchain-CR] IMPALA-10854: Use ZSTD in toolchain to build ORC

2022-04-04 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18367 ) Change subject: IMPALA-10854: Use ZSTD in toolchain to build ORC .. IMPALA-10854: Use ZSTD in toolchain to build ORC The ORC