[Impala-ASF-CR] [tools] Fix building shell pypi package

2022-06-02 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18578 ) Change subject: [tools] Fix building shell_pypi_package .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18578/2/CMakeLi

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-06-02 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. Patch Set 18: >

[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18587 ) Change subject: [tools] Fix tar argument ordering to exclude .pyc .. Patch Set 3: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18587 ) Change subject: [tools] Fix tar argument ordering to exclude .pyc .. Patch Set 3: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc

2022-06-02 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18587 ) Change subject: [tools] Fix tar argument ordering to exclude .pyc .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

2022-06-02 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 ) Change subject: IMPALA-9718: Delete pkg_resources from impala-shell .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 ) Change subject: IMPALA-8373: Test impala-shell with python3 .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-06-02 Thread Jian Zhang (Code Review)
Jian Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. Patch Set 18: (1 comment) http

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

2022-06-02 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 ) Change subject: IMPALA-8373: Test impala-shell with python3 .. Patch Set 2: > Patch Set 1: > > Build Failed > > https://jenkins.impala

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 ) Change subject: IMPALA-8373: Test impala-shell with python3 .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-11314: Test PyPI package with system python

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18586 ) Change subject: IMPALA-11314: Test PyPI package with system python .. Patch Set 3: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-11314: Test PyPI package with system python

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18586 ) Change subject: IMPALA-11314: Test PyPI package with system python .. Patch Set 2: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 ) Change subject: IMPALA-8373: Test impala-shell with python3 .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-11314: Test PyPI package with system python

2022-06-02 Thread Michael Smith (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18586 to look at the new patch set (#3). Change subject: IMPALA-11314: Test PyPI package with system python .. I

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

2022-06-02 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18588 Change subject: IMPALA-8373: Test impala-shell with python3 .. IMPALA-8373: Test impala-shell with python3 Sets up a python3 virtualenv

[Impala-ASF-CR] IMPALA-11314: Test PyPI package with system python

2022-06-02 Thread Michael Smith (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18586 to look at the new patch set (#2). Change subject: IMPALA-11314: Test PyPI package with system python .. I

[Impala-ASF-CR] Python3 testing

2022-06-02 Thread Michael Smith (Code Review)
Michael Smith has restored this change. ( http://gerrit.cloudera.org:8080/18586 ) Change subject: Python3 testing .. Restored -- To view, visit http://gerrit.cloudera.org:8080/18586 To unsubscribe, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-11314: Test PyPI package with system python

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18586 ) Change subject: IMPALA-11314: Test PyPI package with system python .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18587 ) Change subject: [tools] Fix tar argument ordering to exclude .pyc .. Patch Set 1: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] Python3 testing

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18586 ) Change subject: Python3 testing .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1068

[Impala-ASF-CR] Python3 testing

2022-06-02 Thread Michael Smith (Code Review)
Michael Smith has abandoned this change. ( http://gerrit.cloudera.org:8080/18586 ) Change subject: Python3 testing .. Abandoned Didn't mean to submit this yet (or as part of fixing tar). -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] Python3 testing

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18586 ) Change subject: Python3 testing .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18586/1/shell/make_shell_tarb

[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc

2022-06-02 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18587 Change subject: [tools] Fix tar argument ordering to exclude .pyc .. [tools] Fix tar argument ordering to exclude .pyc Moves `--exclude

[Impala-ASF-CR] Python3 testing

2022-06-02 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18586 Change subject: Python3 testing .. Python3 testing Change-Id: I384ea6a7dab51945828cca629860400a23fa0c05 --- M CMakeLists.txt M bin/impa

[Impala-ASF-CR] [tools] Fix building shell pypi package

2022-06-02 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18578 ) Change subject: [tools] Fix building shell_pypi_package .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18578/2/CMake

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 ) Change subject: IMPALA-9718: Delete pkg_resources from impala-shell .. Patch Set 1: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18583 ) Change subject: IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables .. Patch Set 2: Verified+1 -

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

2022-06-02 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18585 Change subject: IMPALA-9718: Delete pkg_resources from impala-shell .. IMPALA-9718: Delete pkg_resources from impala-shell This reverts

[Impala-ASF-CR] IMPALA-11279: Optimize plain count(*) queries for Iceberg tables

2022-06-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18574 ) Change subject: IMPALA-11279: Optimize plain count(*) queries for Iceberg tables .. Patch Set 3: (2 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause

2022-06-02 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause .. IMPALA-11284: Enable expressi

[Impala-ASF-CR] IMPALA-9410: Support resolving ORC file columns by names

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18397 ) Change subject: IMPALA-9410: Support resolving ORC file columns by names .. IMPALA-9410: Support resolving ORC file col

[Impala-ASF-CR] IMPALA-9410: Support resolving ORC file columns by names

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18397 ) Change subject: IMPALA-9410: Support resolving ORC file columns by names .. Patch Set 13: Verified+1 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18514 ) Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name .. Patch Set 7: Verified+1 -- To

[Impala-ASF-CR] IMPALA-11279: Optimize plain count(*) queries for Iceberg tables

2022-06-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18574 ) Change subject: IMPALA-11279: Optimize plain count(*) queries for Iceberg tables .. Patch Set 6: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-11323: Do not infer predicates on equivalent values

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18579 ) Change subject: IMPALA-11323: Do not infer predicates on equivalent values .. Patch Set 2: Build Successful https://jenkins.i

[Impala-ASF-CR] IMPALA-11323: Do not infer predicates on equivalent values

2022-06-02 Thread Steve Carlin (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18579 to look at the new patch set (#2). Change subject: IMPALA-11323: Do not infer predicates on equivalent values .

[Impala-ASF-CR] IMPALA-11279: Optimize plain count(*) queries for Iceberg tables

2022-06-02 Thread Anonymous Coward (Code Review)
lipeng...@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/18574 ) Change subject: IMPALA-11279: Optimize plain count(*) queries for Iceberg tables .. Patch Set 6: (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-11279: Optimize plain count(*) queries for Iceberg tables

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18574 ) Change subject: IMPALA-11279: Optimize plain count(*) queries for Iceberg tables .. Patch Set 6: Build Successful https://jen

[Impala-ASF-CR] IMPALA-11279: Optimize plain count(*) queries for Iceberg tables

2022-06-02 Thread Anonymous Coward (Code Review)
lipeng...@sensorsdata.cn has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18574 ) Change subject: IMPALA-11279: Optimize plain count(*) queries for Iceberg tables .. IMPALA-11279: Optimize plain count(*) quer

[Impala-ASF-CR] IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18583 ) Change subject: IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables .. Patch Set 1: Build Success

[Impala-ASF-CR] IMPALA-11302, IMPALA-11303: Fix error handling of external Iceberg tables

2022-06-02 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18563 ) Change subject: IMPALA-11302, IMPALA-11303: Fix error handling of external Iceberg tables .. Patch Set 3: Code-Review+1 LGTM --

[Impala-ASF-CR] IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18583 ) Change subject: IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables .. Patch Set 2: Build started

[Impala-ASF-CR] IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

2022-06-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18583 Change subject: IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables .. IMPALA-11335: allocate WriteId bef

[Impala-ASF-CR] IMPALA-9410: Support resolving ORC file columns by names

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18397 ) Change subject: IMPALA-9410: Support resolving ORC file columns by names .. Patch Set 13: Build started: https://jenkins.impal

[Impala-ASF-CR] IMPALA-9410: Support resolving ORC file columns by names

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18397 ) Change subject: IMPALA-9410: Support resolving ORC file columns by names .. Patch Set 13: Code-Review+2 -- To view, visit htt

[Impala-ASF-CR] IMPALA-9410: Support resolving ORC file columns by names

2022-06-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18397 ) Change subject: IMPALA-9410: Support resolving ORC file columns by names .. Patch Set 12: Code-Review+2 Nice work! -- To view, v

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18514 ) Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18514 ) Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name .. Patch Set 7: Build started: ht

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-06-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Tamas Mate, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18514 to look at the new patch set (#7). Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name

[Impala-ASF-CR] IMPALA-5845: Limit the number of non-fatal errors logging to INFO

2022-06-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18565 ) Change subject: IMPALA-5845: Limit the number of non-fatal errors logging to INFO .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11332: Fix trailing whitespace for CSV output

2022-06-02 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18580 ) Change subject: IMPALA-11332: Fix trailing whitespace for CSV output .. IMPALA-11332: Fix trailing whitespace for CSV output

[Impala-ASF-CR] IMPALA-11332: Fix trailing whitespace for CSV output

2022-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18580 ) Change subject: IMPALA-11332: Fix trailing whitespace for CSV output .. Patch Set 3: Verified+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-11332: Fix trailing whitespace for CSV output

2022-06-02 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18580 ) Change subject: IMPALA-11332: Fix trailing whitespace for CSV output .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.c