[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. Patch Set 6: Build

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. Patch Set 4: Verified-1

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. Patch Set 6: Build

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. Patch Set 5: Build

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Yu-Wen Lai (Code Review)
Yu-Wen Lai has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. IMPALA-8592: Add support for insert

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. Patch Set 5: (1

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Yu-Wen Lai (Code Review)
Yu-Wen Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Yu-Wen Lai (Code Review)
Yu-Wen Lai has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. IMPALA-8592: Add support for insert

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-03 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19080 ) Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11634: Provide an option to use Java 11 for docker images

2022-10-03 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19031 ) Change subject: IMPALA-11634: Provide an option to use Java 11 for docker images .. Patch Set 13: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11632: Exclude log4j-1.2-api in some Ranger artifacts

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19085 ) Change subject: IMPALA-11632: Exclude log4j-1.2-api in some Ranger artifacts .. IMPALA-11632: Exclude log4j-1.2-api in

[Impala-ASF-CR] IMPALA-11632: Exclude log4j-1.2-api in some Ranger artifacts

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19085 ) Change subject: IMPALA-11632: Exclude log4j-1.2-api in some Ranger artifacts .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19080 ) Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh

2022-10-03 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19088 ) Change subject: IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh .. Patch Set 2: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2022-10-03 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 16: (9 comments)

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Yu-Wen Lai (Code Review)
Yu-Wen Lai has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. IMPALA-8592: Add support for insert

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-10851: Codegen for structs

2022-10-03 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18526 ) Change subject: IMPALA-10851: Codegen for structs .. Patch Set 13: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19088 ) Change subject: IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Yu-Wen Lai (Code Review)
Yu-Wen Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-11632: Exclude log4j-1.2-api in some Ranger artifacts

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19085 ) Change subject: IMPALA-11632: Exclude log4j-1.2-api in some Ranger artifacts .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-11632: Exclude log4j-1.2-api in some Ranger artifacts

2022-10-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19085 ) Change subject: IMPALA-11632: Exclude log4j-1.2-api in some Ranger artifacts .. Patch Set 1: Code-Review+2 This makes sense to me

[Impala-ASF-CR] IMPALA-11632: Exclude log4j-1.2-api in some Ranger artifacts

2022-10-03 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19085 ) Change subject: IMPALA-11632: Exclude log4j-1.2-api in some Ranger artifacts .. Patch Set 1: According to

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19080 ) Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19088 ) Change subject: IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19080 ) Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-11634: Provide an option to use Java 11 for docker images

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19031 ) Change subject: IMPALA-11634: Provide an option to use Java 11 for docker images .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-8770: Support building Docker images on Redhat-based distributions

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19006 ) Change subject: IMPALA-8770: Support building Docker images on Redhat-based distributions .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh

2022-10-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19088 ) Change subject: IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh

2022-10-03 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19088 to look at the new patch set (#2). Change subject: IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-03 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19080 to look at the new patch set (#3). Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images

[Impala-ASF-CR] IMPALA-8770: Support building Docker images on Redhat-based distributions

2022-10-03 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19006 to look at the new patch set (#13). Change subject: IMPALA-8770: Support building Docker images on Redhat-based distributions

[Impala-ASF-CR] IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh

2022-10-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19088 Change subject: IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh .. IMPALA-11610: Pass environment

[Impala-ASF-CR] IMPALA-11634: Provide an option to use Java 11 for docker images

2022-10-03 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19031 to look at the new patch set (#12). Change subject: IMPALA-11634: Provide an option to use Java 11 for docker images

[Impala-ASF-CR] IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19088 ) Change subject: IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2022-10-03 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner changes for CPU usage This patch augments IMPALA-10992

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2022-10-03 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 16: Improved formula for hash and nested joins. -- To view,

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2022-10-03 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 15: (1 comment) Refactoring on processing cost by moving the

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2022-10-03 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner changes for CPU usage This patch augments IMPALA-10992

[Impala-ASF-CR] IMPALA-10356: Fix SetOperationStmt::toSql() for VALUES statement with single value

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19048 ) Change subject: IMPALA-10356: Fix SetOperationStmt::toSql() for VALUES statement with single value .. Patch Set 8: Verified-1

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-10-03 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 7: (7 comments) Generally looks good

[Impala-ASF-CR] IMPALA-10851: Codegen for structs

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18526 ) Change subject: IMPALA-10851: Codegen for structs .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-10356: Fix SetOperationStmt::toSql() for VALUES statement with single value

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19048 ) Change subject: IMPALA-10356: Fix SetOperationStmt::toSql() for VALUES statement with single value .. Patch Set 8:

[Impala-ASF-CR] IMPALA-10356: Fix SetOperationStmt::toSql() for VALUES statement with single value

2022-10-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19048 ) Change subject: IMPALA-10356: Fix SetOperationStmt::toSql() for VALUES statement with single value .. Patch Set 8: Build

[Impala-ASF-CR] IMPALA-10851: Codegen for structs

2022-10-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18526 ) Change subject: IMPALA-10851: Codegen for structs .. Patch Set 13: (2 comments)

[Impala-ASF-CR] IMPALA-10851: Codegen for structs

2022-10-03 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/18526 ) Change subject: IMPALA-10851: Codegen for structs .. IMPALA-10851: Codegen for structs IMPALA-9495 added support for struct types in

[Impala-ASF-CR] IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala

2022-10-03 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 ) Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-11504: Specializing DecimalUtil::GetScaleMultiplier().

2022-10-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18861 ) Change subject: IMPALA-11504: Specializing DecimalUtil::GetScaleMultiplier(). .. Patch Set 6: (4 comments)