[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-11 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 3: Thank you for the review Daniel and Zoltan. I wi

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 6: Build st

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 6: Code-Revi

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 5: Code-Review+2 L

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 5: Build Su

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-11 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 5: (1 comme

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-11 Thread Sai Hemanth Gantasala (Code Review)
Hello Quanlong Huang, Daniel Becker, Yu-Wen Lai, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19140 to look at the new patch set (#5). Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 me

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 5: (1 comme

[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 ) Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs .. Patch Set 2: Build Successful https://j

[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs

2023-01-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 ) Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs .. Patch Set 2: Code-Review+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs

2023-01-11 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 ) Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs

2023-01-11 Thread Yida Wu (Code Review)
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19415 ) Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs .. IMPALA-11836: Remove duplicated information in codegen ca

[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 ) Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs .. Patch Set 2: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 4: Code-Review+1 (

[Impala-ASF-CR] IMPALA-11476: Test Ozone with erasure coding

2023-01-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19324 ) Change subject: IMPALA-11476: Test Ozone with erasure coding .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/19324/8/

[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs

2023-01-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 ) Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs .. Patch Set 1: (1 comment) Thanks Yida! Just have

[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 ) Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs .. Patch Set 1: Build Successful https://j

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 7: Build Successful https://jenkins.imp

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 7: The gerrit-verify-dryrun tests run the docke

[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs

2023-01-11 Thread Yida Wu (Code Review)
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19415 Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs .. IMPALA-11836: Remove duplicated information in codegen c

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-11 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#7). Change subject: IMPALA-10893: Use old schema during iceberg time travel. ..

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. IMPALA-11834: Fix Iceberg LOAD DATA hdfsDel

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 2: Verified+1 -- To view, visit http://

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 2: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length in case of metadata rewrite

2023-01-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length in case of metadata rewrite .. Patch Set 1: Code-Review+1 IMPALA-11821 talks

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length in case of metadata rewrite

2023-01-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length in case of metadata rewrite .. Patch Set 1: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 2: Verified-1 Build failed: https://jenk

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length in case of metadata rewrite

2023-01-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length in case of metadata rewrite .. Patch Set 1: Code-Review+2 This seems fine.

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length in case of metadata rewrite

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length in case of metadata rewrite .. Patch Set 1: Build Successful https:/

[Impala-ASF-CR] IMPALA-11833: Fixed manifest length in snapshot files

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19409 ) Change subject: IMPALA-11833: Fixed manifest_length in snapshot files .. Patch Set 3: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length in case of metadata rewrite

2023-01-11 Thread Code Review
Gergely Fürnstáhl has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19412 Change subject: IMPALA-11821: Adjusting manifest_length in case of metadata rewrite .. IMPALA-11821: Adjusting manifest_length in c

[Impala-ASF-CR] IMPALA-11833: Fixed manifest length in snapshot files

2023-01-11 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19409 ) Change subject: IMPALA-11833: Fixed manifest_length in snapshot files .. IMPALA-11833: Fixed manifest_length in snapshot files Some

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length in case of metadata rewrite

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length in case of metadata rewrite .. Patch Set 1: (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 11: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-11 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list Currentl

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 10: (3 comments) only looked through the tests s

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 1: Code-Review+2 LGTM since the existing tes

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 2: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 2: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 4: Code-Review+1 -