[Impala-ASF-CR] IMPALA-3120: Support Bucket Shuffle Join for bucketed table

2023-02-21 Thread Baike Xia (Code Review)
Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/19430 ) Change subject: IMPALA-3120: Support Bucket Shuffle Join for bucketed table .. Patch Set 13: (1 comment) > Patch Set 13: > > (1 comment)

[native-toolchain-CR] IMPALA-11927: Enable frame pointers for snappy and lz4

2023-02-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19521 ) Change subject: IMPALA-11927: Enable frame pointers for snappy and lz4 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. Patch Set 7: Build Successful https://jenk

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-21 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. Patch Set 7: Code-Review+1 -- To view, visit http://

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-21 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. Patch Set 7: (14 comments) addressed additional comme

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-21 Thread Jason Fehr (Code Review)
Jason Fehr has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. IMPALA-11922 Verify JWKS URL server TLS certificate by de

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-02-21 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 49: (3 comments) http://gerrit.cloudera.org:8080/#/c/19033/48//

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

2023-02-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing. .. Patch Set 2: (2 comments) Thanks for the r

[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 ) Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class .. Patc

[Impala-ASF-CR] IMPALA-11626: Handle COMMIT COMPACTION EVENT from HMS

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19155 ) Change subject: IMPALA-11626: Handle COMMIT_COMPACTION_EVENT from HMS .. Patch Set 10: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 ) Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class .. Patc

[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class

2023-02-21 Thread Sai Hemanth Gantasala (Code Review)
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, John Sherman, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19508 to look at the new patch set (#2). Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the Metastor

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-21 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. Patch Set 6: (3 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-11626: Handle COMMIT COMPACTION EVENT from HMS

2023-02-21 Thread Sai Hemanth Gantasala (Code Review)
Hello Quanlong Huang, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19155 to look at the new patch set (#10). Change subject: IMPALA-11626: Handle COMMIT_COMPACTION_EVENT from HMS ..

[Impala-ASF-CR] IMPALA-11626: Handle COMMIT COMPACTION EVENT from HMS

2023-02-21 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19155 ) Change subject: IMPALA-11626: Handle COMMIT_COMPACTION_EVENT from HMS .. Patch Set 9: (4 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. Patch Set 6: (11 comments) Mostly comments about

[native-toolchain-CR] IMPALA-11927: Enable frame pointers for snappy and lz4

2023-02-21 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19521 ) Change subject: IMPALA-11927: Enable frame pointers for snappy and lz4 .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera

[native-toolchain-CR] IMPALA-11927: Enable frame pointers for snappy and lz4

2023-02-21 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19521 ) Change subject: IMPALA-11927: Enable frame pointers for snappy and lz4 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. Patch Set 6: Build Successful https://jenk

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-21 Thread Jason Fehr (Code Review)
Jason Fehr has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. IMPALA-11922 Verify JWKS URL server TLS certificate by de

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19487 ) Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types .. IMPALA-11869: Use to_string()

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 ) Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types .. Patch Set 4: Verified+1 -- To view,

[native-toolchain-CR] IMPALA-11927: Enable frame pointers for snappy and lz4

2023-02-21 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19521 ) Change subject: IMPALA-11927: Enable frame pointers for snappy and lz4 .. Patch Set 1: (1 comment) looks good to me http://gerrit.clou

[Impala-ASF-CR] IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs

2023-02-21 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19507 ) Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs .. Patch Set 4: (11 comments) http://

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt is flakiness

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 ) Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness .. Patch Set 5: Build Successful https://jenkins.

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt is flakiness

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 ) Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness .. Patch Set 4: Build Successful https://jenkins.

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt is flakiness

2023-02-21 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/19524 ) Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness .. IMPALA-10111: Fix TestWebPage::test_query_stmt is flak

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt is flakiness

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 ) Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness .. Patch Set 4: (2 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt is flakiness

2023-02-21 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 ) Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness .. Patch Set 3: (2 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt is flakiness

2023-02-21 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19524 ) Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness .. IMPALA-10111: Fix TestWebPage::test_query_stmt is flak

[Impala-ASF-CR] IMPALA-11802: Optimize count(*) queries for Iceberg V2 position delete tables

2023-02-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19494 ) Change subject: IMPALA-11802: Optimize count(*) queries for Iceberg V2 position delete tables .. IMPALA-11802: Optimize co

[Impala-ASF-CR] IMPALA-11802: Optimize count(*) queries for Iceberg V2 position delete tables

2023-02-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19494 ) Change subject: IMPALA-11802: Optimize count(*) queries for Iceberg V2 position delete tables .. Patch Set 6: Code-Review+2 Aweso

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt is flakiness

2023-02-21 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 ) Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness .. Patch Set 3: (1 comment) Thanks for this patch, LGTM! It

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt is flakiness

2023-02-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 ) Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness .. Patch Set 3: Code-Review+1 (1 comment) Thanks for fix

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 ) Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types .. Patch Set 4: Build started: https://

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 ) Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types .. Patch Set 4: Code-Review+2 -- To vi

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt is flakiness

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 ) Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness .. Patch Set 3: Build Successful https://jenkins.

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt is flakiness

2023-02-21 Thread Code Review
Gergely Fürnstáhl has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19524 Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness .. IMPALA-10111: Fix TestWebPage::test_query_stmt is fla

[Impala-ASF-CR] IMPALA-11908: Parser change for Iceberg metadata querying

2023-02-21 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19483 ) Change subject: IMPALA-11908: Parser change for Iceberg metadata querying .. Patch Set 5: (1 comment) Thanks Tamás! http://gerrit.cl

[Impala-ASF-CR] IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19507 ) Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs .. Patch Set 4: Build Successf

[Impala-ASF-CR] IMPALA-3120: Support Bucket Shuffle Join for bucketed table

2023-02-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19430 ) Change subject: IMPALA-3120: Support Bucket Shuffle Join for bucketed table .. Patch Set 13: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19507 ) Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs .. Patch Set 4: (1 comment) h

[Impala-ASF-CR] IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs

2023-02-21 Thread Peter Rozsa (Code Review)
Peter Rozsa has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19507 ) Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs .. IMPALA-11854: ImpalaStringWritable's und

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

2023-02-21 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing. .. Patch Set 2: (2 comments) Thanks for fi

[Impala-ASF-CR] IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19507 ) Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs .. Patch Set 3: Build Failed

[Impala-ASF-CR] IMPALA-3120: Support Bucket Shuffle Join for bucketed table

2023-02-21 Thread Baike Xia (Code Review)
Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/19430 ) Change subject: IMPALA-3120: Support Bucket Shuffle Join for bucketed table .. Patch Set 13: (6 comments) Hi Csaba And Aman, I was busy w

[Impala-ASF-CR] IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs

2023-02-21 Thread Peter Rozsa (Code Review)
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19507 Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs .. IMPALA-11854: ImpalaStringWritable's un

[Impala-ASF-CR] IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs

2023-02-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19507 ) Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs .. Patch Set 3: (1 comment) h