[Impala-ASF-CR] IMPALA-10860: Allow setting mem limit for coordinators

2023-08-18 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20378 ) Change subject: IMPALA-10860: Allow setting mem_limit for coordinators .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-18 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 ) Change subject: IMPALA-12385: Enable Periodic metrics by default .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-10860: Allow setting mem limit for coordinators

2023-08-18 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20378 ) Change subject: IMPALA-10860: Allow setting mem_limit for coordinators .. IMPALA-10860: Allow setting mem_limit for coordinators Added

[Impala-ASF-CR] [tools] Simplify local toolchain development

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20267 ) Change subject: [tools] Simplify local toolchain development .. Patch Set 4: Build Successful

[Impala-ASF-CR] Specify the native toolchain revision exactly

2023-08-18 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19885 ) Change subject: Specify the native toolchain revision exactly .. Patch Set 2: https://gerrit.cloudera.org/c/20267/ now incorporates

[Impala-ASF-CR] [tools] Simplify local toolchain development

2023-08-18 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20267 ) Change subject: [tools] Simplify local toolchain development .. Patch Set 4: (1 comment)

[Impala-ASF-CR] [tools] Simplify local toolchain development

2023-08-18 Thread Michael Smith (Code Review)
Hello Laszlo Gaal, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20267 to look at the new patch set (#4). Change subject: [tools] Simplify local toolchain development

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 ) Change subject: [tools] Add Dev Container support for Impala development. .. Patch Set 1: Build Failed

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

2023-08-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20380 Change subject: [tools] Add Dev Container support for Impala development. .. [tools] Add Dev Container support for Impala development.

[Impala-ASF-CR] IMPALA-11957: Implement Regression functions: regr slope(), regr intercept() and regr r2()

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19569 ) Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), regr_intercept() and regr_r2() .. Patch Set 19:

[Impala-ASF-CR] IMPALA-10860: Allow setting mem limit for coordinators

2023-08-18 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/20378 ) Change subject: IMPALA-10860: Allow setting mem_limit for coordinators .. Patch Set 1: (1 comment) Make lint happy.

[Impala-ASF-CR] IMPALA-11957: Implement Regression functions: regr slope(), regr intercept() and regr r2()

2023-08-18 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/19569 ) Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), regr_intercept() and regr_r2() .. Patch Set

[Impala-ASF-CR] IMPALA-11957: Implement Regression functions: regr slope(), regr intercept() and regr r2()

2023-08-18 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has uploaded a new patch set (#19). ( http://gerrit.cloudera.org:8080/19569 ) Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), regr_intercept() and regr_r2() ..

[Impala-ASF-CR] IMPALA-11957: Implement Regression functions: regr slope(), regr intercept() and regr r2()

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19569 ) Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), regr_intercept() and regr_r2() .. Patch Set 19:

[Impala-ASF-CR] IMPALA-12253: Improve the integration of codegen cache and async codegen

2023-08-18 Thread Michael Smith (Code Review)
Michael Smith has removed a vote on this change. Change subject: IMPALA-12253: Improve the integration of codegen cache and async codegen .. Removed Code-Review+1 by Michael Smith -- To view, visit

[Impala-ASF-CR] IMPALA-12253: Improve the integration of codegen cache and async codegen

2023-08-18 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20211 ) Change subject: IMPALA-12253: Improve the integration of codegen cache and async codegen .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-08-18 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20379 Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. IMPALA-12383: Fix SingleNodePlanner aggregation limits When

[Impala-ASF-CR] IMPALA-10860: Allow setting mem limit for coordinators

2023-08-18 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20378 Change subject: IMPALA-10860: Allow setting mem_limit for coordinators .. IMPALA-10860: Allow setting mem_limit for coordinators

[Impala-ASF-CR] IMPALA-10860: Allow setting mem limit for coordinators

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20378 ) Change subject: IMPALA-10860: Allow setting mem_limit for coordinators .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-12384: Restore NullLiteral's uncheckedCastTo function signature

2023-08-18 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20376 ) Change subject: IMPALA-12384: Restore NullLiteral's uncheckedCastTo function signature .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-12228: Simulate the failure of an iceberg transaction.

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20306 ) Change subject: IMPALA-12228: Simulate the failure of an iceberg transaction. .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12228: Simulate the failure of an iceberg transaction.

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20306 ) Change subject: IMPALA-12228: Simulate the failure of an iceberg transaction. .. IMPALA-12228: Simulate the failure of

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-18 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 ) Change subject: IMPALA-12385: Enable Periodic metrics by default .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 ) Change subject: IMPALA-12385: Enable Periodic metrics by default .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-18 Thread Kurt Deschler (Code Review)
Hello Riza Suminto, David Rorke, Surya Hebbar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20377 to look at the new patch set (#2). Change subject: IMPALA-12385: Enable Periodic metrics by default

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 ) Change subject: IMPALA-12385: Enable Periodic metrics by default .. Patch Set 1: Build Successful

[Impala-ASF-CR] CDPD-50675: Include crypto functions supported by Hive

2023-08-18 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has abandoned this change. ( http://gerrit.cloudera.org:8080/20364 ) Change subject: CDPD-50675: Include crypto functions supported by Hive .. Abandoned -- To view, visit

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-18 Thread Kurt Deschler (Code Review)
Kurt Deschler has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20377 Change subject: IMPALA-12385: Enable Periodic metrics by default .. IMPALA-12385: Enable Periodic metrics by default This patch

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 ) Change subject: IMPALA-12385: Enable Periodic metrics by default .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-12384: Restore NullLiteral's uncheckedCastTo function signature

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20376 ) Change subject: IMPALA-12384: Restore NullLiteral's uncheckedCastTo function signature .. Patch Set 1: Build Successful

[Impala-ASF-CR] WIP: IMPALA-12159: Support ORDER BY for collections of variable length types in select list

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20108 ) Change subject: WIP: IMPALA-12159: Support ORDER BY for collections of variable length types in select list .. Patch Set 3:

[Impala-ASF-CR] WIP: IMPALA-12159: Support ORDER BY for collections of variable length types in select list

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20108 ) Change subject: WIP: IMPALA-12159: Support ORDER BY for collections of variable length types in select list .. Patch Set 2:

[Impala-ASF-CR] IMPALA-12384: Restore NullLiteral's uncheckedCastTo function signature

2023-08-18 Thread Peter Rozsa (Code Review)
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20376 Change subject: IMPALA-12384: Restore NullLiteral's uncheckedCastTo function signature .. IMPALA-12384: Restore NullLiteral's

[Impala-ASF-CR] WIP: IMPALA-12159: Support ORDER BY for collections of variable length types in select list

2023-08-18 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20108 ) Change subject: WIP: IMPALA-12159: Support ORDER BY for collections of variable length types in select list .. WIP: IMPALA-12159:

[Impala-ASF-CR] WIP: IMPALA-12159: Support ORDER BY for collections of variable length types in select list

2023-08-18 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20108 ) Change subject: WIP: IMPALA-12159: Support ORDER BY for collections of variable length types in select list .. WIP: IMPALA-12159:

[Impala-ASF-CR] IMPALA-12228: Simulate the failure of an iceberg transaction.

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20306 ) Change subject: IMPALA-12228: Simulate the failure of an iceberg transaction. .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-12228: Simulate the failure of an iceberg transaction.

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20306 ) Change subject: IMPALA-12228: Simulate the failure of an iceberg transaction. .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12228: Simulate the failure of an iceberg transaction.

2023-08-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20306 ) Change subject: IMPALA-12228: Simulate the failure of an iceberg transaction. .. Patch Set 1: Code-Review+2 (1 comment) LGTM!

[Impala-ASF-CR] IMPALA-12342: Erasure coding build fails on loading iceberg lineitem multiblock

2023-08-18 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20359 ) Change subject: IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock .. Patch Set 1: Code-Review+1

[Impala-ASF-CR] IMPALA-11898: Add query options in the profile even if the query failed in planning

2023-08-18 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 ) Change subject: IMPALA-11898: Add query options in the profile even if the query failed in planning .. Patch Set 6: In the failed

[Impala-ASF-CR] IMPALA-11898: Add query options in the profile even if the query failed in planning

2023-08-18 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 ) Change subject: IMPALA-11898: Add query options in the profile even if the query failed in planning .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-10798: Prototype a simple JSON File reader

2023-08-18 Thread Zihao Ye (Code Review)
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/19699 ) Change subject: IMPALA-10798: Prototype a simple JSON File reader .. Patch Set 22: (1 comment) Thank you once again for the code review.

[Impala-ASF-CR] IMPALA-10798: Prototype a simple JSON File reader

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19699 ) Change subject: IMPALA-10798: Prototype a simple JSON File reader .. Patch Set 26: Build Failed

[Impala-ASF-CR] IMPALA-12228: Simulate the failure of an iceberg transaction.

2023-08-18 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20306 ) Change subject: IMPALA-12228: Simulate the failure of an iceberg transaction. .. Patch Set 1: Code-Review+1 Thanks Andrew! LGTM! I will

[Impala-ASF-CR] IMPALA-10798: Prototype a simple JSON File reader

2023-08-18 Thread Zihao Ye (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19699 to look at the new patch set (#26). Change subject: IMPALA-10798: Prototype a simple JSON File reader

[Impala-ASF-CR] IMPALA-10798: Prototype a simple JSON File reader

2023-08-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19699 ) Change subject: IMPALA-10798: Prototype a simple JSON File reader .. Patch Set 24: Build Failed

[Impala-ASF-CR] IMPALA-10798: Prototype a simple JSON File reader

2023-08-18 Thread Zihao Ye (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19699 to look at the new patch set (#24). Change subject: IMPALA-10798: Prototype a simple JSON File reader

[Impala-ASF-CR] IMPALA-11957: Implement Regression functions: regr slope(), regr intercept() and regr r2()

2023-08-18 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19569 ) Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), regr_intercept() and regr_r2() .. Patch Set 18: (5