[Impala-ASF-CR] IMPALA-12771: Impala catalogd events-skipped may mark the wrong number

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21045 ) Change subject: IMPALA-12771: Impala catalogd events-skipped may mark the wrong number .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-12771: Impala catalogd events-skipped may mark the wrong number

2024-03-11 Thread Anonymous Coward (Code Review)
cclive1...@gmail.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21045 ) Change subject: IMPALA-12771: Impala catalogd events-skipped may mark the wrong number .. IMPALA-12771: Impala catalogd

[Impala-ASF-CR] IMPALA-12771: Impala catalogd events-skipped may mark the wrong number

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21045 ) Change subject: IMPALA-12771: Impala catalogd events-skipped may mark the wrong number .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12543: Detect self-events before finishing DDL

2024-03-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21029 ) Change subject: IMPALA-12543: Detect self-events before finishing DDL .. Patch Set 15: ps15 is just a rebase to pick up IMPALA-12678

[Impala-ASF-CR] IMPALA-12831: Fix HdfsTable.toMinimalTCatalogObject() failed by concurrent modification

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21072 ) Change subject: IMPALA-12831: Fix HdfsTable.toMinimalTCatalogObject() failed by concurrent modification .. Patch Set 4:

[Impala-ASF-CR] IMPALA-12540: Add system.impala query live table

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 ) Change subject: IMPALA-12540: Add system.impala_query_live table .. Patch Set 30: Build Successful

[Impala-ASF-CR] IMPALA-12540: Add system.impala query live table

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 ) Change subject: IMPALA-12540: Add system.impala_query_live table .. Patch Set 29: Build Successful

[Impala-ASF-CR] IMPALA-12626: Capture tables in query for log

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20886 ) Change subject: IMPALA-12626: Capture tables in query for log .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-12540: Add system.impala query live table

2024-03-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 ) Change subject: IMPALA-12540: Add system.impala_query_live table .. Patch Set 30: (8 comments)

[Impala-ASF-CR] IMPALA-12540: Add system.impala query live table

2024-03-11 Thread Michael Smith (Code Review)
Hello Andrew Sherman, Jason Fehr, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20762 to look at the new patch set (#30). Change subject: IMPALA-12540: Add system.impala_query_live table

[Impala-ASF-CR] IMPALA-12540: Add system.impala query live table

2024-03-11 Thread Michael Smith (Code Review)
Hello Andrew Sherman, Jason Fehr, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20762 to look at the new patch set (#29). Change subject: IMPALA-12540: Add system.impala_query_live table

[Impala-ASF-CR] IMPALA-12626: Capture tables in query for log

2024-03-11 Thread Michael Smith (Code Review)
Hello Andrew Sherman, Jason Fehr, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20886 to look at the new patch set (#12). Change subject: IMPALA-12626: Capture tables in query for log

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 41: (1 comment)

[Impala-ASF-CR] IMPALA-12487: Skip reloading file metadata for ALTER TABLE events with trivial changes in StorageDescriptor

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21019 ) Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE events with trivial changes in StorageDescriptor ..

[Impala-ASF-CR] IMPALA-12831: Fix HdfsTable.toMinimalTCatalogObject() failed by concurrent modification

2024-03-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21072 ) Change subject: IMPALA-12831: Fix HdfsTable.toMinimalTCatalogObject() failed by concurrent modification .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12831: Fix HdfsTable.toMinimalTCatalogObject() failed by concurrent modification

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21072 ) Change subject: IMPALA-12831: Fix HdfsTable.toMinimalTCatalogObject() failed by concurrent modification .. Patch Set 4:

[Impala-ASF-CR] IMPALA-12831: Fix HdfsTable.toMinimalTCatalogObject() failed by concurrent modification

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21072 ) Change subject: IMPALA-12831: Fix HdfsTable.toMinimalTCatalogObject() failed by concurrent modification .. Patch Set 4:

[Impala-ASF-CR] IMPALA-12487: Skip reloading file metadata for ALTER TABLE events with trivial changes in StorageDescriptor

2024-03-11 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21019 ) Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE events with trivial changes in StorageDescriptor ..

[Impala-ASF-CR] IMPALA-12487: Skip reloading file metadata for ALTER TABLE events with trivial changes in StorageDescriptor

2024-03-11 Thread Sai Hemanth Gantasala (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21019 to look at the new patch set (#4). Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE events with trivial changes in

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 41: (1 comment)

[native-toolchain-CR] IMPALA-12885: Log configuration values when starting a toolchain build

2024-03-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21135 ) Change subject: IMPALA-12885: Log configuration values when starting a toolchain build .. Patch Set 2: Code-Review+2 -- To view,

[native-toolchain-CR] IMPALA-12885: Log configuration values when starting a toolchain build

2024-03-11 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21135 ) Change subject: IMPALA-12885: Log configuration values when starting a toolchain build .. Patch Set 2: (1 comment)

[native-toolchain-CR] IMPALA-12885: Log configuration values when starting a toolchain build

2024-03-11 Thread Laszlo Gaal (Code Review)
Hello Michael Smith, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21135 to look at the new patch set (#2). Change subject: IMPALA-12885: Log configuration values when starting a toolchain build

[native-toolchain-CR] IMPALA-12885: Log configuration values when starting a toolchain build

2024-03-11 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21135 ) Change subject: IMPALA-12885: Log configuration values when starting a toolchain build .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 41: (1 comment)

[Impala-ASF-CR] IMPALA-12872: Use Calcite for ...

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21109 ) Change subject: IMPALA-12872: Use Calcite for ... .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 41: (24 comments)

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 41: Code-Review+1 (7 comments)

[native-toolchain-CR] IMPALA-12886: Bump GoogleTest version to 1.14.0

2024-03-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21133 ) Change subject: IMPALA-12886: Bump GoogleTest version to 1.14.0 .. Patch Set 1: Code-Review+1 Does this require much work in Impala?

[native-toolchain-CR] IMPALA-12885: Log configuration values when starting a toolchain build

2024-03-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21135 ) Change subject: IMPALA-12885: Log configuration values when starting a toolchain build .. Patch Set 1: Code-Review+1 (1 comment)

[native-toolchain-CR] IMPALA-12697: Set FAIL ON PUBLISH to true by default

2024-03-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21134 ) Change subject: IMPALA-12697: Set FAIL_ON_PUBLISH to true by default .. Patch Set 1: Code-Review+1 -- To view, visit

[native-toolchain-CR] IMPALA-12885: Log configuration values when starting a toolchain build

2024-03-11 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21135 Change subject: IMPALA-12885: Log configuration values when starting a toolchain build .. IMPALA-12885: Log configuration values when

[native-toolchain-CR] IMPALA-12697: Set FAIL ON PUBLISH to true by default

2024-03-11 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21134 Change subject: IMPALA-12697: Set FAIL_ON_PUBLISH to true by default .. IMPALA-12697: Set FAIL_ON_PUBLISH to true by default Ensure that

[Impala-ASF-CR] IMPALA-12872: Use Calcite for ...

2024-03-11 Thread Steve Carlin (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21109 to look at the new patch set (#5). Change subject: IMPALA-12872: Use Calcite for ... .. IMPALA-12872: Use

[native-toolchain-CR] IMPALA-12886: Bump GoogleTest version to 1.14.0

2024-03-11 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21133 Change subject: IMPALA-12886: Bump GoogleTest version to 1.14.0 .. IMPALA-12886: Bump GoogleTest version to 1.14.0 This is to unblock

[Impala-ASF-CR] IMPALA-12883: Support updating the charge on an entry in the cache

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21122 ) Change subject: IMPALA-12883: Support updating the charge on an entry in the cache .. Patch Set 3: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-03-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-12872: Use Calcite for ...

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21109 ) Change subject: IMPALA-12872: Use Calcite for ... .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-12872: Use Calcite for ...

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21109 ) Change subject: IMPALA-12872: Use Calcite for ... .. Patch Set 4: (54 comments)

[Impala-ASF-CR] IMPALA-12872: Use Calcite for ...

2024-03-11 Thread Steve Carlin (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21109 to look at the new patch set (#4). Change subject: IMPALA-12872: Use Calcite for ... .. IMPALA-12872: Use

[Impala-ASF-CR] IMPALA-12883: Support updating the charge on an entry in the cache

2024-03-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21122 ) Change subject: IMPALA-12883: Support updating the charge on an entry in the cache .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-12883: Support updating the charge on an entry in the cache

2024-03-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21122 ) Change subject: IMPALA-12883: Support updating the charge on an entry in the cache .. Patch Set 3: Test failure is not related --

[Impala-ASF-CR] IMPALA-12883: Support updating the charge on an entry in the cache

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21122 ) Change subject: IMPALA-12883: Support updating the charge on an entry in the cache .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-12831: Fix HdfsTable.toMinimalTCatalogObject() failed by concurrent modification

2024-03-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21072 ) Change subject: IMPALA-12831: Fix HdfsTable.toMinimalTCatalogObject() failed by concurrent modification .. Patch Set 3:

[Impala-ASF-CR] IMPALA-12693: [DOCS] Typo in link for ltrim in string functions docs

2024-03-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21123 ) Change subject: IMPALA-12693: [DOCS] Typo in link for ltrim in string functions docs .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-12487: Skip reloading file metadata for ALTER TABLE events with trivial changes in StorageDescriptor

2024-03-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21019 ) Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE events with trivial changes in StorageDescriptor .. Patch

[Impala-ASF-CR] IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-11 Thread Daniel Becker (Code Review)
Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21083 ) Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21083 ) Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-11 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21083 ) Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. Patch Set 4: (1 comment) Thank you for the review! I

[Impala-ASF-CR] IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21083 ) Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. Patch Set 4: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-11 Thread Noemi Pap-Takacs (Code Review)
Hello Andrew Sherman, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21083 to look at the new patch set (#4). Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21083 ) Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. Patch Set 4: Build Started