[Impala-ASF-CR] Revert "IMPALA-8146: Remove make {debug,release,asan}.sh"

2019-02-01 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12335 ) Change subject: Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh" .. Revert "IMPALA-8146: Remove

[Impala-ASF-CR] Revert "IMPALA-8146: Remove make {debug,release,asan}.sh"

2019-02-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12335 ) Change subject: Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh" .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] Revert "IMPALA-8146: Remove make {debug,release,asan}.sh"

2019-02-01 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12335 Change subject: Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh" .. Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh"

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 4: (9 comments) Looking good. Some more minor

[Impala-ASF-CR] IMPALA-8111: [DOCS] Take 2: Removed the Fix Version for KUDU-2198

2019-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12311 ) Change subject: IMPALA-8111: [DOCS] Take 2: Removed the Fix Version for KUDU-2198 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 7: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 14: (2 comments) This patch seems to have pretty

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-8111: [DOCS] Added KRPC-related known issues

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12291 ) Change subject: IMPALA-8111: [DOCS] Added KRPC-related known issues .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8111: [DOCS] Added KRPC-related known issues

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12291 ) Change subject: IMPALA-8111: [DOCS] Added KRPC-related known issues .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 2: (11 comments)

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

2019-01-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12257 ) Change subject: IMPALA-8097: mt_dop for all queries via hidden flag .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-7565: Set TAcceptQueueServer connection setup pool to be multi-threaded by default

2019-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12249 ) Change subject: IMPALA-7565: Set TAcceptQueueServer connection_setup_pool to be multi-threaded by default .. Patch Set 1: Code-Review+1

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 11: (12 comments) Still wrapping my head around

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12226 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 6: I meant "the timeout can also be turned

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2018-12-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-19 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. IMPALA-7213: Use separate network

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-19 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12106 ) Change subject: Add "network_plane" as part of ConnectionId .. Add "network_plane" as part of ConnectionId The motivation for

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12106 ) Change subject: Add "network_plane" as part of ConnectionId .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12106 ) Change subject: Add "network_plane" as part of ConnectionId .. Patch Set 1: Verified by

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 2: Code-Review+2 Carry Thomas'

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-19 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12107 to look at the new patch set (#2). Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 7: (10 comments)

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 7: (1 comment)

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12106 ) Change subject: Add "network_plane" as part of ConnectionId .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Adar Dembo from this change. ( http://gerrit.cloudera.org:8080/12106 ) Change subject: Add "network_plane" as part of ConnectionId .. Removed reviewer Adar Dembo. -- To view, visit

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-18 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12106 to review the following change. Change subject: Add "network_plane" as part of ConnectionId .. Add

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-18 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12107 Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. IMPALA-7213: Use separate network plane

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2018-12-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 2: (8 comments) Some trivial comments for now.

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2018-12-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 7: (3 comments)

[Impala-ASF-CR] IMPALA-7980: Fix spinning threads because of buggy handling of num unqueued files .

2018-12-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning threads because of buggy handling of num_unqueued_files_. .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2018-12-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7212: Remove dead code data-stream-mgr.cc

2018-12-10 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12064 Change subject: IMPALA-7212: Remove dead code data-stream-mgr.cc .. IMPALA-7212: Remove dead code data-stream-mgr.cc Dead code which was

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2018-12-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-7943: Bump the default client timeout set on impala-shell

2018-12-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12051 ) Change subject: IMPALA-7943: Bump the default client timeout set on impala-shell .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams

2018-12-06 Thread Michael Ho (Code Review)
Michael Ho has restored this change. ( http://gerrit.cloudera.org:8080/9251 ) Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams .. Restored Relevant for IMPALA-7467 as we may still keep a lot of

[Impala-ASF-CR] IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams

2018-12-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9251 ) Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams .. Patch Set 1: We may consider reviving it as we look

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-12-03 Thread Michael Ho (Code Review)
Hello Lars Volker, Balazs Jeszenszky, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12000 to look at the new patch set (#6). Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-12-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 6: Code-Review+2 Carry Lars' +2. -- To

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-12-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-6955: fix test query concurrency and server startup sequence

2018-12-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12019 ) Change subject: IMPALA-6955: fix test_query_concurrency and server startup sequence .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-12-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-12-03 Thread Michael Ho (Code Review)
Hello Lars Volker, Balazs Jeszenszky, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12000 to look at the new patch set (#5). Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates

[Impala-ASF-CR] IMPALA-6656: BufferAllocator observability

2018-11-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11947 ) Change subject: IMPALA-6656: BufferAllocator observability .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-30 Thread Michael Ho (Code Review)
Hello Lars Volker, Balazs Jeszenszky, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12000 to look at the new patch set (#4). Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates

[Impala-ASF-CR] IMPALA-6656: BufferAllocator observability

2018-11-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11947 ) Change subject: IMPALA-6656: BufferAllocator observability .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-1048: show sinks in exec summary

2018-11-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11967 ) Change subject: IMPALA-1048: show sinks in exec summary .. Patch Set 8: Code-Review+1 I suppose it's safe to assume that no external

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-28 Thread Michael Ho (Code Review)
Hello Balazs Jeszenszky, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12000 to look at the new patch set (#2). Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates

[Impala-ASF-CR] IMPALA-1048: show sinks in exec summary

2018-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11967 ) Change subject: IMPALA-1048: show sinks in exec summary .. Patch Set 7: (7 comments)

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-27 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12000 Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. IMPALA-6741: Add timestamp of fragment instance's

[Impala-ASF-CR] IMPALA-7882: Remove StringValue padding validation

2018-11-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11989 ) Change subject: IMPALA-7882: Remove StringValue padding validation .. Patch Set 1: Code-Review+1 Make sense to me. I suppose it was only

[Impala-ASF-CR] IMPALA-7852: Fix some flakiness in test hash join timer.py

2018-11-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11964 ) Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7852: Fix some flakiness in test hash join timer.py

2018-11-20 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11964 to look at the new patch set (#3). Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py

[Impala-ASF-CR] IMPALA-7852: Fix some flakiness in test hash join timer.py

2018-11-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11964 ) Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7852: Fix some flakiness in test hash join timer.py

2018-11-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11964 ) Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7852: Fix some flakiness in test hash join timer.py

2018-11-20 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11964 to look at the new patch set (#2). Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py

[Impala-ASF-CR] IMPALA-7829: Mark a fragment instance as done only after Close() is called

2018-11-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11939 ) Change subject: IMPALA-7829: Mark a fragment instance as done only after Close() is called .. Patch Set 2: Code-Review+2 Carry +2 --

[Impala-ASF-CR] IMPALA-7829: Mark a fragment instance as done only after Close() is called

2018-11-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11939 ) Change subject: IMPALA-7829: Mark a fragment instance as done only after Close() is called .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7829: Mark a fragment instance as done only after Close() is called

2018-11-20 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11939 to look at the new patch set (#2). Change subject: IMPALA-7829: Mark a fragment instance as done only after Close() is called

[Impala-ASF-CR] IMPALA-7852: Fix some flakiness in test hash join timer.py

2018-11-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11964 ) Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7852: Fix some flakiness in test hash join timer.py

2018-11-20 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11964 Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py .. IMPALA-7852: Fix some flakiness in test_hash_join_timer.py

[Impala-ASF-CR] IMPALA-7829: Mark a fragment instance as done only after Close() is called

2018-11-15 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11939 Change subject: IMPALA-7829: Mark a fragment instance as done only after Close() is called .. IMPALA-7829: Mark a fragment instance as

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-11-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 ) Change subject: IMPALA-7738: Implement timeouts for HDFS open calls .. Patch Set 4: (9 comments)

[Impala-ASF-CR] IMPALA-7148: Make test profile fragment instances() more robust

2018-11-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11906 Change subject: IMPALA-7148: Make test_profile_fragment_instances() more robust .. IMPALA-7148: Make test_profile_fragment_instances()

[Impala-ASF-CR] IMPALA-7828: A temporary workaround for flaky UDF test (test mem leak())

2018-11-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11900 Change subject: IMPALA-7828: A temporary workaround for flaky UDF test (test_mem_leak()) .. IMPALA-7828: A temporary workaround for flaky

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-11-05 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. IMPALA-6323 Allow constant analytic window

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-11-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-11-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 14: Michal, can you please look into the failures

[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size

2018-11-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 ) Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size .. Patch Set 2: Code-Review+2 (2

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-11-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 13: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-11-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-11-05 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Tim Armstrong, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11615 to look at the new patch set (#9). Change subject: IMPALA-4063: Merge report of query fragment instances per

[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size

2018-11-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 ) Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-7775: fix some lifecycle issues in statestore/session tests

2018-11-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11864 ) Change subject: IMPALA-7775: fix some lifecycle issues in statestore/session tests .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7775: fix some lifecycle issues in statestore/session tests

2018-11-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11864 ) Change subject: IMPALA-7775: fix some lifecycle issues in statestore/session tests .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-11-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-11-01 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. IMPALA-6661 Make NaN values equal for grouping

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-11-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 23: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-11-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-11-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 7: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-11-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 21: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-11-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-11-01 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Todd Lipcon, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, Michal Ostrowski, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#21). Change subject: IMPALA-7213, IMPALA-7241: Port

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-11-01 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Tim Armstrong, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11615 to look at the new patch set (#7). Change subject: IMPALA-4063: Merge report of query fragment instances per

[Impala-ASF-CR] IMPALA-7727: Fix TStatusCode to TErrorCode mapping

2018-10-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 ) Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7727: Fix TStatusCode to TErrorCode mapping

2018-10-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 ) Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping .. Patch Set 4: OK. Will do a pass tonight. -- To view, visit

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 19: There seems to be other test failures in

<    1   2   3   4   5   6   7   8   9   10   >