[Impala-ASF-CR] Add missing authorization in KRPC

2018-08-27 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11331 to look at the new patch set (#2). Change subject: Add missing authorization in KRPC

[Impala-ASF-CR] Add missing authorization in KRPC

2018-08-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11331 ) Change subject: Add missing authorization in KRPC .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Add missing authorization in KRPC

2018-08-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11331 ) Change subject: Add missing authorization in KRPC .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Add missing authorization in KRPC

2018-08-25 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11331 Change subject: Add missing authorization in KRPC .. Add missing authorization in KRPC In 2.12.0, Impala adopted Kudu RPC library for

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-21 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Todd Lipcon, Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#11). Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

[Impala-ASF-CR] IMPALA-7422: Fix a race in QueryState::StartFInstances()

2018-08-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11270 ) Change subject: IMPALA-7422: Fix a race in QueryState::StartFInstances() .. Patch Set 4: GVO failed due to IMPALA-6776 / IMPALA-7061

[Impala-ASF-CR] IMPALA-7433: reduce logging on executors

2018-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 ) Change subject: IMPALA-7433: reduce logging on executors .. Patch Set 4: Lars, do you also want to take a look ? -- To view, visit

[Impala-ASF-CR] IMPALA-7422: Fix a race in QueryState::StartFInstances()

2018-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11270 ) Change subject: IMPALA-7422: Fix a race in QueryState::StartFInstances() .. Patch Set 3: Code-Review+1 Carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-7422: Fix a race in QueryState::StartFInstances()

2018-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11270 ) Change subject: IMPALA-7422: Fix a race in QueryState::StartFInstances() .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7422: Fix a race in QueryState::StartFInstances()

2018-08-20 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11270 to look at the new patch set (#3). Change subject: IMPALA-7422: Fix a race in QueryState::StartFInstances()

[Impala-ASF-CR] IMPALA-7433: reduce logging on executors

2018-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 ) Change subject: IMPALA-7433: reduce logging on executors .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7433: reduce logging on executors

2018-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 ) Change subject: IMPALA-7433: reduce logging on executors .. Patch Set 4: Code-Review+1 Thanks for the explanation. -- To view, visit

[Impala-ASF-CR] IMPALA-7422: Fix a race in QueryState::StartFInstances()

2018-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11270 ) Change subject: IMPALA-7422: Fix a race in QueryState::StartFInstances() .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7422: Fix a race in QueryState::StartFInstances()

2018-08-20 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11270 to look at the new patch set (#2). Change subject: IMPALA-7422: Fix a race in QueryState::StartFInstances()

[Impala-ASF-CR] IMPALA-7433: reduce logging on executors

2018-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 ) Change subject: IMPALA-7433: reduce logging on executors .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7422: Fix a race in QueryState::StartFInstances()

2018-08-20 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11270 Change subject: IMPALA-7422: Fix a race in QueryState::StartFInstances() .. IMPALA-7422: Fix a race in QueryState::StartFInstances() A

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-17 Thread Michael Ho (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11241 to look at the new patch set (#3). Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11241 ) Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 1: Just being paranoid here but I hope

[Impala-ASF-CR] IMPALA-7434: Heimdal Kerberos is not supported in Impala

2018-08-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11204 ) Change subject: IMPALA-7434: Heimdal Kerberos is not supported in Impala .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7434: Limitation in kinit with auth to local and Heimdal kerberos

2018-08-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11204 ) Change subject: IMPALA-7434: Limitation in kinit with auth_to_local and Heimdal kerberos .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7434: Limitation in kinit with auth to local and Heimdal kerberos

2018-08-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11204 ) Change subject: IMPALA-7434: Limitation in kinit with auth_to_local and Heimdal kerberos .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3825: Distribute Runtime Filtering Aggregation

2018-08-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11055 ) Change subject: IMPALA-3825: Distribute Runtime Filtering Aggregation .. Patch Set 4: (1 comment) May help to add a unit test to

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-08 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#10). Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 8: (16 comments)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-08 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#9). Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-08-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 8: (22 comments)

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-08-08 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#8). Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-08-08 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#7). Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-08-08 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#6). Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 16: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 14: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()

2018-08-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/7 ) Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions() .. Patch Set 1: Build failed due to IMPALA-7328 -- To view,

[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()

2018-08-03 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/7 Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions() .. IMPALA-7394: Don't print stack trace in ExpireSessions() When

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 12: (3 comments)

[Impala-ASF-CR] IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.

2018-08-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/3 ) Change subject: IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 10: (10 comments)

[Impala-ASF-CR] IMPALA-7376: DCHECK hit if a fragment instance fails to initialize the filter bank

2018-08-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11096 ) Change subject: IMPALA-7376: DCHECK hit if a fragment instance fails to initialize the filter bank .. Patch Set 2: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-08-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 4: (30 comments)

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-08-01 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#5). Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

[Impala-ASF-CR] IMPALA-7296: bytes limit for row batch queue

2018-07-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10977 ) Change subject: IMPALA-7296: bytes limit for row batch queue .. Patch Set 6: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 8: (9 comments)

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7360: sequence scanners sometimes skip blocks

2018-07-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11062 ) Change subject: IMPALA-7360: sequence scanners sometimes skip blocks .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 7: (9 comments) Looking good. Some more

[Impala-ASF-CR] IMPALA-7296: bytes limit for row batch queue

2018-07-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10977 ) Change subject: IMPALA-7296: bytes limit for row batch queue .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7296: bytes limit for row batch queue

2018-07-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10977 ) Change subject: IMPALA-7296: bytes limit for row batch queue .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-24 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#4). Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 3: Still working on some targeted BE tests for some

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-24 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#3). Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC ..

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 2: (36 comments)

[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services

2018-07-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services .. Patch Set 6: Code-Review+2 Fix clang-tidy

[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services

2018-07-23 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10835 to look at the new patch set (#6). Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services

[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services

2018-07-23 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10835 to look at the new patch set (#5). Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services

[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services

2018-07-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services .. Patch Set 5: Code-Review+1 Rebased. Carry

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 6: (13 comments)

[Impala-ASF-CR] IMPALA-7296: bytes limit for row batch queue

2018-07-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10977 ) Change subject: IMPALA-7296: bytes limit for row batch queue .. Patch Set 5: Hi Tim, will it be simpler in general to just use max_bytes

[Impala-ASF-CR] IMPALA-7298: Stop passing IP address as hostname in Kerberos principal

2018-07-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10980 ) Change subject: IMPALA-7298: Stop passing IP address as hostname in Kerberos principal .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7298: Stop passing IP address as hostname in Kerberos principal

2018-07-18 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10980 Change subject: IMPALA-7298: Stop passing IP address as hostname in Kerberos principal .. IMPALA-7298: Stop passing IP address as

[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services

2018-07-17 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10835 to look at the new patch set (#4). Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services

[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services

2018-07-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()

2018-07-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()

2018-07-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 1: Another idea is to inject fault at expression codegen

[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()

2018-07-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 1: Change LGTM. May be it helps to add some end-to-end

[Impala-ASF-CR] [DOCS] Added KRPC port to the list of Impala ports

2018-07-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10930 ) Change subject: [DOCS] Added KRPC port to the list of Impala ports .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 ) Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 12: Code-Review+2 I looked at the diff between v10

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-07-11 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10835 to look at the new patch set (#3). Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-07-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-07-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10810 ) Change subject: IMPALA-7095: clean up scan node profiles .. Patch Set 8: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration

2018-07-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 ) Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 9: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4669: [KSECURITY] Add security library to build

2018-07-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-4669: [KSECURITY] Add security library to build .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-10 Thread Michael Ho (Code Review)
Michael Ho has removed Henry Robinson from this change. ( http://gerrit.cloudera.org:8080/10758 ) Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Removed reviewer Henry Robinson. -- To view, visit

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 ) Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-07-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10765 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10760 ) Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4669: [KSECURITY] Add security library to build

2018-07-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-4669: [KSECURITY] Add security library to build .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 ) Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-7006: Add KRPC folders from kudu@334ecafd

2018-07-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10757 ) Change subject: IMPALA-7006: Add KRPC folders from kudu@334ecafd .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7006: Remove KRPC folders

2018-07-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10756 ) Change subject: IMPALA-7006: Remove KRPC folders .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10756

[Impala-ASF-CR] IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming

2018-07-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10863 ) Change subject: IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming

2018-07-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10863 ) Change subject: IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 4: (15 comments)

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-07-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10810 ) Change subject: IMPALA-7095: clean up scan node profiles .. Patch Set 7: (14 comments)

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5486: Port ReportExecStatus() RPC to use KRPC

2018-07-02 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10855 Change subject: IMPALA-5486: Port ReportExecStatus() RPC to use KRPC .. IMPALA-5486: Port ReportExecStatus() RPC to use KRPC This change

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-06-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 1: Thanks for taking a look.

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-06-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 1: (1 comment)

<    1   2   3   4   5   6   7   8   9   10   >