[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 6: Code-Review+2 Carry +2. -- To

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Burkert, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9060 to look at the new patch set (#6). Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Burkert, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9060 to look at the new patch set (#5). Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Burkert, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9060 to look at the new patch set (#4). Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Burkert, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9060 to look at the new patch set (#3). Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-01-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8997 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 2: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 4: (15 comments)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-19 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8439 to look at the new patch set (#5). Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala ..

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9058 ) Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled .. Patch Set 1: (1 comment) Are the corresponding test

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9006 ) Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. Patch Set 4: Code-Review+2 Rebase,

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-18 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8950 to look at the new patch set (#5). Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: (1 comment) > Is there a

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9060 Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. IMPALA-6418: Find a reliable way to detect

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-16 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8950 to look at the new patch set (#4). Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2018-01-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9006 ) Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. Patch Set 3: (1 comment)

[native-toolchain-CR] IMPALA-6377: Bump breakpad version to include fix for #752

2018-01-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9036 ) Change subject: IMPALA-6377: Bump breakpad version to include fix for #752 .. Patch Set 1: Code-Review+2 (3 comments) Just a few

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 ) Change subject: IMPALA-2642: Fix a potential deadlock in statestore .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6399: Increase timeout in test observability to reduce flakiness

2018-01-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9034 ) Change subject: IMPALA-6399: Increase timeout in test_observability to reduce flakiness .. Patch Set 1: Code-Review+2 Pending success

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2018-01-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9006 ) Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-11 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8439 to look at the new patch set (#3). Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala ..

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-11 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8439 to look at the new patch set (#2). Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala ..

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed a vote on this change. Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Removed Code-Review+2 by Sailesh Mukil -- To view, visit

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 3: > (1 comment) To avoid extra

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2018-01-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9006 ) Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2018-01-11 Thread Sailesh Mukil (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9006 to look at the new patch set (#3). Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-11 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8950 to look at the new patch set (#3). Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2018-01-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9006 Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. IMPALA-6268:

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-11 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8950 to look at the new patch set (#2). Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

[Impala-ASF-CR] IMPALA-6348: Redact only sensitive fields in runtime profiles

2018-01-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8934 ) Change subject: IMPALA-6348: Redact only sensitive fields in runtime profiles .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8950 Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. IMPALA-6346: Potential deadlock in KrpcDataStreamMgr In

[Impala-ASF-CR] IMPALA-6348: Redact only sensitive fields in runtime profiles

2018-01-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8934 ) Change subject: IMPALA-6348: Redact only sensitive fields in runtime profiles .. Patch Set 2: (3 comments)

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2018-01-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue

2018-01-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7388 ) Change subject: IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

2018-01-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 ) Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

2017-12-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 ) Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-07 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8472 to look at the new patch set (#9). Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

[Impala-ASF-CR] IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8471 ) Change subject: IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace .. IMPALA-4671: (part-1) Copy

[Impala-ASF-CR] IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8471 ) Change subject: IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace .. Patch Set 7: Verified+1 Code-Review+2 Since the

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 2: Code-Review+1 I'm fine with this patch.

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 7: Code-Review+2 (1

[Impala-ASF-CR] Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos"

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. ( http://gerrit.cloudera.org:8080/8763 ) Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" .. Abandoned Thanks Michael, sounds good. I've uploaded a patch

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8766 Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. IMPALA-6268:

[Impala-ASF-CR] Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos"

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8763 ) Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" .. Patch Set 2: > I would recommend against reverting

[Impala-ASF-CR] Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos"

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8763 ) Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" .. Revert "IMPALA-5053: [SECURITY] Make KRPC work with

[Impala-ASF-CR] Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos"

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8763 Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" .. Revert "IMPALA-5053: [SECURITY] Make KRPC work with

[Impala-ASF-CR] IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS be principal is set

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8761 ) Change subject: IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS_be_principal is set .. Patch Set 1:

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8760 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Patch Set 1: This is the cherry-pick required

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8760 to review the following change. Change subject: [security] Make the kerberos principal configurable for Kudu servers

[Impala-ASF-CR] IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS be principal is set

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8761 Change subject: IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS_be_principal is set .. IMPALA-6256:

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8472 to look at the new patch set (#6). Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 6: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8472 to look at the new patch set (#5). Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2017-12-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: Update: This is now blocked on:

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 4: The latest patchset

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 4: (26 comments)

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-02 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8472 to look at the new patch set (#4). Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 10: Code-Review+2 (1 comment) Carry +2.

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#10). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#9). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ..

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 8: Code-Review+2 (2 comments) Carry +2

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#8). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ..

[Impala-ASF-CR] Update incubator-impala -> impala URLs

2017-11-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8685 ) Change subject: Update incubator-impala -> impala URLs .. Patch Set 1: Code-Review+1 Checked some URLs and confirmed that they work.

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (12 comments)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2017-11-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2017-11-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (13 comments)

[Impala-ASF-CR] IMPALA-6201: Fix test basic filters on ASAN

2017-11-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8646 ) Change subject: IMPALA-6201: Fix test_basic_filters on ASAN .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 1: (1 comment)

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 1: This patch fixes IMPALA-6172. -- To view,

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Removed reviewer Todd Lipcon. -- To view, visit

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Alexey Serbin from this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Removed reviewer Alexey Serbin. -- To view,

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Sailesh Mukil (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8622 to review the following change. Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 ) Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow .. Patch Set 7: > Change has been successfully

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-18 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#5). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ..

[Impala-ASF-CR] IMPALA-6109: xfail TestHdfsUnknownErrors::test hdfs safe mode error 255

2017-11-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8590 ) Change subject: IMPALA-6109: xfail TestHdfsUnknownErrors::test_hdfs_safe_mode_error_255 .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 3: (15 comments)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-16 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#4). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ..

[Impala-ASF-CR] Impala is graduating; remove outdated references to incubation

2017-11-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8577 ) Change subject: Impala is graduating; remove outdated references to incubation .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](asf-site) Impala graduated; remove outdated references to incubation

2017-11-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8575 ) Change subject: Impala graduated; remove outdated references to incubation .. Patch Set 2: Code-Review+2 -- To view, visit

<    1   2   3   4   5