[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Aman Sinha (Code Review)
Aman Sinha has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. IMPALA-10619: Minor refactoring of analytic

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 4: Code-Review+2 Carry forward +2 -- To

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 4: Verified+1 > Patch Set 4: Verified-1 > >

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Aman Sinha (Code Review)
Aman Sinha has removed a vote on this change. Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/17237

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-07 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-07 Thread Aman Sinha (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17237 to look at the new patch set (#3). Change subject: IMPALA-10619: Minor refactoring of analytic function methods

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-07 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 2: (2 comments) Responses below. Also, in PS

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-07 Thread Aman Sinha (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17237 to look at the new patch set (#2). Change subject: IMPALA-10619: Minor refactoring of analytic function methods