[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. IMPALA-12313: (part 1) Refactor modify statements

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 3: Code-Review+2 LGTM now Noemi and Peter have given

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-26 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 3: Code-Review+1 I agree with your solution. Thank

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 3: (2 comments) Thank you for catching this! I

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Gabor Kaszab, Peter Rozsa, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20477 to look at the new patch set (#3). Change subject: IMPALA-12313: (part 1) Refactor modify statements

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-25 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 2: (2 comments) Nice refactoring, thank you! There

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-22 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 2: Code-Review+1 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 2: Code-Review+1 LGTM, can give +2, waiting to see if

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 1: (15 comments) Thanks everyone for the

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Gabor Kaszab, Peter Rozsa, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20477 to look at the new patch set (#2). Change subject: IMPALA-12313: (part 1) Refactor modify statements

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-18 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 1: (9 comments)

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 1: (3 comments) I read through and this looks like

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20477 Change subject: IMPALA-12313: (part 1) Refactor modify statements .. IMPALA-12313: (part 1) Refactor modify statements This change