[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPALA-4835: Part 3: switch I/O buffers to buffer pool

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 25: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 25: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 25: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 24: Code-Review+2 (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#24). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool ..

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#23). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool ..

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 22: I've been seeing some flaky tests with this com

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 22: Code-Review+2 (2 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 22: (3 comments) FE code changes lgtm http://gerrit.c

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#22). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool ..

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 20: (38 comments) Thanks for all the comments. Did

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#21). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool ..

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/89

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 20: (6 comments) http://gerrit.cloudera.org:8080/#/c/8

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 20: (11 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/89

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 20: (20 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#20). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 20: I also discovered that a lot of the functional_

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 20: (10 comments) Rebased onto master to pick up B

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 17: BTW, I didn't update the tests in the last patc

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 19: (10 comments) Next set of comments. Remaining TODO

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 17: (5 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-20 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#19). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/89

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 17: (5 comments) http://gerrit.cloudera.org:8080/#/c/8

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-20 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#18). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/8

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 17: Rebased and fixed a couple of bugs with reserva

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-19 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#17). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPA

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 16: Rebased and fixed some minor merge conflicts.

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-06 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#16). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPA

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-06 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#13). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPA

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 12: (4 comments) some early comments: overall loo

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-31 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#12). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPA

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 11: Fixed the remaining core tests. -- To view, v

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-23 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#11). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPA

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 10: This is now ready for review. There might still

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#10). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPA