Re: [Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-05 Thread Manaswini Maharana
Thank you, everyone, for all the support and help. It was an amazing learning experience. Looking forward to making much more contributions in future. Regards! Mansi On Fri, Jan 5, 2018 at 3:09 PM, Tim Armstrong (Code Review) < ger...@cloudera.org> wrote: > Tim Armstrong *posted comments* on

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. Patch Set 6: Thank you for the contribution

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. IMPALA-6296: Avoid crash caused

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. Patch Set 5: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-04 Thread Manaswini Maharana (Code Review)
Manaswini Maharana has posted comments on this change. ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. Patch Set 5: Jenkin tests-

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. Patch Set 5: Code-Review+1 Thank Mansi. I'll

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-03 Thread Manaswini Maharana (Code Review)
Manaswini Maharana has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. IMPALA-6296: Avoid crash caused by DCHECK in