[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. IMPALA-8341: Data cache for remote reads This is a patch

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 12: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 12: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 10: Code-Review+2 (1 comment) Carry Todd's +2

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-02 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. IMPALA-8341: Data cache for remote reads This is a patch based on PhilZ's

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 9: Code-Review+2 (1 comment) just simple nit, otherwise +2

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 9: Code-Review+1 Carry Lars' +1 -- To view, visit

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-01 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. IMPALA-8341: Data cache for remote reads This is a patch based on PhilZ's

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 8: Build Failed

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 8: (5 comments) Accidentally pushed a draft. Will push PS9.

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-01 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. IMPALA-8341: Data cache for remote reads This is a patch based on PhilZ's

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 7: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 7: (41 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-30 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, David Rorke, Sahil Takiar, Todd Lipcon, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12987 to look at the new patch set (#7). Change subject: IMPALA-8341: Data

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 6: (24 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 5: (17 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-29 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, David Rorke, Sahil Takiar, Todd Lipcon, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12987 to look at the new patch set (#6). Change subject: IMPALA-8341: Data

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-27 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. IMPALA-8341: Data cache for remote reads This is a patch based on PhilZ's

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 5: (32 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 4: (3 comments) I don't know that I'll have time to do a fully

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 4: (31 comments) Mostly looks good to me. Please feel free to

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-18 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, David Rorke, Sahil Takiar, Todd Lipcon, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12987 to look at the new patch set (#4). Change subject: IMPALA-8341: Data

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-18 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, David Rorke, Sahil Takiar, Todd Lipcon, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12987 to look at the new patch set (#3). Change subject: IMPALA-8341: Data

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 3: (8 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 2: TODO: - add a test to rotate the files in data-cache-test.cc -

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-16 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, David Rorke, Sahil Takiar, Todd Lipcon, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12987 to look at the new patch set (#2). Change subject: IMPALA-8341: Data

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (71 comments) This new patch changes the configuration string

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: > (1 comment) > > > I think the _IO_ apportioned relative to

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (1 comment) > I think the _IO_ apportioned relative to

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-11 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: > (3 comments) > > > Another option would be to do a global

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (3 comments) > Another option would be to do a global

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: After sleeping on this patch, had a few more higher-level

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (37 comments) Didn't look through the tests yet, but here are

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (13 comments) I did a quick pass just trying to understand

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (23 comments) I think it would be good to have some tests

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12987 Change subject: IMPALA-8341: Data cache for remote reads .. IMPALA-8341: Data cache for remote reads This is a patch based on PhilZ's