[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. IMPALA-8572: Log query events before unregister. C

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 12: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 12: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 12: Code-Review+2 (1 comment) Carrying +2. I've

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-11 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#12). Change subject: IMPALA-8572: Log query events before unregister. ...

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 11: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 11: (1 comment) The changes look good, will wait to hea

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 11: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 11: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 11: (5 comments) Still not clear on the test fai

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#11). Change subject: IMPALA-8572: Log query events before unregister. ...

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 10: (5 comments) Left a few more comments while trying

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 10: Build failed: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 10: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 10: Verified-1 Build failed: https://jenkins.imp

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 10: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 10: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#10). Change subject: IMPALA-8572: Log query events before unregister. ...

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: Oh, yes, that's a whole lot less scary than incorrect

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: The issue is that the lineage test does querie

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: Yes, those mismatched results are definitely w

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: The other two test failures were actually stranger -

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: I didn't get a chance to debug it but my theor

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: The test failure is very strange - were you able to d

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: Verified-1 Build failed: https://jenkins.impa

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-07 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#9). Change subject: IMPALA-8572: Log query events before unregister.

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 8: (8 comments) Looks pretty good mainly had comments a

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 8: There was a test failure with mismatched linea

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 8: Verified-1 Build failed: https://jenkins.impa

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 8: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 8: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#8). Change subject: IMPALA-8572: Log query events before unregister.

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 7: Verified-1 Build failed: https://jenkins.impa

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 7: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 7: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 6: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#7). Change subject: IMPALA-8572: Log query events before unregister.

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 5: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#6). Change subject: IMPALA-8572: Log query events before unregister.

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#5). Change subject: IMPALA-8572: Log query events before unregister.

[Impala-ASF-CR] IMPALA-8572: Log query events before Unregister() call.

2019-09-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before Unregister() call. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-8572: Log query events before Unregister() call.

2019-09-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before Unregister() call. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8572: Log query events before Unregister() call.

2019-08-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before Unregister() call. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8572: Log query events before Unregister() call.

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before Unregister() call. .. Patch Set 4: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-8572: Log query events before Unregister() call.

2019-08-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before Unregister() call. .. Patch Set 4: I think this is in a decent shape that

[Impala-ASF-CR] IMPALA-8572: Log query events before Unregister() call.

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before Unregister() call. .. Patch Set 4: (5 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-8572: Log query events before Unregister() call.

2019-08-27 Thread Bharath Vissapragada (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#4). Change subject: IMPALA-8572: Log query events before Unregister() call.