[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. expr-test: use gtest parameterization Instead of running the

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-veri

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. Patch Set 2: -Verified Build Failed https://jenkins.impala.io/job/ge

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/g

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-veri

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-08 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13289 to look at the new patch set (#2). Change subject: expr-test: use gtest parameterization ..

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-c

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. Patch Set 1: This is pretty mechanical so I'm probably OK to +2 once the TODO

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. Patch Set 1: (1 comment) This seems like an improvement. I think the previou

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13289/1/be/src

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13289 ) Change subject: expr-test: use gtest parameterization .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13289/1

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-08 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13289 to review the following change. Change subject: expr-test: use gtest parameterization .. expr-test: use gtest param