[Impala-ASF-CR] IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails

2017-11-15 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8572 Change subject: IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails .. IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fai

[Impala-ASF-CR] [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations

2017-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8545 ) Change subject: [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations

2017-11-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8545 ) Change subject: [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations .. Patch Set 1: (1 comment) http://gerrit.clou

[Impala-ASF-CR] [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations

2017-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8545 ) Change subject: [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-11-15 Thread Alex Behm (Code Review)
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8569 Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function. .. IMPALA-5310: Part 2: Add SAMPLED_NDV() function. Adds a new SAMPLED_NDV(

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-11-15 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/6023/7/be/src/e

[Impala-ASF-CR] [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations

2017-11-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8545 ) Change subject: [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations .. Patch Set 1: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-11-15 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 7: (4 comments) Yes, I have been discussing these approaches with T

[Impala-ASF-CR] [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations

2017-11-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8545 ) Change subject: [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations .. Patch Set 1: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-5341: Avoid unintended filter out in fe test

2017-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8543 ) Change subject: IMPALA-5341: Avoid unintended filter out in fe test .. Patch Set 3: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-5341: Avoid unintended filter out in fe test

2017-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8543 ) Change subject: IMPALA-5341: Avoid unintended filter out in fe test .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5341: Avoid unintended filter out in fe test

2017-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8543 ) Change subject: IMPALA-5341: Avoid unintended filter out in fe test .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8398/

[Impala-ASF-CR] IMPALA-6188: make test top n reclaim less flaky

2017-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8562 ) Change subject: IMPALA-6188: make test_top_n_reclaim less flaky .. IMPALA-6188: make test_top_n_reclaim less flaky Test

[Impala-ASF-CR] IMPALA-6188: make test top n reclaim less flaky

2017-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8562 ) Change subject: IMPALA-6188: make test_top_n_reclaim less flaky .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8398/

[Impala-ASF-CR] Remove unused/defunct Maven repositories.

2017-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8497 ) Change subject: Remove unused/defunct Maven repositories. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-v

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > Patch Set 3: > > > Patch Set 2: > >

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-11-15 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 6: Jim, okay, let's hold this change. -- T

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-11-15 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/835

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > Patch Set 2: > > Based on my reading of

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-11-15 Thread Kim Jin Chul (Code Review)
Hello Jim Apple, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8355 to look at the new patch set (#14). Change subject: IMPALA-5754: Improve randomness of rand()/random()

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 14: Verified-1 Build failed: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-11-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 3: This is on top of the Decimal addition patch. I'm waiting

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8490

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-11-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 3: Taras, can this be rebased and merged before it gets stale? -- T

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 2: Sorry, the end of my sentence has dis

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 2: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: (3 comments) > Based on my reading o

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2017-11-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 4: (3 comments) h

[Impala-ASF-CR] IMPALA-6188: make test top n reclaim less flaky

2017-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8562 ) Change subject: IMPALA-6188: make test_top_n_reclaim less flaky .. Patch Set 1: Build started: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-6188: make test top n reclaim less flaky

2017-11-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8562 ) Change subject: IMPALA-6188: make test_top_n_reclaim less flaky .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-15 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8546 to look at the new patch set (#3). Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo ...

[Impala-ASF-CR] IMPALA-6188: make test top n reclaim less flaky

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8562 Change subject: IMPALA-6188: make test_top_n_reclaim less flaky .. IMPALA-6188: make test_top_n_reclaim less flaky Testing: Previously I

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-11-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 7: Is this still moving forward or should it be abandoned? -- To vi

[Impala-ASF-CR] IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos.

2017-11-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7241 ) Change subject: IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos. .. Patch Se

[Impala-ASF-CR] IMPALA-1474: Add a metric for running queries

2017-11-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7228 ) Change subject: IMPALA-1474: Add a metric for running queries .. Patch Set 1: Tim, does your recent change to add registered queries metric

[Impala-ASF-CR] IMPALA-5624: ProcessStateInfo::ReadProcFileDescriptorInfo() should not fork a process

2017-11-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: ProcessStateInfo::ReadProcFileDescriptorInfo() should not fork a process .. Patch Set 2: > I looked around, a

[Impala-ASF-CR] IMPALA-6080: clean up table descriptor handling

2017-11-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8330 ) Change subject: IMPALA-6080: clean up table descriptor handling .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations

2017-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8545 ) Change subject: [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations .. Patch Set 1: (39 comments) I think this is going in th

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] Remove unused/defunct Maven repositories.

2017-11-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8497 ) Change subject: Remove unused/defunct Maven repositories. .. Patch Set 1: > Patch Set 1: Verified-1 > > Build failed: https://jenkins

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-11-15 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 13: I am looking on the failure ] TestAllocFail.test_a

[Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 ) Change subject: IMPALA-6084: Avoid using of global namespace for llvm .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm

2017-11-15 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 ) Change subject: IMPALA-6084: Avoid using of global namespace for llvm .. Patch Set 5: (1 comment) I appreciate your reviews. http://ge