[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2017-12-18 Thread Kim Jin Chul (Code Review)
Hello Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#2). Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2017-12-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-18 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#8). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp

2017-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8829 ) Change subject: IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2017-12-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 7: (6 comments) Thanks for the comments!

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow CFB mode is stream cipher and is secure when use different nonce/IV for every message. However it would be a performance

2017-12-18 Thread Xianda Ke (Code Review)
Xianda Ke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8861 Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow CFB mode is stream cipher and is secure when use different nonce/IV for every message. However it would be a performance

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. IMPALA-3703: Store query context in

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 14: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 15: Thank everyone for the comments! --

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2017-12-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Taras Bobrovytsky, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8801 to look at the new patch set (#8). Change subject: IMPALA-5191: Standardize column alias behavior

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 14: Code-Review+2 This seems to be a known

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Gabor Kaszab, Philip Zeyliger, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8621 to look at the new patch set (#14). Change subject: IMPALA-3703: Store query context in thread-local

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 14: If I'm not mistaken the Jenkins verify

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 14: Build started:

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Removed reviewer Kudu Jenkins. -- To view,

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Dan Burkert from this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Removed reviewer Dan Burkert. -- To view, visit

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Patch Set 1: (1 comment) Mostly a clean cherry-pick

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Alexey Serbin from this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Removed reviewer Alexey Serbin. -- To view,

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8875 to review the following change. Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 1: (13 comments)

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8878 to review the following change. Change subject: KUDU-2228: Make Messenger options configurable ..

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Hello Lars Volker, Dan Burkert, Kudu Jenkins, Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8878 to look at the new patch set (#2). Change subject: KUDU-2228: Make Messenger options configurable

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 1: Some number of conflicts in the #include files. Conflicts

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Laszlo Gaal, Gabor Kaszab, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8490 to look at the new patch set (#16). Change subject: IMPALA-2248: Make

[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output

2017-12-18 Thread John Russell (Code Review)
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8865 Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. IMPALA-2181: [DOCS] Document changes to SET output Change-Id:

[Impala-ASF-CR] IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp

2017-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8829 ) Change subject: IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'

2017-12-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8854 ) Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf' .. IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-18 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 6: Hi PhilZ, are you ok

[Impala-ASF-CR] IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp

2017-12-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8829 ) Change subject: IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp .. Patch Set 5: Jim, thanks for your review! --

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 6: Code-Review+1

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 15: After an offline discussion with Greg and