[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12143 to look at the new patch set (#3). Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12143 ) Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes .. Patch Set 2: Rebased on latest master -- To view, visit

[Impala-ASF-CR] IMPALA-7640: RENAME on managed Kudu table should rename Kudu table

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12179 ) Change subject: IMPALA-7640: RENAME on managed Kudu table should rename Kudu table .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 8: Code-Review+2 Promoting it to +2

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. IMPALA-7832: Support for IF

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 9: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12143 ) Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12192 ) Change subject: IMPALA-8058: Fallback for HBase key scan range estimation .. Patch Set 2: (2 comments) Hi Bharath, Thanks much for the

[Impala-ASF-CR] IMPALA-7640: RENAME on managed Kudu table should rename Kudu table

2019-01-23 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Mike Percy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12179 to look at the new patch set (#2). Change subject: IMPALA-7640: RENAME on managed Kudu table should rename Kudu table

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12192 ) Change subject: IMPALA-8058: Fallback for HBase key scan range estimation .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 5: (4 comments) Thanks for the review Tim. Addressed

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12144 ) Change subject: IMPALA-8041, Part 2: Refactor SELECT list .. Patch Set 3: Build Successful

[Impala-ASF-CR] Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it.

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12259 ) Change subject: Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it. .. Patch Set 2: Verified+1

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 4: Code-Review+1 (4 comments) It's hard to argue

[Impala-ASF-CR] IMPALA-7941: part 2/2: use cgroups memory limit

2019-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12262 Change subject: IMPALA-7941: part 2/2: use cgroups memory limit .. IMPALA-7941: part 2/2: use cgroups memory limit This uses the

[Impala-ASF-CR] IMPALA-7640: RENAME on managed Kudu table should rename Kudu table

2019-01-23 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12179 ) Change subject: IMPALA-7640: RENAME on managed Kudu table should rename Kudu table .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 9: Code-Review+2 -- To

[Impala-ASF-CR] Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it.

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12259 ) Change subject: Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it. .. Using 'master'

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12248 to look at the new patch set (#5). Change subject: IMPALA-8095: Detailed expression cardinality tests

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7941: part 2/2: use cgroups memory limit

2019-01-23 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12262 to look at the new patch set (#2). Change subject: IMPALA-7941: part 2/2: use cgroups memory limit

[Impala-ASF-CR] IMPALA-7941: part 2/2: use cgroups memory limit

2019-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12262 ) Change subject: IMPALA-7941: part 2/2: use cgroups memory limit .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 13: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. IMPALA-7905: Hive keywords not quoted for

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 11: (12 comments) Still wrapping my head around

<    1   2