[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()

2018-02-18 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9352 to look at the new patch set (#2). Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled() .

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 18: Applied the update for the expected results -- To vi

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-18 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#18). Change subject: IMPALA-3193: Show table's comment on show tables

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 11: (10 comments) http://gerrit.cloudera.org:8080/#/c/9292

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-18 Thread Grant Henke (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9306 to look at the new patch set (#5). Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-02-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 1: (10 comments) Thanks for the comments. I've ap

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-02-18 Thread Kim Jin Chul (Code Review)
Hello Gabor Kaszab, Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8508 to look at the new patch set (#9). Change subject: IMPALA-5237: Support a quoted string in date/time format

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/9292/

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 7: Code-Review+1 (1 comment) Pleas

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 28: Code-Review+2 (5 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 7: (5 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-18 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#7). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool ...

[Impala-ASF-CR] IMPALA-6482: add QUERY TIME LIMIT S option

2018-02-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add QUERY_TIME_LIMIT_S option .. Patch Set 5: Yeah there is - a global command-line flag and per-pool sett