[Impala-ASF-CR] IMPALA-7039: Ignore the port in HBase planner tests

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10459 ) Change subject: IMPALA-7039: Ignore the port in HBase planner tests .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not requirerd in comments

2018-05-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10474 Change subject: IMPALA-2751: Matching quotes are not requirerd in comments .. IMPALA-2751: Matching quotes are not requirerd in comments

[Impala-ASF-CR] IMPALA-7039: Ignore the port in HBase planner tests

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10459 ) Change subject: IMPALA-7039: Ignore the port in HBase planner tests .. IMPALA-7039: Ignore the port in HBase planner

[Impala-ASF-CR] IMPALA-7051: Serialize Maven invocations.

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10460 ) Change subject: IMPALA-7051: Serialize Maven invocations. .. IMPALA-7051: Serialize Maven invocations. I've observed

[Impala-ASF-CR] IMPALA-7051: Serialize Maven invocations.

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10460 ) Change subject: IMPALA-7051: Serialize Maven invocations. .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-05-21 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 7: There is now a blue docker build:

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. IMPALA-7019: Schedule EC as remote &

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6953: clean up DiskIoMgr

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: clean up DiskIoMgr .. Patch Set 7: (9 comments)

[Impala-ASF-CR] IMPALA-7039: Ignore the port in HBase planner tests

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10459 ) Change subject: IMPALA-7039: Ignore the port in HBase planner tests .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-05-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-6953: clean up DiskIoMgr

2018-05-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: clean up DiskIoMgr .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 2: > Can we add a basic

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-21 Thread Sailesh Mukil (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9966 to look at the new patch set (#2). Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 16: This change did not cherrypick

[Impala-ASF-CR] [DOCS] Added the hotspot analysis to Performance Best Practices doc

2018-05-21 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10472 Change subject: [DOCS] Added the hotspot analysis to Performance Best Practices doc .. [DOCS] Added the hotspot analysis to Performance

[Impala-ASF-CR] IMPALA-7011: Simplify PlanRootSink control logic

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 ) Change subject: IMPALA-7011: Simplify PlanRootSink control logic .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7011: Simplify PlanRootSink control logic

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10449 ) Change subject: IMPALA-7011: Simplify PlanRootSink control logic .. IMPALA-7011: Simplify PlanRootSink control logic

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: We should find a reviewer for this, or maybe Taras can +2 if

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-05-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. IMPALA-7016: Implement ALTER DATABASE SET OWNER Alters the database

[Impala-ASF-CR] [DOCS] Fixed misleading documentation on Impala + HDFS caching

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10454 ) Change subject: [DOCS] Fixed misleading documentation on Impala + HDFS caching .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] [DOCS] Fixed misleading documentation on Impala + HDFS caching

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10454 ) Change subject: [DOCS] Fixed misleading documentation on Impala + HDFS caching .. [DOCS] Fixed misleading

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-05-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10471 Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. IMPALA-7016: Implement ALTER DATABASE SET OWNER Alters the database

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 1: Can we add a basic custom

[Impala-ASF-CR] [DOCS] Fixed misleading documentation on Impala + HDFS caching

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10454 ) Change subject: [DOCS] Fixed misleading documentation on Impala + HDFS caching .. Patch Set 1: Build started:

[Impala-ASF-CR] [DOCS] Fixed misleading documentation on Impala + HDFS caching

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10454 ) Change subject: [DOCS] Fixed misleading documentation on Impala + HDFS caching .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6953: clean up DiskIoMgr

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: clean up DiskIoMgr .. Patch Set 7: (1 comment) Rebase. Do you have time to take a look Joe? Otherwise I

[Impala-ASF-CR] IMPALA-6020: [DOCS] REFRESH statement cannot detect HDFS block movement

2018-05-21 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10470 Change subject: IMPALA-6020: [DOCS] REFRESH statement cannot detect HDFS block movement .. IMPALA-6020: [DOCS] REFRESH statement cannot

[Impala-ASF-CR] IMPALA-5392: Added all stack frames to ThreadInfo summary.

2018-05-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 ) Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. .. Patch Set 9: (3 comments)

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-05-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 6: > What's the next step here?

[Impala-ASF-CR] IMPALA-5392: Added all stack frames to ThreadInfo summary.

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 ) Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. .. Patch Set 9: It looks like this got stalled. Jim, do

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-05-21 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7051: Serialize Maven invocations.

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10460 ) Change subject: IMPALA-7051: Serialize Maven invocations. .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5164: Better benchmark heuristic

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/7389 ) Change subject: IMPALA-5164: Better benchmark heuristic .. Abandoned Looks abandoned, can reopen if needed later -- To view, visit

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/5821 ) Change subject: IMPALA-5266 Impala ABM / LZCNT support .. Abandoned Looks abandoned, can reopen if needed later -- To view, visit

[Impala-ASF-CR] IMPALA-7051: Serialize Maven invocations.

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10460 ) Change subject: IMPALA-7051: Serialize Maven invocations. .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7039: Ignore the port in HBase planner tests

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10459 ) Change subject: IMPALA-7039: Ignore the port in HBase planner tests .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 14: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 11: (29 comments) That looks good. My review comments are

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-05-21 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-05-21 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. IMPALA-5737: Tighten minicluster memory limit This patch limits

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-21 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 1: (31 comments)

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-21 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#3). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-21 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#2). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 1: > > Patch Set 1: > > >

[Impala-ASF-CR] IMPALA-6317: Add -cmake only option to buildall.sh

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10455 ) Change subject: IMPALA-6317: Add -cmake_only option to buildall.sh .. IMPALA-6317: Add -cmake_only option to

[Impala-ASF-CR] IMPALA-6317: Add -cmake only option to buildall.sh

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10455 ) Change subject: IMPALA-6317: Add -cmake_only option to buildall.sh .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-21 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. IMPALA-7019: Schedule EC as remote & disable failed tests

[Impala-ASF-CR] IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE

2018-05-21 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10452 ) Change subject: IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE .. Patch Set 1: Could you please review this doc updates? Thanks!

[Impala-ASF-CR] IMPALA-7011: Simplify PlanRootSink control logic

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 ) Change subject: IMPALA-7011: Simplify PlanRootSink control logic .. Patch Set 7: Build started:

[Impala-ASF-CR](2.x) IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10465 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. IMPALA-5384, part 2: Simplify

[Impala-ASF-CR](2.x) IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10465 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-05-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 12: Rebased and carry +1. Can anyone review this PR?

[Impala-ASF-CR] IMPALA-6317: Add -cmake only option to buildall.sh

2018-05-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10455 ) Change subject: IMPALA-6317: Add -cmake_only option to buildall.sh .. Patch Set 3: > Patch Set 3: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-6317: Add -cmake only option to buildall.sh

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10455 ) Change subject: IMPALA-6317: Add -cmake_only option to buildall.sh .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7011: Simplify PlanRootSink control logic

2018-05-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 ) Change subject: IMPALA-7011: Simplify PlanRootSink control logic .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 15: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. IMPALA-6131: Track time of last

[Impala-ASF-CR] IMPALA-7011: Simplify PlanRootSink control logic

2018-05-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 ) Change subject: IMPALA-7011: Simplify PlanRootSink control logic .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7011: Simplify PlanRootSink control logic

2018-05-21 Thread Dan Hecht (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10449 to look at the new patch set (#6). Change subject: IMPALA-7011: Simplify PlanRootSink control logic

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-21 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#14). Change subject: IMPALA-5706: Spilling sort optimisations

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-05-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10466 Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. IMPALA-6947: Kudu tests flaky due to rpc timeout Some Kudu tests

[Impala-ASF-CR] IMPALA-6035: Add query options to limit thread reservation

2018-05-21 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10365 ) Change subject: IMPALA-6035: Add query options to limit thread reservation .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7011: Simplify PlanRootSink control logic

2018-05-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 ) Change subject: IMPALA-7011: Simplify PlanRootSink control logic .. Patch Set 5: Michael, any more comments? -- To view, visit

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 2: (1 comment) Code looks good,

[Impala-ASF-CR](2.x) IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10465 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 1: Build started:

[Impala-ASF-CR](2.x) IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10465 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 1: Code-Review+2 (1 comment) Resolved

[Impala-ASF-CR](2.x) IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-21 Thread Dan Hecht (Code Review)
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10465 to review the following change. Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

[Impala-ASF-CR] IMPALA-7011: Simplify PlanRootSink control logic

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 ) Change subject: IMPALA-7011: Simplify PlanRootSink control logic .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6035: Add query options to limit thread reservation

2018-05-21 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10365 to look at the new patch set (#7). Change subject: IMPALA-6035: Add query options to limit thread reservation ..

[Impala-ASF-CR] IMPALA-6035: Add query options to limit thread reservation

2018-05-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10365 ) Change subject: IMPALA-6035: Add query options to limit thread reservation .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6994: Avoid reloading a table's HMS data for file-only operations.

2018-05-21 Thread Pranay Singh (Code Review)
Pranay Singh has abandoned this change. ( http://gerrit.cloudera.org:8080/10450 ) Change subject: IMPALA-6994: Avoid reloading a table's HMS data for file-only operations. .. Abandoned -- To view, visit

[Impala-ASF-CR] IMPALA-6994: Avoid reloading a table's HMS data for file-only operations.

2018-05-21 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/10450 ) Change subject: IMPALA-6994: Avoid reloading a table's HMS data for file-only operations. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 15: Code-Review+2 Carrying Alex's +2 -- To