Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 )
Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/10145/9/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/10145/9/fe/src/main/java/org/apache/impala/common/JniUtil.java@263 PS9, Line 263: " Id=" + threadInfo.getThreadId() + " " + nit: we use 4 spaces for continued indentation. http://gerrit.cloudera.org:8080/#/c/10145/9/fe/src/main/java/org/apache/impala/common/JniUtil.java@270 PS9, Line 270: "\" Id=" + threadInfo.getLockOwnerId()); nit: we use 4 spaces for continued indentation. http://gerrit.cloudera.org:8080/#/c/10145/9/fe/src/main/java/org/apache/impala/common/JniUtil.java@285 PS9, Line 285: if(miList == null){ nit: space after if and space before { -- To view, visit http://gerrit.cloudera.org:8080/10145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80ab4aad03e0c1f01fecad6b87779531244c28b7 Gerrit-Change-Number: 10145 Gerrit-PatchSet: 9 Gerrit-Owner: Abhishek Sharma <[email protected]> Gerrit-Reviewer: Abhishek Sharma <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Charles Agnello <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 21 May 2018 23:07:06 +0000 Gerrit-HasComments: Yes
