[Impala-ASF-CR] IMPALA-7829: Mark a fragment instance as done only after Close() is called

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11939 ) Change subject: IMPALA-7829: Mark a fragment instance as done only after Close() is called .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7829: Mark a fragment instance as done only after Close() is called

2018-11-15 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11939 Change subject: IMPALA-7829: Mark a fragment instance as done only after Close() is called .. IMPALA-7829: Mark a fragment instance as

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7585: support LDAP in run-workload.py

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11938 ) Change subject: IMPALA-7585: support LDAP in run-workload.py .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7585: support LDAP in run-workload.py

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11938 ) Change subject: IMPALA-7585: support LDAP in run-workload.py .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7857: log more information about statestore failure detection

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11937 ) Change subject: IMPALA-7857: log more information about statestore failure detection .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7585: support LDAP in run-workload.py

2018-11-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11938 ) Change subject: IMPALA-7585: support LDAP in run-workload.py .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7585: support LDAP in run-workload.py

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11938 ) Change subject: IMPALA-7585: support LDAP in run-workload.py .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 3: Is this ready to get merged? --

[Impala-ASF-CR] Revert "IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code"

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11699 ) Change subject: Revert "IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code" .. Patch Set 2: Any luck? -- To view, visit

[Impala-ASF-CR] IMPALA-5031: Zero-length arrays are undefined behavior

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11811 ) Change subject: IMPALA-5031: Zero-length arrays are undefined behavior .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11917 ) Change subject: IMPALA-5031: signed overflow is undefined behavior .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7585: support LDAP in run-workload.py

2018-11-15 Thread Jim Apple (Code Review)
Hello David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11938 to look at the new patch set (#2). Change subject: IMPALA-7585: support LDAP in run-workload.py

[Impala-ASF-CR] IMPALA-7811: optionally count JVM heap towards process mem limit

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/10928 ) Change subject: IMPALA-7811: optionally count JVM heap towards process mem limit .. IMPALA-7811: optionally count JVM heap towards

[Impala-ASF-CR] IMPALA-7857: log more information about statestore failure detection

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11937 ) Change subject: IMPALA-7857: log more information about statestore failure detection .. IMPALA-7857: log more information about

[Impala-ASF-CR] IMPALA-7585: support LDAP in run-workload.py

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11938 ) Change subject: IMPALA-7585: support LDAP in run-workload.py .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7585: support LDAP in run-workload.py

2018-11-15 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11938 Change subject: IMPALA-7585: support LDAP in run-workload.py .. IMPALA-7585: support LDAP in run-workload.py This patch just threads

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 5: Build Failed

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 4: Build Failed

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-11-15 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 2: (4 comments) Thanks for the reviews.

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-11-15 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11890 to look at the new patch set (#2). Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-15 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 4: (1 comment)

[Impala-ASF-CR] [DOCS] Added a note in impala scan bytes limit.xml

2018-11-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11936 ) Change subject: [DOCS] Added a note in impala_scan_bytes_limit.xml .. [DOCS] Added a note in impala_scan_bytes_limit.xml -

[Impala-ASF-CR] [DOCS] Added a note in impala scan bytes limit.xml

2018-11-15 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11936 ) Change subject: [DOCS] Added a note in impala_scan_bytes_limit.xml .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Added a note in impala scan bytes limit.xml

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11936 ) Change subject: [DOCS] Added a note in impala_scan_bytes_limit.xml .. Patch Set 1: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-7392: [DOCS] SCAN BYTES LIMIT query option documented

2018-11-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11240 ) Change subject: IMPALA-7392: [DOCS] SCAN_BYTES_LIMIT query option documented .. Patch Set 2: (1 comment)

[Impala-ASF-CR] [DOCS] Added a note in impala scan bytes limit.xml

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11936 ) Change subject: [DOCS] Added a note in impala_scan_bytes_limit.xml .. Patch Set 1: Build Started

[Impala-ASF-CR] [DOCS] Added a note in impala scan bytes limit.xml

2018-11-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11936 Change subject: [DOCS] Added a note in impala_scan_bytes_limit.xml .. [DOCS] Added a note in impala_scan_bytes_limit.xml - Added a note

[Impala-ASF-CR] IMPALA-7392: [DOCS] SCAN BYTES LIMIT query option documented

2018-11-15 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11240 ) Change subject: IMPALA-7392: [DOCS] SCAN_BYTES_LIMIT query option documented .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-11-15 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11881 to look at the new patch set (#5). Change subject: IMPALA-7807: Analysis test fixture

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-11-15 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11881 to look at the new patch set (#4). Change subject: IMPALA-7807: Analysis test fixture

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-11-15 Thread Thomas Marshall (Code Review)
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-11-15 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 9: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 9: Verified+1 -- To

[Impala-ASF-CR] IMPALA-7836: [DOCS] Format changes in impala topn bytes limit.xml

2018-11-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11935 ) Change subject: IMPALA-7836: [DOCS] Format changes in impala_topn_bytes_limit.xml .. IMPALA-7836: [DOCS] Format changes in

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 22: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7836: [DOCS] Format changes in impala topn bytes limit.xml

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11935 ) Change subject: IMPALA-7836: [DOCS] Format changes in impala_topn_bytes_limit.xml .. Patch Set 1: Verified+1 Build

[Impala-ASF-CR] IMPALA-7836: [DOCS] Format changes in impala topn bytes limit.xml

2018-11-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11935 ) Change subject: IMPALA-7836: [DOCS] Format changes in impala_topn_bytes_limit.xml .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7836: [DOCS] Format changes in impala topn bytes limit.xml

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11935 ) Change subject: IMPALA-7836: [DOCS] Format changes in impala_topn_bytes_limit.xml .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-7836: [DOCS] Format changes in impala topn bytes limit.xml

2018-11-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11935 Change subject: IMPALA-7836: [DOCS] Format changes in impala_topn_bytes_limit.xml .. IMPALA-7836: [DOCS] Format changes in

[Impala-ASF-CR] IMPALA-7392: [DOCS] SCAN BYTES LIMIT query option documented

2018-11-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11240 ) Change subject: IMPALA-7392: [DOCS] SCAN_BYTES_LIMIT query option documented .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 21: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 20: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 21: (1 comment) Rebased

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#21). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 19: (6 comments)

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Csaba Ringhofer, Alex Behm, Mostafa Mokhtar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8319 to look at the new patch set (#20). Change subject: IMPALA-4123: Columnar decoding in Parquet

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-15 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. IMPALA-7367: Pack StringValue and CollectionValue slots

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 19: (5 comments) I did a pass out of curiosity and only had a

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 19: Code-Review+1 (1 comment) I read it through again and

[Impala-ASF-CR] IMPALA-4123: Columnar decoding in Parquet

2018-11-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 ) Change subject: IMPALA-4123: Columnar decoding in Parquet .. Patch Set 19: Code-Review+1 (2 comments)