[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 5: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 6: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 6: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 5: Code-Review+2 Yeah maybe it doesn't matter too mu

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/16

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Aman Sinha (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16131 to look at the new patch set (#5). Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/161

[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16115 ) Change subject: IMPALA-9898: Plan generation and execution for grouping sets .. IMPALA-9898: Plan generation and execut

[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 ) Change subject: IMPALA-9898: Plan generation and execution for grouping sets .. Patch Set 5: Verified+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 16: Build Successful https://jen

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-07-01 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15963 to look at the new patch set (#16). Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. ..

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 3: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/161

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Aman Sinha (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16131 to look at the new patch set (#4). Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 3: (1 comment) > Patch Set 2: Code-Review+1 > > (1 com

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Aman Sinha (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16131 to look at the new patch set (#3). Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

[Impala-ASF-CR] IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16122 ) Change subject: IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState .. Patch Set 3: Verified+1 -- To view, visit http

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 ) Change subject: IMPALA-9898: Plan generation and execution for grouping sets .. Patch Set 5: Build started: https://jenkins.im

[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets

2020-07-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 ) Change subject: IMPALA-9898: Plan generation and execution for grouping sets .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 ) Change subject: IMPALA-9898: Plan generation and execution for grouping sets .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 2: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: I took a quick pass and this seems fine in concep

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 2: Verified-1 Build failed: https://jenkins.

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 8: I rebased this onto the latest version of Aman's patch. --

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-01 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Fang-Yu Rao, Qifan Chen, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#8). Change subject: IMPALA-9898: generate grouping set plans .

[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 ) Change subject: IMPALA-9898: Plan generation and execution for grouping sets .. Patch Set 4: Build Successful https://jenkins

[Impala-ASF-CR] WIP - IMPALA-9898: generate grouping set plans

2020-07-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: WIP - IMPALA-9898: generate grouping set plans .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/16128

[Impala-ASF-CR] WIP - IMPALA-9898: generate grouping set plans

2020-07-01 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Fang-Yu Rao, Qifan Chen, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#7). Change subject: WIP - IMPALA-9898: generate grouping set plans ...

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-01 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. IMPALA-7923: DecimalValue should be marked as packed IMPALA-7473

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-01 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16134 Change subject: IMPALA-7923: DecimalValue should be marked as packed .. IMPALA-7923: DecimalValue should be marked as packed IMPALA-747

[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets

2020-07-01 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 ) Change subject: IMPALA-9898: Plan generation and execution for grouping sets .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets

2020-07-01 Thread Aman Sinha (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16115 to look at the new patch set (#4). Change subject: IMPALA-9898: Plan generation and execution for grouping sets

[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets

2020-07-01 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 ) Change subject: IMPALA-9898: Plan generation and execution for grouping sets .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets

2020-07-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 ) Change subject: IMPALA-9898: Plan generation and execution for grouping sets .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16122 ) Change subject: IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState .. Patch Set 3: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-01 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 11: (2 comments) http://gerrit.cloude

[native-toolchain-CR] Bump Kudu version to 23f67ae0d

2020-07-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16130 ) Change subject: Bump Kudu version to 23f67ae0d .. Bump Kudu version to 23f67ae0d This pulls in the latest version of

[native-toolchain-CR] Bump Kudu version to 23f67ae0d

2020-07-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16130 ) Change subject: Bump Kudu version to 23f67ae0d .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

2020-07-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 11: Code-Review+1 Carry +1 -- To view, visi

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-891: INTERSECT and EXCEPT Support

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-891: INTERSECT and EXCEPT Support .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-07-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 15: > Patch Set 15: Code-Review+1 > > Than

[Impala-ASF-CR] IMPALA-891: INTERSECT and EXCEPT Support

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-891: INTERSECT and EXCEPT Support .. Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/16

[Impala-ASF-CR] IMPALA-891: INTERSECT and EXCEPT Support

2020-07-01 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16123 Change subject: IMPALA-891: INTERSECT and EXCEPT Support .. IMPALA-891: INTERSECT and EXCEPT Support [WIP] Lots of code cleanup and i

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 2: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 10: (4 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 ) Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. Patch Set 1: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-9911: Fix IS [NOT] NULL predicate selectivity

2020-07-01 Thread Aman Sinha (Code Review)
Aman Sinha has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16131 Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity .. IMPALA-9911: Fix IS [NOT] NULL predicate selectivity When null cou

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. Patch Set 45: Verified+1 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. IMPALA-5444: Asynchronous code generation This commit int

[Impala-ASF-CR] WIP - IMPALA-9898: generate grouping set plans

2020-07-01 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: WIP - IMPALA-9898: generate grouping set plans .. Patch Set 6: (6 comments) Looks good to me! Have some comments. http

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. Patch Set 44: Build Successful https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. Patch Set 45: Build started: https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. Patch Set 45: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

2020-07-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. Patch Set 44: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

2020-07-01 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#44). ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. IMPALA-5444: Asynchronous code generation This commit introduces optional

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-07-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 15: Code-Review+1 Thanks for the change