Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 )
Change subject: IMPALA-9898: Plan generation and execution for grouping sets ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16115/3/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/16115/3/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@339 PS3, Line 339: List<SlotDescriptor> outputSlots = transposeAggInfo_.getResultTupleDesc().getSlots(); > Done. I haven't tested it though since I don't have your changes. I rebased my patch onto this and it works fine - I have a couple of planner and query tests -- To view, visit http://gerrit.cloudera.org:8080/16115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id474c5373860b0d8014ee9c844a3fb90092be968 Gerrit-Change-Number: 16115 Gerrit-PatchSet: 4 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 02 Jul 2020 00:14:47 +0000 Gerrit-HasComments: Yes
