[Impala-ASF-CR] IMPALA-9926 base64decode % will not return error when in newer OS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16175 ) Change subject: IMPALA-9926 base64decode % will not return error when in newer OS .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/6651/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/16175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9bd9e03d5f744c18c957cdaf2064fa918086004 Gerrit-Change-Number: 16175 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 20 Jul 2020 04:34:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9906 Fix thread-pool-test failed case on aarch64
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16173 ) Change subject: IMPALA-9906 Fix thread-pool-test failed case on aarch64 .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/6649/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/16173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b353f7eb9662995d9a8ae460bb1631933873d5d Gerrit-Change-Number: 16173 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 20 Jul 2020 04:30:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9925 cast(pow(2, 31) as int) return 2147483647 on aarch64
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16174 ) Change subject: IMPALA-9925 cast(pow(2, 31) as int) return 2147483647 on aarch64 .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/6650/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/16174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58ab52acebb9bcddbf298efa886fd30ce35f68bf Gerrit-Change-Number: 16174 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 20 Jul 2020 04:26:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9904 Fix bad cipher test failed case on aarch64
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16172 ) Change subject: IMPALA-9904 Fix bad cipher test failed case on aarch64 .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/6648/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/16172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19751b6bf1045fd6d901c5a67f74e8bdd6bf65d3 Gerrit-Change-Number: 16172 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 20 Jul 2020 04:14:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 ) Change subject: IMPALA-9676 Add aarch64 compile options for clang .. Patch Set 14: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/6647/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122 Gerrit-Change-Number: 15755 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 20 Jul 2020 04:13:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9645 Port LLVM codegen to adapt aarch64
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15718 ) Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64 .. Patch Set 16: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/6645/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f30ee84ea9bf5245da88154632bb69079103d11 Gerrit-Change-Number: 15718 Gerrit-PatchSet: 16 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 20 Jul 2020 04:13:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15531 ) Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions .. Patch Set 37: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/6646/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7dfe17125b2910ece54e7dd18b4e4b25d7de8b9 Gerrit-Change-Number: 15531 Gerrit-PatchSet: 37 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 20 Jul 2020 04:13:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15531 ) Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions .. Patch Set 37: (8 comments) http://gerrit.cloudera.org:8080/#/c/15531/37/be/src/util/sse2neon.h File be/src/util/sse2neon.h: http://gerrit.cloudera.org:8080/#/c/15531/37/be/src/util/sse2neon.h@213 PS37, Line 213: // https://msdn.microsoft.com/en-us/library/bb514059%28v=vs.120%29.aspx?f=255=-2147217396 line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/15531/37/be/src/util/sse2neon.h@406 PS37, Line 406: // https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2010/whtfzhzk(v=vs.100) line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/15531/37/be/src/util/sse2neon.h@413 PS37, Line 413: // https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_set1_epi64x=4961 line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/15531/37/be/src/util/sse2neon.h@1054 PS37, Line 1054: // https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_shuffle_epi8=5146 line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/15531/37/be/src/util/sse2neon.h@1199 PS37, Line 1199: // https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2010/y41dkk37(v=vs.100) line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/15531/37/be/src/util/sse2neon.h@1645 PS37, Line 1645: // https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_test_all_zeros=5871 line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/15531/37/be/src/util/sse2neon.h@3581 PS37, Line 3581: // https://github.com/ColinIanKing/linux-next-mirror/blob/b5f466091e130caaf0735976648f72bd5e09aa84/crypto/aegis128-neon-inner.c#L52 line too long (131 > 90) http://gerrit.cloudera.org:8080/#/c/15531/37/be/src/util/sse2neon.h@3681 PS37, Line 3681: // cpp-compiler-developer-guide-and-reference-allocating-and-freeing-aligned-memory-blocks line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7dfe17125b2910ece54e7dd18b4e4b25d7de8b9 Gerrit-Change-Number: 15531 Gerrit-PatchSet: 37 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 20 Jul 2020 03:47:45 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9645 Port LLVM codegen to adapt aarch64
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/15718 )
Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64
..
Patch Set 16:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15718/16/be/src/exprs/scalar-fn-call.cc
File be/src/exprs/scalar-fn-call.cc:
http://gerrit.cloudera.org:8080/#/c/15718/16/be/src/exprs/scalar-fn-call.cc@393
PS16, Line 393: (col_type == TYPE_BOOLEAN or col_type == TYPE_TINYINT
or col_type == TYPE_SMALLINT)) {
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/15718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f30ee84ea9bf5245da88154632bb69079103d11
Gerrit-Change-Number: 15718
Gerrit-PatchSet: 16
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tamas Mate
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Mon, 20 Jul 2020 03:47:01 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9645 Port LLVM codegen to adapt aarch64
zhaoren...@hotmail.com has uploaded a new patch set (#16). (
http://gerrit.cloudera.org:8080/15718 )
Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64
..
IMPALA-9645 Port LLVM codegen to adapt aarch64
On aarch64, the Lowered type of struct {bool, int128} is form
{ {i8}, {i128} }. No padding add. This is different with x86-64,
which is { {i8}, {15*i8}, {i128} } with padding add automatically.
And here also add some type conversion between x86 and aarch64 data types.
And also add some aarch64 cpu's feature.
Change-Id: I3f30ee84ea9bf5245da88154632bb69079103d11
---
M be/src/codegen/codegen-anyval.cc
M be/src/codegen/llvm-codegen.cc
M be/src/exec/text-converter.cc
M be/src/exprs/scalar-fn-call.cc
4 files changed, 169 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/15718/16
--
To view, visit http://gerrit.cloudera.org:8080/15718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f30ee84ea9bf5245da88154632bb69079103d11
Gerrit-Change-Number: 15718
Gerrit-PatchSet: 16
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tamas Mate
Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9904 Fix bad cipher test failed case on aarch64
zhaoren...@hotmail.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16172 ) Change subject: IMPALA-9904 Fix bad cipher test failed case on aarch64 .. IMPALA-9904 Fix bad cipher test failed case on aarch64 On aarch64 and os ubuntu 18.04, the openssl version is 1.1.1, the server which used openssl can start successfully even ciphers is bad. So here just don't test bad ciphers cases on aarch64. On x86, the server cannot start successfully because the lower openssl version, not because the bad cipher. Change-Id: I19751b6bf1045fd6d901c5a67f74e8bdd6bf65d3 --- M be/src/rpc/rpc-mgr-test.cc M be/src/rpc/thrift-server-test.cc M be/src/util/webserver-test.cc 3 files changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/16172/3 -- To view, visit http://gerrit.cloudera.org:8080/16172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I19751b6bf1045fd6d901c5a67f74e8bdd6bf65d3 Gerrit-Change-Number: 16172 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-9925 cast(pow(2, 31) as int) return 2147483647 on aarch64
zhaoren...@hotmail.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16174 ) Change subject: IMPALA-9925 cast(pow(2, 31) as int) return 2147483647 on aarch64 .. IMPALA-9925 cast(pow(2, 31) as int) return 2147483647 on aarch64 cast(pow(2, 31) as int) return 2147483647 on aarch64 but return 2147483648 on x86 I think aarch64 is correct. So here I will not convert it, just use aarch64's value Change-Id: I58ab52acebb9bcddbf298efa886fd30ce35f68bf --- M be/src/exprs/expr-test.cc 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/16174/3 -- To view, visit http://gerrit.cloudera.org:8080/16174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I58ab52acebb9bcddbf298efa886fd30ce35f68bf Gerrit-Change-Number: 16174 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-9906 Fix thread-pool-test failed case on aarch64
zhaoren...@hotmail.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16173 ) Change subject: IMPALA-9906 Fix thread-pool-test failed case on aarch64 .. IMPALA-9906 Fix thread-pool-test failed case on aarch64 Threads switch frequency is not so fast as x86. So here change the sleep task time from 100ms to 500ms Change-Id: I7b353f7eb9662995d9a8ae460bb1631933873d5d --- M be/src/util/thread-pool-test.cc 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/16173/3 -- To view, visit http://gerrit.cloudera.org:8080/16173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7b353f7eb9662995d9a8ae460bb1631933873d5d Gerrit-Change-Number: 16173 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang
zhaoren...@hotmail.com has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/15755 ) Change subject: IMPALA-9676 Add aarch64 compile options for clang .. IMPALA-9676 Add aarch64 compile options for clang Add signed-char and armv8a and crc compile options to clang Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122 --- M be/CMakeLists.txt 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/14 -- To view, visit http://gerrit.cloudera.org:8080/15755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122 Gerrit-Change-Number: 15755 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions
zhaoren...@hotmail.com has uploaded a new patch set (#37). ( http://gerrit.cloudera.org:8080/15531 ) Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions .. IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions Replace Intel's SSE instructions with ARM's NEON instructions Replace Intel's crc32 instructions with ARM's instructions Replace Intel's popcntq instruction with ARM's mechanism Replace Intel's pcmpestri and pcmpestrm instructions with ARM mechanism Change-Id: Id7dfe17125b2910ece54e7dd18b4e4b25d7de8b9 --- M CMakeLists.txt M be/CMakeLists.txt M be/src/benchmarks/bswap-benchmark.cc M be/src/benchmarks/int-hash-benchmark.cc M be/src/codegen/CMakeLists.txt M be/src/codegen/gen_ir_descriptions.py M be/src/codegen/llvm-codegen-test.cc M be/src/codegen/llvm-codegen.cc M be/src/exec/delimited-text-parser.inline.h M be/src/kudu/util/block_bloom_filter.cc M be/src/kudu/util/group_varint-inl.h M be/src/kudu/util/group_varint-test.cc A be/src/kudu/util/sse2neon.h M be/src/util/bit-util-test.cc M be/src/util/bit-util.cc M be/src/util/bit-util.h M be/src/util/bloom-filter.cc M be/src/util/bloom-filter.h M be/src/util/cpu-info.cc M be/src/util/hash-util-ir.cc M be/src/util/hash-util.h M be/src/util/sse-util.h A be/src/util/sse2neon.h 23 files changed, 4,024 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/15531/37 -- To view, visit http://gerrit.cloudera.org:8080/15531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7dfe17125b2910ece54e7dd18b4e4b25d7de8b9 Gerrit-Change-Number: 15531 Gerrit-PatchSet: 37 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9926 base64decode % will not return error when in newer OS
zhaoren...@hotmail.com has uploaded a new patch set (#3). (
http://gerrit.cloudera.org:8080/16175 )
Change subject: IMPALA-9926 base64decode % will not return error when in
newer OS
..
IMPALA-9926 base64decode % will not return error when in newer OS
for example, base64decode('YWxwaGE%') will return
'alpha\377' in newer os which has newer sasl library.
I tested it on Ubuntu 18.04 aarch64 version.
Change-Id: Ib9bd9e03d5f744c18c957cdaf2064fa918086004
---
M be/src/exprs/expr-test.cc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/16175/3
--
To view, visit http://gerrit.cloudera.org:8080/16175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9bd9e03d5f744c18c957cdaf2064fa918086004
Gerrit-Change-Number: 16175
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16199 ) Change subject: IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS .. Patch Set 9: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6143/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ae7546c206daaf98ecc3de449069027c43c6e1a Gerrit-Change-Number: 16199 Gerrit-PatchSet: 9 Gerrit-Owner: Adam Tamas Gerrit-Reviewer: Adam Tamas Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 20 Jul 2020 01:40:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16199 ) Change subject: IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ae7546c206daaf98ecc3de449069027c43c6e1a Gerrit-Change-Number: 16199 Gerrit-PatchSet: 9 Gerrit-Owner: Adam Tamas Gerrit-Reviewer: Adam Tamas Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 20 Jul 2020 01:40:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16199 ) Change subject: IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ae7546c206daaf98ecc3de449069027c43c6e1a Gerrit-Change-Number: 16199 Gerrit-PatchSet: 8 Gerrit-Owner: Adam Tamas Gerrit-Reviewer: Adam Tamas Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 20 Jul 2020 01:39:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9929: Subquery error should throw AnalysisException
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16212 ) Change subject: IMPALA-9929: Subquery error should throw AnalysisException .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16212/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java: http://gerrit.cloudera.org:8080/#/c/16212/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java@1392 PS1, Line 1392: Invariant violated: O I think we should remove the bit about the invariant -- To view, visit http://gerrit.cloudera.org:8080/16212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic299ea25fd6e505e364528891e737a9af5bcc338 Gerrit-Change-Number: 16212 Gerrit-PatchSet: 1 Gerrit-Owner: Shant Hovsepian Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Shant Hovsepian Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 19 Jul 2020 18:52:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16208 ) Change subject: IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce) .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16208/2/be/src/exprs/conditional-functions.cc File be/src/exprs/conditional-functions.cc: http://gerrit.cloudera.org:8080/#/c/16208/2/be/src/exprs/conditional-functions.cc@104 PS2, Line 104:%"class.i > If we reach this block we always return the value (see L113), I gave it tha Ack, no worries. -- To view, visit http://gerrit.cloudera.org:8080/16208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f617a9148492ccafb46112ce0af103a10090f8 Gerrit-Change-Number: 16208 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 19 Jul 2020 18:51:36 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5746: Cancel all queries scheduled by failed coordinators
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16215 ) Change subject: IMPALA-5746: Cancel all queries scheduled by failed coordinators .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6644/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I918fcc27649d5d2bbe8b6ef47fbd9810ae5f57bd Gerrit-Change-Number: 16215 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 19 Jul 2020 17:19:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5746: Cancel all queries scheduled by failed coordinators
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16215 ) Change subject: IMPALA-5746: Cancel all queries scheduled by failed coordinators .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6643/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I918fcc27649d5d2bbe8b6ef47fbd9810ae5f57bd Gerrit-Change-Number: 16215 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 19 Jul 2020 17:11:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5746: Cancel all queries scheduled by failed coordinators
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16215 ) Change subject: IMPALA-5746: Cancel all queries scheduled by failed coordinators .. IMPALA-5746: Cancel all queries scheduled by failed coordinators Executor registers the updating of cluster membership. When coordinators are absence from the active cluster membership list, executer cancels all the running fragments of the queries which are scheduled by the inactive coordinator since the executer cannot send results back to the inactive/failed coordinators. This makes executers quickly release the resources allocated for those running fragments. Testing: - Added new test case TestRestart::test_kill_coordinator. - Passed the core test. Change-Id: I918fcc27649d5d2bbe8b6ef47fbd9810ae5f57bd --- M be/src/benchmarks/expr-benchmark.cc M be/src/runtime/exec-env.cc M be/src/runtime/query-exec-mgr.cc M be/src/runtime/query-exec-mgr.h M be/src/runtime/query-state.cc M be/src/runtime/query-state.h M be/src/service/impala-server.cc M be/src/service/impala-server.h M common/thrift/ImpalaInternalService.thrift M tests/custom_cluster/test_restart_services.py 10 files changed, 127 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/16215/3 -- To view, visit http://gerrit.cloudera.org:8080/16215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I918fcc27649d5d2bbe8b6ef47fbd9810ae5f57bd Gerrit-Change-Number: 16215 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-5746: Cancel all queries scheduled by failed coordinators
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16215 ) Change subject: IMPALA-5746: Cancel all queries scheduled by failed coordinators .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16215/2/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/16215/2/tests/custom_cluster/test_restart_services.py@239 PS2, Line 239: @ > flake8: E303 too many blank lines (2) Fixed -- To view, visit http://gerrit.cloudera.org:8080/16215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I918fcc27649d5d2bbe8b6ef47fbd9810ae5f57bd Gerrit-Change-Number: 16215 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 19 Jul 2020 16:50:22 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5746: Cancel all queries scheduled by failed coordinators
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16215 ) Change subject: IMPALA-5746: Cancel all queries scheduled by failed coordinators .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16215/2/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/16215/2/tests/custom_cluster/test_restart_services.py@239 PS2, Line 239: @ flake8: E303 too many blank lines (2) -- To view, visit http://gerrit.cloudera.org:8080/16215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I918fcc27649d5d2bbe8b6ef47fbd9810ae5f57bd Gerrit-Change-Number: 16215 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Sun, 19 Jul 2020 16:44:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Add link to slack channel on community
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16024 ) Change subject: Add link to slack channel on community .. Patch Set 1: > > Patch Set 1: > > > > Could we just use the-asf.slack.com and create an #impala > channel? It looks like that space is already active with other > projects like Beam and I think the space is blessed by ASF infra. > > The current slack channel has a decent number of people in it. > Might not be worth the switch over to the-asf unless there is some > kind of official policy? SGTM, assuming we can set a good invitation policy that allows new people in without overwhelming the workspace with spam. -- To view, visit http://gerrit.cloudera.org:8080/16024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Ibc05665607cc35a967c01660b6f4890ddd7e6a40 Gerrit-Change-Number: 16024 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Shant Hovsepian Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 19 Jul 2020 16:44:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5746: Cancel all queries scheduled by failed coordinators
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16215 Change subject: IMPALA-5746: Cancel all queries scheduled by failed coordinators .. IMPALA-5746: Cancel all queries scheduled by failed coordinators Executor registers the updating of cluster membership. When coordinators are absence from the active cluster membership list, executer cancels all the running fragments of the queries which are scheduled by the inactive coordinator since the executer cannot send results back to the inactive/failed coordinators. This makes executers quickly release the resources allocated for those running fragments. Testing: - Added new test case TestRestart::test_kill_coordinator. - Passed the core test. Change-Id: I918fcc27649d5d2bbe8b6ef47fbd9810ae5f57bd --- M be/src/benchmarks/expr-benchmark.cc M be/src/runtime/exec-env.cc M be/src/runtime/query-exec-mgr.cc M be/src/runtime/query-exec-mgr.h M be/src/runtime/query-state.cc M be/src/runtime/query-state.h M be/src/service/impala-server.cc M be/src/service/impala-server.h M common/thrift/ImpalaInternalService.thrift M tests/custom_cluster/test_restart_services.py 10 files changed, 129 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/16215/2 -- To view, visit http://gerrit.cloudera.org:8080/16215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I918fcc27649d5d2bbe8b6ef47fbd9810ae5f57bd Gerrit-Change-Number: 16215 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR](asf-site) Add link to slack channel on community
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16024 ) Change subject: Add link to slack channel on community .. Patch Set 1: Code-Review+1 > Patch Set 1: > > Could we just use the-asf.slack.com and create an #impala channel? It looks > like that space is already active with other projects like Beam and I think > the space is blessed by ASF infra. The current slack channel has a decent number of people in it. Might not be worth the switch over to the-asf unless there is some kind of official policy? -- To view, visit http://gerrit.cloudera.org:8080/16024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Ibc05665607cc35a967c01660b6f4890ddd7e6a40 Gerrit-Change-Number: 16024 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Shant Hovsepian Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 19 Jul 2020 12:04:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9741: Support querying Iceberg table by impala
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 ) Change subject: IMPALA-9741: Support querying Iceberg table by impala .. Patch Set 13: (10 comments) Thanks for applying the changes and for the tests. Unfortunately last time the gerrit "New UI" hid some files from me... http://gerrit.cloudera.org:8080/#/c/16143/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16143/13//COMMIT_MSG@38 PS13, Line 38: custom cluster test test_iceberg.py The tests are added to test_scanners.py http://gerrit.cloudera.org:8080/#/c/16143/13/testdata/data/README File testdata/data/README: http://gerrit.cloudera.org:8080/#/c/16143/13/testdata/data/README@503 PS13, Line 503: Supported query icebreg table by impala Please update this to reflect the current title http://gerrit.cloudera.org:8080/#/c/16143/13/testdata/data/README@504 PS13, Line 504: Apache Iceberg is an open table format for huge analytic datasets. : Iceberg avoids unpleasant surprises. Schema evolution works and won’t inadvertently : un-delete data. Users don’t need to know about partitioning to get fast queries. : And Iceberg was designed to solve correctness problems in eventually-consistent cloud : object stores. Please provide a description about the tables in the iceberg directory, not about Iceberg itself. Also, please mention how the data was generated, e.g. what tool and what version. http://gerrit.cloudera.org:8080/#/c/16143/13/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/16143/13/testdata/datasets/functional/functional_schema_template.sql@2868 PS13, Line 2868: STORED AS ICEBERG Don't you need to provide a partition spec? Also, please add a SHOW PARTITIONS test for it in one of the test files. http://gerrit.cloudera.org:8080/#/c/16143/13/testdata/workloads/functional-query/queries/QueryTest/iceberg_query.test File testdata/workloads/functional-query/queries/QueryTest/iceberg_query.test: http://gerrit.cloudera.org:8080/#/c/16143/13/testdata/workloads/functional-query/queries/QueryTest/iceberg_query.test@3 PS13, Line 3: Supported query icebreg table by impala Please update this http://gerrit.cloudera.org:8080/#/c/16143/13/testdata/workloads/functional-query/queries/QueryTest/iceberg_query.test@42 PS13, Line 42: 14 You could add a RUNTIME_PROFILE section to check that partition pruning worked. E.g. https://github.com/apache/impala/blob/76e4a17fb379bb232618dccb4ad3504dbe5c945c/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test#L29 http://gerrit.cloudera.org:8080/#/c/16143/13/testdata/workloads/functional-query/queries/QueryTest/iceberg_query.test@77 PS13, Line 77: SELECT count(*) from iceberg_non_partitioned Please add non-count queries as well. After you are convinced that the queries produce the correct results, you can use the following command to re-generate this file: bin/impala-py.test --update_results tests/query_test/test_scanners.py::TestIceberg::test_iceberg You'll find the generated .test file in 'logs/ee_tests/' Alternatively, you can set these in the Impala shell: set write_delimited=true; set delimiter=,; Then Impala shell will produce an output that can be copy-pasted here. http://gerrit.cloudera.org:8080/#/c/16143/13/testdata/workloads/functional-query/queries/QueryTest/iceberg_query.test@83 PS13, Line 83: Please add SHOW FILES for each table. Also, you could add an iceberg-negative.test that'd check we get proper error messages for features not supported for Iceberg. E.g.: https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/acid-negative.test http://gerrit.cloudera.org:8080/#/c/16143/13/tests/custom_cluster/test_iceberg.py File tests/custom_cluster/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/16143/13/tests/custom_cluster/test_iceberg.py@23 PS13, Line 23: class TestCreatingIcebergTable(CustomClusterTestSuite): This test could be put into tests/query_test, instead of tests/custom_cluster. And it could just inherit from ImpalaTestSuite. This way we wouldn't need to restart the Impala cluster whenever this test is being run. http://gerrit.cloudera.org:8080/#/c/16143/13/tests/custom_cluster/test_iceberg.py@30 PS13, Line 30: @pytest.mark.execute_serially I think there's no need for this annotation. Since this test is using a unique database it can be run in parallel with other tests. -- To view, visit http://gerrit.cloudera.org:8080/16143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I856cfee4f3397d1a89cf17650e8d4fbfe1f2b006 Gerrit-Change-Number: 16143 Gerrit-PatchSet: 13 Gerrit-Owner: wangsheng
