Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16208 )
Change subject: IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce) ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16208/2/be/src/exprs/conditional-functions.cc File be/src/exprs/conditional-functions.cc: http://gerrit.cloudera.org:8080/#/c/16208/2/be/src/exprs/conditional-functions.cc@104 PS2, Line 104: %"class.i > If we reach this block we always return the value (see L113), I gave it tha Ack, no worries. -- To view, visit http://gerrit.cloudera.org:8080/16208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f617a9148492ccafb46112ce0af103a10090f8 Gerrit-Change-Number: 16208 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sun, 19 Jul 2020 18:51:36 +0000 Gerrit-HasComments: Yes
