[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 16: Code-Review+1 LGTM. Give +1 first in case others want to have a look. -- To view, visit http://gerrit.cloudera.org:8080/17306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1669858a6e8252e167b464586e8d0b6cb0d0bd50 Gerrit-Change-Number: 17306 Gerrit-PatchSet: 16 Gerrit-Owner: fifteencai Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: fifteencai Gerrit-Comment-Date: Mon, 19 Apr 2021 03:53:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10584: Defer advancing read page if stream only has 2 pages.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page if stream only has 2 pages. .. Patch Set 6: Code-Review+1 > > Patch set 5 change the condition on when to NOT advance the read page. > > Read page will not be advanced in UnpinStream if read page is attached to > > output RowBatch and there are only 2 pages in the stream. > > Sorry, I should mention patch set 6 instead of 5. Nice! I think this fix is more clean and safe. LGTM. Give +1 first in case other guys are also reviewing this. -- To view, visit http://gerrit.cloudera.org:8080/17195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16137b6e423f190f60c3115a06ccd0f77e9f585a Gerrit-Change-Number: 17195 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 19 Apr 2021 02:11:45 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP: upgrading some python requirements.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 ) Change subject: WIP: upgrading some python requirements. .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7079/ -- To view, visit http://gerrit.cloudera.org:8080/17323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 Gerrit-Change-Number: 17323 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 18 Apr 2021 23:28:07 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP: upgrading some python requirements.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 ) Change subject: WIP: upgrading some python requirements. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8593/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 Gerrit-Change-Number: 17323 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 18 Apr 2021 17:56:51 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP: upgrading some python requirements.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 ) Change subject: WIP: upgrading some python requirements. .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7079/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/17323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 Gerrit-Change-Number: 17323 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 18 Apr 2021 17:40:19 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP: upgrading some python requirements.
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17323 Change subject: WIP: upgrading some python requirements. .. WIP: upgrading some python requirements. Just checking to see if removing adls python packages breaks any tests Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 --- M infra/python/deps/adls-requirements.txt 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/17323/1 -- To view, visit http://gerrit.cloudera.org:8080/17323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 Gerrit-Change-Number: 17323 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
