[Impala-ASF-CR](asf-site) Add 4.0.0 Release notes and change log

2021-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17671 )

Change subject: Add 4.0.0 Release notes and change log
..


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/637/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/17671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f43b8a58e3adaad9423f3ed2cdd8ab7b187969c
Gerrit-Change-Number: 17671
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Mon, 12 Jul 2021 05:58:34 +
Gerrit-HasComments: No


[Impala-ASF-CR](asf-site) Add 4.0.0 Release notes and change log

2021-07-11 Thread Quanlong Huang (Code Review)
Hello Zoltan Borok-Nagy, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, 
Jim Apple,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/17671

to look at the new patch set (#2).

Change subject: Add 4.0.0 Release notes and change log
..

Add 4.0.0 Release notes and change log

Tested by opening html files in my browser.

Change-Id: I3f43b8a58e3adaad9423f3ed2cdd8ab7b187969c
---
A docs/changelog-4.0.html
A docs/release-notes-4.0.html
M impala-docs.html
3 files changed, 1,642 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/17671/2
--
To view, visit http://gerrit.cloudera.org:8080/17671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f43b8a58e3adaad9423f3ed2cdd8ab7b187969c
Gerrit-Change-Number: 17671
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR](asf-site) Add 4.0.0 Release notes and change log

2021-07-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has removed a vote on this change.

Change subject: Add 4.0.0 Release notes and change log
..


Removed Verified-1 by Impala Public Jenkins 
--
To view, visit http://gerrit.cloudera.org:8080/17671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3f43b8a58e3adaad9423f3ed2cdd8ab7b187969c
Gerrit-Change-Number: 17671
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR](asf-site) Add 4.0.0 Release notes and change log

2021-07-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17671 )

Change subject: Add 4.0.0 Release notes and change log
..


Patch Set 1:

There is the same failure when we released 3.4.0: 
https://gerrit.cloudera.org/c/15669/

I think the verification job only handles normal doc patch. Let me remove the 
-1 from it.


--
To view, visit http://gerrit.cloudera.org:8080/17671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f43b8a58e3adaad9423f3ed2cdd8ab7b187969c
Gerrit-Change-Number: 17671
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Mon, 12 Jul 2021 05:53:36 +
Gerrit-HasComments: No


[Impala-ASF-CR] Update version to 4.1.0-SNAPSHOT

2021-07-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17672 )

Change subject: Update version to 4.1.0-SNAPSHOT
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/17672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cdf3084bb8fbc56944c26a2adc2cb838349f4b8
Gerrit-Change-Number: 17672
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Mon, 12 Jul 2021 01:54:33 +
Gerrit-HasComments: No


[Impala-ASF-CR] Update version to 4.1.0-SNAPSHOT

2021-07-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/17672 )

Change subject: Update version to 4.1.0-SNAPSHOT
..

Update version to 4.1.0-SNAPSHOT

Change-Id: I7cdf3084bb8fbc56944c26a2adc2cb838349f4b8
Reviewed-on: http://gerrit.cloudera.org:8080/17672
Reviewed-by: Jim Apple 
Tested-by: Quanlong Huang 
---
M bin/save-version.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jim Apple: Looks good to me, approved
  Quanlong Huang: Verified

--
To view, visit http://gerrit.cloudera.org:8080/17672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cdf3084bb8fbc56944c26a2adc2cb838349f4b8
Gerrit-Change-Number: 17672
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Quanlong Huang 


[Impala-ASF-CR] IMPALA-10784: Add support for retaining cookies in impala-shell

2021-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17667 )

Change subject: IMPALA-10784: Add support for retaining cookies in impala-shell
..


Patch Set 5:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/9071/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/17667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I193422d5ec891886a522d82ecb0e9d974132ff2a
Gerrit-Change-Number: 17667
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Wenzhe Zhou 
Gerrit-Comment-Date: Mon, 12 Jul 2021 01:17:15 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10784: Add support for retaining cookies in impala-shell

2021-07-11 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#5). ( 
http://gerrit.cloudera.org:8080/17667 )

Change subject: IMPALA-10784: Add support for retaining cookies in impala-shell
..

IMPALA-10784: Add support for retaining cookies in impala-shell

IMPALA-10234 added support for cookie authentication for LDAP to
impala-shell. But it does not accept user input cookie name via
startup flags, and it retains only one cookie.

In some scenarios, we could use proxy to manage the sessions with
additional HTTP cookies added by proxy.
This patch made cookie support more generic for impala-shell.
It lets the user specify cookie names via a startup flag
"--http_cookie_names" and could retain more than one cookies.

Testing:
 - Manualy tested the multiple cookies in HTTP headers with a
   customized Impala server which could send and receive multiple
   cookies.
 - Passed core test, including new test cases.

Change-Id: I193422d5ec891886a522d82ecb0e9d974132ff2a
---
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M shell/ImpalaHttpClient.py
M shell/cookie_util.py
M shell/impala_client.py
M shell/impala_shell.py
M shell/option_parser.py
M tests/shell/test_cookie_util.py
7 files changed, 146 insertions(+), 67 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/17667/5
-- 
To view, visit http://gerrit.cloudera.org:8080/17667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I193422d5ec891886a522d82ecb0e9d974132ff2a
Gerrit-Change-Number: 17667
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Wenzhe Zhou 


[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-07-11 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17389 )

Change subject: IMPALA-10680: Replace StringToFloatInternal using 
fast_double_parser library
..


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17389/7/be/src/util/string-parser.h
File be/src/util/string-parser.h:

http://gerrit.cloudera.org:8080/#/c/17389/7/be/src/util/string-parser.h@508
PS7, Line 508: s[len])
> The idea is to find the conditions to go to the ELSE branch quickly (withou
I see. Thanks for the details. So those conditions do not determine ELSE i.e., 
they don't determine if string copy is not required. We can have strings 
satisfying those conditions and still needing copy (for e.g., when they are not 
null-terminated). And also we want some strings that do not satisfy above 
conditions to goto ELSE branch. For instance a null-terminated invalid input 
"INVALID_NUM", we want it to goto ELSE branch and not create copy of it.



--
To view, visit http://gerrit.cloudera.org:8080/17389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic105ad38a2fcbf2fb4e8ae8af6d9a8e251a9c141
Gerrit-Change-Number: 17389
Gerrit-PatchSet: 8
Gerrit-Owner: Amogh Margoor 
Gerrit-Reviewer: Amogh Margoor 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Qifan Chen 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Sun, 11 Jul 2021 15:58:47 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-10763: Min/max filters should be enabled on Z-order sorted columns

2021-07-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17635 )

Change subject: IMPALA-10763: Min/max filters should be enabled on Z-order 
sorted columns
..


Patch Set 8: Code-Review+2

(1 comment)

LGTM

http://gerrit.cloudera.org:8080/#/c/17635/8/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_sorted_columns.test
File 
testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_sorted_columns.test:

http://gerrit.cloudera.org:8080/#/c/17635/8/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_sorted_columns.test@284
PS8, Line 284: PRIMARY KEY (ss_item_sk, ss_ticket_number)
nit: PRIMARY KEY seems useless here. I think it's only used by Kudu tables.



--
To view, visit http://gerrit.cloudera.org:8080/17635
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a528ffbd0e333721ef38b4be7d4ddcdbf188adf
Gerrit-Change-Number: 17635
Gerrit-PatchSet: 8
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Qifan Chen 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Sun, 11 Jul 2021 13:40:11 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] Update version to 4.1.0-SNAPSHOT

2021-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17672 )

Change subject: Update version to 4.1.0-SNAPSHOT
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/9070/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/17672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cdf3084bb8fbc56944c26a2adc2cb838349f4b8
Gerrit-Change-Number: 17672
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Sun, 11 Jul 2021 13:22:07 +
Gerrit-HasComments: No


[Impala-ASF-CR](asf-site) Add 4.0.0 Release notes and change log

2021-07-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17671 )

Change subject: Add 4.0.0 Release notes and change log
..


Patch Set 1:

I don't understand why the Jenkins job is failing. It's not finding 
check-rat-report and Makefile, but this patch touches neither of those . . .


--
To view, visit http://gerrit.cloudera.org:8080/17671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f43b8a58e3adaad9423f3ed2cdd8ab7b187969c
Gerrit-Change-Number: 17671
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Sun, 11 Jul 2021 13:21:32 +
Gerrit-HasComments: No


[Impala-ASF-CR] Update version to 4.1.0-SNAPSHOT

2021-07-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17672 )

Change subject: Update version to 4.1.0-SNAPSHOT
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/17672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cdf3084bb8fbc56944c26a2adc2cb838349f4b8
Gerrit-Change-Number: 17672
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Sun, 11 Jul 2021 13:20:27 +
Gerrit-HasComments: No


[Impala-ASF-CR](asf-site) Update download links for release 4.0.0

2021-07-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17669 )

Change subject: Update download links for release 4.0.0
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17669/1/downloads.html
File downloads.html:

http://gerrit.cloudera.org:8080/#/c/17669/1/downloads.html@136
PS1, Line 136:   
"https://downloads.apache.org/impala/4.0.0/apache-impala-4.0.0.tar.gz;>
This is 404 right now, presumably b/c the apache mirrors have not caught up yet 
(it takes them 24 hours).



--
To view, visit http://gerrit.cloudera.org:8080/17669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b51e29eb7f31c5535e226b58c063aa4e1c58dc6
Gerrit-Change-Number: 17669
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Sun, 11 Jul 2021 13:16:14 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] Update version to 4.1.0-SNAPSHOT

2021-07-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/17672


Change subject: Update version to 4.1.0-SNAPSHOT
..

Update version to 4.1.0-SNAPSHOT

Change-Id: I7cdf3084bb8fbc56944c26a2adc2cb838349f4b8
---
M bin/save-version.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/17672/1
--
To view, visit http://gerrit.cloudera.org:8080/17672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cdf3084bb8fbc56944c26a2adc2cb838349f4b8
Gerrit-Change-Number: 17672
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 


[Impala-ASF-CR](asf-site) Add 4.0.0 Release notes and change log

2021-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17671 )

Change subject: Add 4.0.0 Release notes and change log
..


Patch Set 1: Verified-1

Build Failed

https://jenkins.impala.io/job/gerrit-docs-auto-test/636/ : Doc tests failed. 
See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/17671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f43b8a58e3adaad9423f3ed2cdd8ab7b187969c
Gerrit-Change-Number: 17671
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Sun, 11 Jul 2021 12:57:45 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-07-11 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17389 )

Change subject: IMPALA-10680: Replace StringToFloatInternal using 
fast_double_parser library
..


Patch Set 8:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/17389/7/be/src/util/string-parser-test.cc
File be/src/util/string-parser-test.cc:

http://gerrit.cloudera.org:8080/#/c/17389/7/be/src/util/string-parser-test.cc@535
PS7, Line 535:   TestStringToFloatPreprocess(".43256e4", "0.43256e4");
> Preprocess function doesn't handle sign either '+' or '-', so have added it
I see. Done.


http://gerrit.cloudera.org:8080/#/c/17389/7/be/src/util/string-parser.h
File be/src/util/string-parser.h:

http://gerrit.cloudera.org:8080/#/c/17389/7/be/src/util/string-parser.h@508
PS7, Line 508: s[len])
> I didn't understand the conditions above, but if s ='99' (which satisfies c
The idea is to find the conditions to go to the ELSE branch quickly (without 
looking ahead too much).

The JSON specs on numeric values are as follows (from 
https://datatracker.ietf.org/doc/html/rfc7159), on which the fast_double_parser 
is based.

Numeric values that cannot be represented in the grammar below (such
   as Infinity and NaN) are not permitted.

  number = [ minus ] int [ frac ] [ exp ]

  decimal-point = %x2E   ; .

  digit1-9 = %x31-39 ; 1-9

  e = %x65 / %x45; e E

  exp = e [ minus / plus ] 1*DIGIT

  frac = decimal-point 1*DIGIT

  int = zero / ( digit1-9 *DIGIT )

  minus = %x2D   ; -

  plus = %x2B; +

  zero = %x30; 0

Thus, the conditions to do so are

1). minus digit1-9
2). digit1-9
3). 0 frac

Sorry I did not spell out these conditions precisely in the first attempt.


http://gerrit.cloudera.org:8080/#/c/17389/7/be/src/util/string-parser.h@541
PS7, Line 541: return (T)(negative ? -val : val);
> It will be reached for UNDERFLOW and OVERFLOW.
Done



--
To view, visit http://gerrit.cloudera.org:8080/17389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic105ad38a2fcbf2fb4e8ae8af6d9a8e251a9c141
Gerrit-Change-Number: 17389
Gerrit-PatchSet: 8
Gerrit-Owner: Amogh Margoor 
Gerrit-Reviewer: Amogh Margoor 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Qifan Chen 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Sun, 11 Jul 2021 12:55:30 +
Gerrit-HasComments: Yes


[Impala-ASF-CR](asf-site) Add 4.0.0 Release notes and change log

2021-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17671 )

Change subject: Add 4.0.0 Release notes and change log
..


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/636/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/17671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f43b8a58e3adaad9423f3ed2cdd8ab7b187969c
Gerrit-Change-Number: 17671
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Sun, 11 Jul 2021 12:53:02 +
Gerrit-HasComments: No


[Impala-ASF-CR](asf-site) Add 4.0.0 Release notes and change log

2021-07-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/17671


Change subject: Add 4.0.0 Release notes and change log
..

Add 4.0.0 Release notes and change log

Tested by opening html files in my browser.

Change-Id: I3f43b8a58e3adaad9423f3ed2cdd8ab7b187969c
---
A docs/changelog-4.0.html
A docs/release-notes-4.0.html
M impala-docs.html
3 files changed, 1,642 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/17671/1
--
To view, visit http://gerrit.cloudera.org:8080/17671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f43b8a58e3adaad9423f3ed2cdd8ab7b187969c
Gerrit-Change-Number: 17671
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 


[Impala-ASF-CR] IMPALA-10763: Min/max filters should be enabled on Z-order sorted columns

2021-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17635 )

Change subject: IMPALA-10763: Min/max filters should be enabled on Z-order 
sorted columns
..


Patch Set 8:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/9069/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/17635
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a528ffbd0e333721ef38b4be7d4ddcdbf188adf
Gerrit-Change-Number: 17635
Gerrit-PatchSet: 8
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Qifan Chen 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Sun, 11 Jul 2021 12:52:39 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10763: Min/max filters should be enabled on Z-order sorted columns

2021-07-11 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#8). ( 
http://gerrit.cloudera.org:8080/17635 )

Change subject: IMPALA-10763: Min/max filters should be enabled on Z-order 
sorted columns
..

IMPALA-10763: Min/max filters should be enabled on Z-order sorted columns

This patch enables min/max filtering on any Z-order sort-by columns
by default.

Since the column stats for a row group or a page is computed from the
column valuess stored in the row group or the page, the current
infrastructure for min/max filtering works for the Z-order out of box.
The fact that these column valuess are ordered by Z-order is
orthogonal to the work of min/max filtering.

By default, the new feature is enabled. Set the existing control knob
minmax_filter_sorted_columns to false to turn it off.

Testing
  1. Added new z-order related sort column tests in
 overlap_min_max_filters_on_sorted_columns.test;
  2. Ran core-test.

Change-Id: I2a528ffbd0e333721ef38b4be7d4ddcdbf188adf
---
M be/src/service/query-options.cc
M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M 
testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_sorted_columns.test
4 files changed, 145 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/17635/8
--
To view, visit http://gerrit.cloudera.org:8080/17635
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a528ffbd0e333721ef38b4be7d4ddcdbf188adf
Gerrit-Change-Number: 17635
Gerrit-PatchSet: 8
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Qifan Chen 
Gerrit-Reviewer: Quanlong Huang