[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-10 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 1: I don't think a test would work with HDFS and

[Impala-ASF-CR] WIP IMPALA-11809: Support non unique primary key for Kudu

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19383 ) Change subject: WIP IMPALA-11809: Support non unique primary key for Kudu .. Patch Set 9: Build Failed

[Impala-ASF-CR] WIP IMPALA-11809: Support non unique primary key for Kudu

2023-01-10 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/19383 ) Change subject: WIP IMPALA-11809: Support non unique primary key for Kudu .. WIP IMPALA-11809: Support non unique primary key for Kudu

[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance

2023-01-10 Thread Anonymous Coward (Code Review)
lipeng...@apache.org has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. IMPALA-11662: Improve 'refresh

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 6: Verify tests fail in test_time_travel. It

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-11375 Impala shell outputs details of each RPC

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19388 ) Change subject: IMPALA-11375 Impala shell outputs details of each RPC .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-11375 Impala shell outputs details of each RPC

2023-01-10 Thread Jason Fehr (Code Review)
Jason Fehr has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/19388 ) Change subject: IMPALA-11375 Impala shell outputs details of each RPC .. IMPALA-11375 Impala shell outputs details of each RPC When the

[Impala-ASF-CR] IMPALA-11778: Printing maps may produce invalid json

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19364 ) Change subject: IMPALA-11778: Printing maps may produce invalid json .. IMPALA-11778: Printing maps may produce

[Impala-ASF-CR] IMPALA-11778: Printing maps may produce invalid json

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19364 ) Change subject: IMPALA-11778: Printing maps may produce invalid json .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-10 Thread Sai Hemanth Gantasala (Code Review)
Hello Quanlong Huang, Daniel Becker, Yu-Wen Lai, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19140 to look at the new patch set (#4). Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 4: (1

[Impala-ASF-CR] IMPALA-11375: Impala shell outputs details of each RPC

2023-01-10 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has removed a vote on this change. Change subject: IMPALA-11375: Impala shell outputs details of each RPC .. Removed Code-Review+2 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] WIP IMPALA-11809: Support non unique primary key for Kudu

2023-01-10 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19383 ) Change subject: WIP IMPALA-11809: Support non unique primary key for Kudu .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 30: Build Successful

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 30: ps30 is a rebase of ps29. -- To view, visit

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-10 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#30) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 6: Build Failed

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 6: Code-Review+2 Carry forward +2 -- To

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#6). Change subject: IMPALA-10893: Use old schema during iceberg time travel.

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables

2023-01-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19397 ) Change subject: IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables .. Patch Set 4: (3 comments) Went

[Impala-ASF-CR] IMPALA-11778: Printing maps may produce invalid json

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19364 ) Change subject: IMPALA-11778: Printing maps may produce invalid json .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-11778: Printing maps may produce invalid json

2023-01-10 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19364 ) Change subject: IMPALA-11778: Printing maps may produce invalid json .. IMPALA-11778: Printing maps may produce invalid json Impala

[Impala-ASF-CR] IMPALA-11778: Printing maps may produce invalid json

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19364 ) Change subject: IMPALA-11778: Printing maps may produce invalid json .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11778: Printing maps may produce invalid json

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19364 ) Change subject: IMPALA-11778: Printing maps may produce invalid json .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-11778: Printing maps may produce invalid json

2023-01-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19364 ) Change subject: IMPALA-11778: Printing maps may produce invalid json .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 5: Code-Review+2 LGTM and nice tests! --

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 1: The change LGTM. Is it possible to add

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-10 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19410 Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash The

[Impala-ASF-CR] WIP IMPALA-11833: Fixed manifest length in snapshot files

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19409 ) Change subject: WIP IMPALA-11833: Fixed manifest_length in snapshot files .. Patch Set 1: Build Successful

[Impala-ASF-CR] WIP IMPALA-11833: Fixed manifest length in snapshot files

2023-01-10 Thread Code Review
Gergely Fürnstáhl has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19409 Change subject: WIP IMPALA-11833: Fixed manifest_length in snapshot files .. WIP IMPALA-11833: Fixed manifest_length in snapshot

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-10 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list

[Impala-ASF-CR] WIP IMPALA-5323: Support Kudu BINARY

2023-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18868 ) Change subject: WIP IMPALA-5323: Support Kudu BINARY .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-10 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 3: Code-Review+1

[Impala-ASF-CR] IMPALA-7969: Always admit trivial queries immediately

2023-01-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19214 ) Change subject: IMPALA-7969: Always admit trivial queries immediately .. Patch Set 5: Code-Review+1 Thanks for the changes! -- To

[Impala-ASF-CR] WIP IMPALA-5323: Support Kudu BINARY

2023-01-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18868 Change subject: WIP IMPALA-5323: Support Kudu BINARY .. WIP IMPALA-5323: Support Kudu BINARY Also changed ColumnType to include the

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 5: Code-Review+1 Thanks for the work, LGTM!