[Impala-ASF-CR] IMPALA-7448: Invalidate recently unused tables from catalogd

2018-08-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11224 ) Change subject: IMPALA-7448: Invalidate recently unused tables from catalogd .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-08-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6709: Simplify tests that copy local files to tables

2018-08-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 ) Change subject: IMPALA-6709: Simplify tests that copy local files to tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11387 Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. IMPALA-6568 add missing Query Compilation section to

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 2: (1 comment)

[Impala-ASF-CR] WIP: IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11387 ) Change subject: WIP: IMPALA-6568 add missing Query Compilation section to profiles. .. WIP: IMPALA-6568 add missing Query Compilation

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. IMPALA-6568 add missing Query Compilation section to

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. Patch Set 3: (5 comments)

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 3: (2 comments)

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. IMPALA-6568 add missing Query Compilation section to

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. IMPALA-6568 add missing Query Compilation section to

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 1: (5 comments) Another patch should be coming

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 1: (4 comments) Thanks for the

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 2: (7 comments) Thanks for the reviews

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 2: > It seems good to me, but I

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11719 Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 2: (5 comments) Thanks Thomas and Csaba for

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 4: (21 comments) Thanks for

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 4: I added a new patch because

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 2: (4 comments) Thanks Csaba

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-11-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-11-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 4: (1 comment) I agree that

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-11-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-11-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-11-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11582 Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder

[Impala-ASF-CR] IMPALA-589: Add sql function returning the impalad coordinator hostname.

2018-09-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11459 ) Change subject: IMPALA-589: Add sql function returning the impalad coordinator hostname. .. IMPALA-589: Add sql function returning the

[Impala-ASF-CR] IMPALA-589: Add sql function returning the impalad coordinator hostname.

2018-09-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11459 ) Change subject: IMPALA-589: Add sql function returning the impalad coordinator hostname. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-589: Add sql function returning the impalad coordinator hostname.

2018-09-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11459 ) Change subject: IMPALA-589: Add sql function returning the impalad coordinator hostname. .. IMPALA-589: Add sql function returning the

[Impala-ASF-CR] IMPALA-589: Add sql function returning the impalad coordinator hostname.

2018-09-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11459 ) Change subject: IMPALA-589: Add sql function returning the impalad coordinator hostname. .. Patch Set 2: (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. IMPALA-7801: Remove toSql() from ParseNode interface. In

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11942 Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. IMPALA-7801: Remove toSql() from ParseNode interface. In

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12142 Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. IMPALA-7468: Port CancelQueryFInstances() to KRPC. When the

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. IMPALA-7468: Port CancelQueryFInstances() to KRPC. When the

[Impala-ASF-CR] IMPALA-8047 Support .proto files in .clang-format

2019-01-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12165 Change subject: IMPALA-8047 Support .proto files in .clang-format .. IMPALA-8047 Support .proto files in .clang-format The .proto

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. Patch Set 1: (6 comments) Thanks for the helpful review

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. IMPALA-7468: Port CancelQueryFInstances() to KRPC. When the

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12260 Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. Patch Set 3: I tested performance of the two

[Impala-ASF-CR] IMPALA-7183: Include remote host when logging unknown execution status.

2018-12-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12102 Change subject: IMPALA-7183: Include remote host when logging unknown execution status. .. IMPALA-7183: Include remote host when

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and

[Impala-ASF-CR] IMPALA-7183: Include remote host when logging unknown execution status.

2018-12-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12102 ) Change subject: IMPALA-7183: Include remote host when logging unknown execution status. .. IMPALA-7183: Include remote host when

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12068 Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-11-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 ) Change subject: IMPALA-6924: Add child queries to profile in compute stats .. Patch Set 2: (2 comments) Looks like a useful change

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-12-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 ) Change subject: IMPALA-6924: Add child queries to profile in compute stats .. Patch Set 4: Code-Review+1 (5 comments) This all

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has abandoned this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Abandoned Will let Paul Rogers fix (or at least think about) in a

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Patch Set 4: Thanks Csaba, hope you didn't waste too much

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. IMPALA-7801: Remove toSql() from ParseNode interface. In

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. IMPALA-7801: Remove toSql() from ParseNode interface. In

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Patch Set 2: (6 comments) Thanks Paul for the interesting

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Patch Set 4: reviewers should ignore patch set 3 which is

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has removed Vuk Ercegovac from this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Removed reviewer Vuk Ercegovac. -- To view, visit

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Patch Set 4: I'm not happy with using ORIGINAL as the

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2019-01-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. Patch Set 3: (11 comments) Thanks for the code reviews

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. IMPALA-7468: Port CancelQueryFInstances() to KRPC. When the

[Impala-ASF-CR] IMPALA-589: Add a sql function to return the impalad coordinator hostname for diagnostic purposes.

2018-09-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11459 Change subject: IMPALA-589: Add a sql function to return the impalad coordinator hostname for diagnostic purposes. .. IMPALA-589: Add

[Impala-ASF-CR] IMPALA-7492: Add support for DATE text parser/formatter

2018-09-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11450 ) Change subject: IMPALA-7492: Add support for DATE text parser/formatter .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7579: use the generic filesystem client to delete and create files in test query profile contains all events.

2018-09-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11461 Change subject: IMPALA-7579: use the generic filesystem_client to delete and create files in test_query_profile_contains_all_events.

[Impala-ASF-CR] IMPALA-7579: fix test query profile contains all events on S3

2018-09-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11461 ) Change subject: IMPALA-7579: fix test_query_profile_contains_all_events on S3 .. IMPALA-7579: fix

[Impala-ASF-CR] IMPALA-7579: fix test query profile contains all events on S3

2018-09-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11461 ) Change subject: IMPALA-7579: fix test_query_profile_contains_all_events on S3 .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 2: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 5: (3 comments) Thanks Michael. Please see the upcoming Patch

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 8: Reviewers please wait for a future Patch Ste with a

[Impala-ASF-CR] IMPALA-8345 : Add option to set up minicluster to use Hive 3

2019-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12846 ) Change subject: IMPALA-8345 : Add option to set up minicluster to use Hive 3 .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of

[Impala-ASF-CR] IMPALA-8345 : Add option to set up minicluster to use Hive 3

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12846 ) Change subject: IMPALA-8345 : Add option to set up minicluster to use Hive 3 .. Patch Set 7: Code-Review+1 (5 comments) a few nits

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of

[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable

2019-04-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 1: Code-Review+1 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 5: (20 comments) Thanks for the reviews. Please see patch set

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of

[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04

2019-03-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12893 ) Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04 .. Patch Set 1: Code-Review+1 (2 comments) LGTM

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 4: (1 comment)

[Impala-ASF-CR] Improve error handling for validation of unified backend executable

2019-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Patch Set 1: Code-Review+1 LGTM -- To

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 2: (2 comments) Looks good

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 8: (5 comments) All I have are nits and

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 1: Oh I see, the

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 1: (3 comments) Change looks

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-03-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 3: Code-Review+1 LGTM -- To

  1   2   3   4   5   6   7   >