Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 )
Change subject: IMPALA-6709: Simplify tests that copy local files to tables ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11127/1/tests/common/test_parquet.py File tests/common/test_parquet.py: http://gerrit.cloudera.org:8080/#/c/11127/1/tests/common/test_parquet.py@31 PS1, Line 31: hdfs_file = '/test-warehouse/{0}.db/{1}'.format(unique_database, filename) This is the nittiest of nits, but I am learning python: Do we use both '%' and 'format' ? Is it good style to mix and match them in the same file? -- To view, visit http://gerrit.cloudera.org:8080/11127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie00a4561825facf8abe2e8e74a6b6e93194f416f Gerrit-Change-Number: 11127 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 17:42:41 +0000 Gerrit-HasComments: Yes
