[Impala-ASF-CR] IMPALA-13185: Include runtime filter source in key
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21729 ) Change subject: IMPALA-13185: Include runtime filter source in key .. Patch Set 8: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/17035/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/21729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a Gerrit-Change-Number: 21729 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 25 Sep 2024 23:59:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13185: Include runtime filter source in key
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21729 ) Change subject: IMPALA-13185: Include runtime filter source in key .. Patch Set 7: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/17034/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/21729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a Gerrit-Change-Number: 21729 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 25 Sep 2024 23:54:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13185: Include runtime filter source in key
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21729 ) Change subject: IMPALA-13185: Include runtime filter source in key .. Patch Set 6: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/17033/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/21729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a Gerrit-Change-Number: 21729 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 25 Sep 2024 23:52:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13185: Include runtime filter source in key
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21729 ) Change subject: IMPALA-13185: Include runtime filter source in key .. Patch Set 6: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py@30 PS6, Line 30: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py@31 PS6, Line 31: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py@32 PS6, Line 32: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py@34 PS6, Line 34: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py@46 PS6, Line 46: def assertCounter(profile, key, val, num_matches): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py@52 PS6, Line 52: def assertCounters(profile, num_hits, num_halted, num_skipped, num_matches=1): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/21729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a Gerrit-Change-Number: 21729 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 25 Sep 2024 23:22:17 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13384: Only install gcovr deps for coverage builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21849 ) Change subject: IMPALA-13384: Only install gcovr deps for coverage builds .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d0fd6d21273053aaf2acee39fcb83d9093d49a2 Gerrit-Change-Number: 21849 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Wed, 25 Sep 2024 22:55:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12937: Deflake test admission controller.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21813 ) Change subject: IMPALA-12937: Deflake test_admission_controller.py .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17032/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cf2bddcbfcd63d3a6bbc0a2014774a910f6e730 Gerrit-Change-Number: 21813 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 25 Sep 2024 22:12:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12939: Bound IMPALA BUILD THREADS for cgroups and memory
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21200 ) Change subject: IMPALA-12939: Bound IMPALA_BUILD_THREADS for cgroups and memory .. Patch Set 9: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10975/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87994d0464073fe2d91bc2f7c2592c012e42de71 Gerrit-Change-Number: 21200 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Wed, 25 Sep 2024 21:16:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13333: Limit memory estimation if PlanNode can spill
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21762 ) Change subject: IMPALA-1: Limit memory estimation if PlanNode can spill .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17031/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I290c4e889d4ab9e921e356f0f55a9c8b11d0854e Gerrit-Change-Number: 21762 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 25 Sep 2024 21:04:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 ) Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571 Gerrit-Change-Number: 21835 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 25 Sep 2024 18:37:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21835 ) Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests .. IMPALA-11934: Adjust the timeout interval for temporary file tests This patch increases the timeout interval for temporary file test cases. Initially, the timeout was set to 2 seconds, as it was for hdfs files. However, after integrating ozone for temporary files, this timeout seems too short for ozone uploads, causing some related test cases in the ozone builds to become flaky. So, the timeout is extended to 20 seconds in this patch. Tests: Ran disk-io-mgr-test and tmp-file-mgr-test, and no failures were observed. Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571 Reviewed-on: http://gerrit.cloudera.org:8080/21835 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/runtime/io/disk-io-mgr-test.cc M be/src/runtime/tmp-file-mgr-test.cc 2 files changed, 30 insertions(+), 50 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571 Gerrit-Change-Number: 21835 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 ) Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571 Gerrit-Change-Number: 21835 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 25 Sep 2024 18:30:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 ) Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/387/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571 Gerrit-Change-Number: 21835 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 25 Sep 2024 18:30:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13384: Only install gcovr deps for coverage builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21849 ) Change subject: IMPALA-13384: Only install gcovr deps for coverage builds .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10974/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d0fd6d21273053aaf2acee39fcb83d9093d49a2 Gerrit-Change-Number: 21849 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Wed, 25 Sep 2024 17:49:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13384: Only install gcovr deps for coverage builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21849 ) Change subject: IMPALA-13384: Only install gcovr deps for coverage builds .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17030/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d0fd6d21273053aaf2acee39fcb83d9093d49a2 Gerrit-Change-Number: 21849 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Wed, 25 Sep 2024 17:18:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13392: Document File Filtering in OPTIMIZE Statement
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21852 ) Change subject: IMPALA-13392: Document File Filtering in OPTIMIZE Statement .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/802/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/21852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73f88adedaf48909784baaf42488cb96defddfc3 Gerrit-Change-Number: 21852 Gerrit-PatchSet: 1 Gerrit-Owner: Noemi Pap-Takacs Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 25 Sep 2024 11:37:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13392: Document File Filtering in OPTIMIZE Statement
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21852 ) Change subject: IMPALA-13392: Document File Filtering in OPTIMIZE Statement .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/802/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/21852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73f88adedaf48909784baaf42488cb96defddfc3 Gerrit-Change-Number: 21852 Gerrit-PatchSet: 1 Gerrit-Owner: Noemi Pap-Takacs Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 25 Sep 2024 11:30:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13389: Refactor all webUI JS to use ES6 syntax
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21851 ) Change subject: IMPALA-13389: Refactor all webUI JS to use ES6 syntax .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17029/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie38f2c642ede14956a2c6d551a58e42538204768 Gerrit-Change-Number: 21851 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Surya Hebbar Gerrit-Comment-Date: Wed, 25 Sep 2024 10:46:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11265: Part1: Clear GroupContentFiles once used
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21847 ) Change subject: IMPALA-11265: Part1: Clear GroupContentFiles once used .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17028/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1efdd2a46c9675f7461535259e5892ed213a6b21 Gerrit-Change-Number: 21847 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 25 Sep 2024 10:06:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 ) Change subject: IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2) .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17027/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Surya Hebbar Gerrit-Comment-Date: Wed, 25 Sep 2024 07:40:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 ) Change subject: IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2) .. Patch Set 5: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21683/5/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/21683/5/be/src/util/runtime-profile.cc@2966 PS5, Line 2966: labels_vec[es_idx][label_item.second] = Value(label_item.first.c_str(), allocator); line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Surya Hebbar Gerrit-Comment-Date: Wed, 25 Sep 2024 07:16:23 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [PROTOTYPE] IMPALA-13384: Only install gcovr deps for coverage builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21849 ) Change subject: [PROTOTYPE] IMPALA-13384: Only install gcovr deps for coverage builds .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17026/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d0fd6d21273053aaf2acee39fcb83d9093d49a2 Gerrit-Change-Number: 21849 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 25 Sep 2024 02:57:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13022: Added infrastructure for implicit casting of functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21335 ) Change subject: IMPALA-13022: Added infrastructure for implicit casting of functions .. Patch Set 24: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a349673f185463276ad7ddb83f0cfc2d73218c Gerrit-Change-Number: 21335 Gerrit-PatchSet: 24 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 25 Sep 2024 01:47:44 + Gerrit-HasComments: No
[Impala-ASF-CR] [PROTOTYPE] IMPALA-13384: Only install gcovr deps for coverage builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21849 ) Change subject: [PROTOTYPE] IMPALA-13384: Only install gcovr deps for coverage builds .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/17025/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/21849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d0fd6d21273053aaf2acee39fcb83d9093d49a2 Gerrit-Change-Number: 21849 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 25 Sep 2024 01:20:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13302: Restore registering all conjuncts
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21684 ) Change subject: IMPALA-13302: Restore registering all conjuncts .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5959a3b3e18302e00b1d37e5f50410ebdb224cb0 Gerrit-Change-Number: 21684 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 24 Sep 2024 22:41:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13333: Limit memory estimation if PlanNode can spill
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21762 ) Change subject: IMPALA-1: Limit memory estimation if PlanNode can spill .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17024/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I290c4e889d4ab9e921e356f0f55a9c8b11d0854e Gerrit-Change-Number: 21762 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Tue, 24 Sep 2024 22:25:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21718 ) Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46487fefa300027e9df6cd7fb36c78af01dd56c1 Gerrit-Change-Number: 21718 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 24 Sep 2024 22:15:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13022: Added infrastructure for implicit casting of functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21335 ) Change subject: IMPALA-13022: Added infrastructure for implicit casting of functions .. Patch Set 24: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10973/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a349673f185463276ad7ddb83f0cfc2d73218c Gerrit-Change-Number: 21335 Gerrit-PatchSet: 24 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 24 Sep 2024 20:33:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12908: Add correctness check for tuple cache
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21754 ) Change subject: IMPALA-12908: Add correctness check for tuple cache .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17023/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied074e274ebf99fb57e3ee41a13148725775b77c Gerrit-Change-Number: 21754 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Tue, 24 Sep 2024 19:28:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12908: Add correctness check for tuple cache
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21754 ) Change subject: IMPALA-12908: Add correctness check for tuple cache .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17022/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied074e274ebf99fb57e3ee41a13148725775b77c Gerrit-Change-Number: 21754 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Tue, 24 Sep 2024 19:03:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13302: Restore registering all conjuncts
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21684 ) Change subject: IMPALA-13302: Restore registering all conjuncts .. Patch Set 10: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17021/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5959a3b3e18302e00b1d37e5f50410ebdb224cb0 Gerrit-Change-Number: 21684 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 24 Sep 2024 17:53:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13302: Restore registering all conjuncts
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21684 ) Change subject: IMPALA-13302: Restore registering all conjuncts .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17020/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5959a3b3e18302e00b1d37e5f50410ebdb224cb0 Gerrit-Change-Number: 21684 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 24 Sep 2024 17:52:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13022: Added infrastructure for implicit casting of functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21335 ) Change subject: IMPALA-13022: Added infrastructure for implicit casting of functions .. Patch Set 24: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17019/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a349673f185463276ad7ddb83f0cfc2d73218c Gerrit-Change-Number: 21335 Gerrit-PatchSet: 24 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 24 Sep 2024 17:41:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21718 ) Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17018/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46487fefa300027e9df6cd7fb36c78af01dd56c1 Gerrit-Change-Number: 21718 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 24 Sep 2024 17:36:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13022: Added infrastructure for implicit casting of functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21335 ) Change subject: IMPALA-13022: Added infrastructure for implicit casting of functions .. Patch Set 23: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17017/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a349673f185463276ad7ddb83f0cfc2d73218c Gerrit-Change-Number: 21335 Gerrit-PatchSet: 23 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 24 Sep 2024 17:36:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13302: Restore registering all conjuncts
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21684 ) Change subject: IMPALA-13302: Restore registering all conjuncts .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10972/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5959a3b3e18302e00b1d37e5f50410ebdb224cb0 Gerrit-Change-Number: 21684 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 24 Sep 2024 17:25:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13302: Restore registering all conjuncts
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21684 ) Change subject: IMPALA-13302: Restore registering all conjuncts .. Patch Set 8: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10970/ -- To view, visit http://gerrit.cloudera.org:8080/21684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5959a3b3e18302e00b1d37e5f50410ebdb224cb0 Gerrit-Change-Number: 21684 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 24 Sep 2024 17:12:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21718 ) Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10971/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46487fefa300027e9df6cd7fb36c78af01dd56c1 Gerrit-Change-Number: 21718 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 24 Sep 2024 17:04:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13022: Added infrastructure for implicit casting of functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21335 ) Change subject: IMPALA-13022: Added infrastructure for implicit casting of functions .. Patch Set 23: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21335/23/java/calcite-planner/src/test/java/org/apache/impala/CompatibilityTest.java File java/calcite-planner/src/test/java/org/apache/impala/CompatibilityTest.java: http://gerrit.cloudera.org:8080/#/c/21335/23/java/calcite-planner/src/test/java/org/apache/impala/CompatibilityTest.java@71 PS23, Line 71: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/21335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a349673f185463276ad7ddb83f0cfc2d73218c Gerrit-Change-Number: 21335 Gerrit-PatchSet: 23 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 24 Sep 2024 17:04:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13302: Restore registering all conjuncts
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21684 ) Change subject: IMPALA-13302: Restore registering all conjuncts .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10970/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5959a3b3e18302e00b1d37e5f50410ebdb224cb0 Gerrit-Change-Number: 21684 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 24 Sep 2024 16:44:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12709: Add support for hierarchical metastore event processing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 ) Change subject: IMPALA-12709: Add support for hierarchical metastore event processing .. Patch Set 23: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6 Gerrit-Change-Number: 21031 Gerrit-PatchSet: 23 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Tue, 24 Sep 2024 16:09:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13333: Limit memory estimation if PlanNode can spill
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21762 ) Change subject: IMPALA-1: Limit memory estimation if PlanNode can spill .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17016/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I290c4e889d4ab9e921e356f0f55a9c8b11d0854e Gerrit-Change-Number: 21762 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Tue, 24 Sep 2024 16:02:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12709: Add support for hierarchical metastore event processing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 ) Change subject: IMPALA-12709: Add support for hierarchical metastore event processing .. Patch Set 22: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10968/ -- To view, visit http://gerrit.cloudera.org:8080/21031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6 Gerrit-Change-Number: 21031 Gerrit-PatchSet: 22 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Tue, 24 Sep 2024 15:33:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11265: Part1: Clear GroupContentFiles once used
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21847 ) Change subject: IMPALA-11265: Part1: Clear GroupContentFiles once used .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17015/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1efdd2a46c9675f7461535259e5892ed213a6b21 Gerrit-Change-Number: 21847 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 24 Sep 2024 15:21:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11663: Update documentation for MT DOP
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21846 ) Change subject: IMPALA-11663: Update documentation for MT_DOP .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/801/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/21846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34ccdaa8e1738756f4f12f7074e9f076b9209b4 Gerrit-Change-Number: 21846 Gerrit-PatchSet: 1 Gerrit-Owner: Noemi Pap-Takacs Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 24 Sep 2024 14:33:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11663: Update documentation for MT DOP
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21846 ) Change subject: IMPALA-11663: Update documentation for MT_DOP .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/801/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/21846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34ccdaa8e1738756f4f12f7074e9f076b9209b4 Gerrit-Change-Number: 21846 Gerrit-PatchSet: 1 Gerrit-Owner: Noemi Pap-Takacs Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 24 Sep 2024 14:26:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12709: Add support for hierarchical metastore event processing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 ) Change subject: IMPALA-12709: Add support for hierarchical metastore event processing .. Patch Set 23: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17014/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6 Gerrit-Change-Number: 21031 Gerrit-PatchSet: 23 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Tue, 24 Sep 2024 11:25:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12709: Add support for hierarchical metastore event processing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 ) Change subject: IMPALA-12709: Add support for hierarchical metastore event processing .. Patch Set 23: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10969/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6 Gerrit-Change-Number: 21031 Gerrit-PatchSet: 23 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Tue, 24 Sep 2024 10:54:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12709: Add support for hierarchical metastore event processing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 ) Change subject: IMPALA-12709: Add support for hierarchical metastore event processing .. Patch Set 22: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/17013/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/21031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6 Gerrit-Change-Number: 21031 Gerrit-PatchSet: 22 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Tue, 24 Sep 2024 10:49:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12709: Add support for hierarchical metastore event processing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 ) Change subject: IMPALA-12709: Add support for hierarchical metastore event processing .. Patch Set 22: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10968/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6 Gerrit-Change-Number: 21031 Gerrit-PatchSet: 22 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Tue, 24 Sep 2024 10:19:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13388: fix unit-tests of Statestore HA for UBSAN builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21820 ) Change subject: IMPALA-13388: fix unit-tests of Statestore HA for UBSAN builds .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie59d1e93c635411723f7044da52e4ab19c7d2fac Gerrit-Change-Number: 21820 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 24 Sep 2024 03:54:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12908: Add correctness check for tuple cache
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21754 ) Change subject: IMPALA-12908: Add correctness check for tuple cache .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17012/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied074e274ebf99fb57e3ee41a13148725775b77c Gerrit-Change-Number: 21754 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Tue, 24 Sep 2024 03:12:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13312: Use client address from X-Forwarded-For Header in Ranger Audit Logs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21780 ) Change subject: IMPALA-13312: Use client address from X-Forwarded-For Header in Ranger Audit Logs .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17011/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib784ad805c649e9576ef34f125509c904b7773ab Gerrit-Change-Number: 21780 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Comment-Date: Tue, 24 Sep 2024 00:13:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13397: Use TUniqueIdUtil.PrintId in HeartbeatContext.toString
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21840 ) Change subject: IMPALA-13397: Use TUniqueIdUtil.PrintId in HeartbeatContext.toString .. IMPALA-13397: Use TUniqueIdUtil.PrintId in HeartbeatContext.toString Impala begin to consistently use PrintId to print TUniqueId since IMPALA-13252. This patch add one more PrintId in HeartbeatContext.toString to pass TestBannedLogMessage.test_no_tuniqueid. Change-Id: Ic9395fab07b5f85342da692a350ca21ec502a1ea Reviewed-on: http://gerrit.cloudera.org:8080/21840 Reviewed-by: Michael Smith Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Smith: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic9395fab07b5f85342da692a350ca21ec502a1ea Gerrit-Change-Number: 21840 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto
[Impala-ASF-CR] IMPALA-13397: Use TUniqueIdUtil.PrintId in HeartbeatContext.toString
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21840 ) Change subject: IMPALA-13397: Use TUniqueIdUtil.PrintId in HeartbeatContext.toString .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9395fab07b5f85342da692a350ca21ec502a1ea Gerrit-Change-Number: 21840 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 23 Sep 2024 23:57:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 ) Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc .. Patch Set 6: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/800/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/21793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90 Gerrit-Change-Number: 21793 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 23 Sep 2024 23:44:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 ) Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc .. Patch Set 6: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/800/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/21793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90 Gerrit-Change-Number: 21793 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 23 Sep 2024 23:36:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13388: fix unit-tests of Statestore HA for UBSAN builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21820 ) Change subject: IMPALA-13388: fix unit-tests of Statestore HA for UBSAN builds .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17010/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie59d1e93c635411723f7044da52e4ab19c7d2fac Gerrit-Change-Number: 21820 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 23 Sep 2024 23:02:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13388: fix unit-tests of Statestore HA for UBSAN builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21820 ) Change subject: IMPALA-13388: fix unit-tests of Statestore HA for UBSAN builds .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10967/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie59d1e93c635411723f7044da52e4ab19c7d2fac Gerrit-Change-Number: 21820 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 23 Sep 2024 22:43:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13388: fix unit-tests of Statestore HA for UBSAN builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21820 ) Change subject: IMPALA-13388: fix unit-tests of Statestore HA for UBSAN builds .. Patch Set 4: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/17009/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/21820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie59d1e93c635411723f7044da52e4ab19c7d2fac Gerrit-Change-Number: 21820 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 23 Sep 2024 21:25:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12345: Add user quotas to Admission Control
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21616 ) Change subject: IMPALA-12345: Add user quotas to Admission Control .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17008/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41 Gerrit-Change-Number: 21616 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 23 Sep 2024 21:09:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21718 ) Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10965/ -- To view, visit http://gerrit.cloudera.org:8080/21718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46487fefa300027e9df6cd7fb36c78af01dd56c1 Gerrit-Change-Number: 21718 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Sep 2024 20:42:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12908: Add correctness check for tuple cache
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21754 ) Change subject: IMPALA-12908: Add correctness check for tuple cache .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17007/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied074e274ebf99fb57e3ee41a13148725775b77c Gerrit-Change-Number: 21754 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 23 Sep 2024 18:57:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13397: Use TUniqueIdUtil.PrintId in HeartbeatContext.toString
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21840 ) Change subject: IMPALA-13397: Use TUniqueIdUtil.PrintId in HeartbeatContext.toString .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10966/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9395fab07b5f85342da692a350ca21ec502a1ea Gerrit-Change-Number: 21840 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 23 Sep 2024 18:48:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12908: Add correctness check for tuple cache
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21754 ) Change subject: IMPALA-12908: Add correctness check for tuple cache .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/17006/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/21754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied074e274ebf99fb57e3ee41a13148725775b77c Gerrit-Change-Number: 21754 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 23 Sep 2024 18:09:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21718 ) Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17005/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46487fefa300027e9df6cd7fb36c78af01dd56c1 Gerrit-Change-Number: 21718 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Sep 2024 15:42:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21718 ) Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10965/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46487fefa300027e9df6cd7fb36c78af01dd56c1 Gerrit-Change-Number: 21718 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Sep 2024 15:39:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13247: Support Reading Puffin files for the current snapshot
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 ) Change subject: IMPALA-13247: Support Reading Puffin files for the current snapshot .. Patch Set 14: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17003/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50c1228988960a686d08a9b2942e01e366678866 Gerrit-Change-Number: 21605 Gerrit-PatchSet: 14 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 23 Sep 2024 14:36:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13247: Support Reading Puffin files for the current snapshot
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 ) Change subject: IMPALA-13247: Support Reading Puffin files for the current snapshot .. Patch Set 15: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17004/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50c1228988960a686d08a9b2942e01e366678866 Gerrit-Change-Number: 21605 Gerrit-PatchSet: 15 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 23 Sep 2024 14:34:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13247: Support Reading Puffin files for the current snapshot
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 ) Change subject: IMPALA-13247: Support Reading Puffin files for the current snapshot .. Patch Set 13: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17002/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50c1228988960a686d08a9b2942e01e366678866 Gerrit-Change-Number: 21605 Gerrit-PatchSet: 13 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 23 Sep 2024 14:06:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13247: Support Reading Puffin files for the current snapshot
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 ) Change subject: IMPALA-13247: Support Reading Puffin files for the current snapshot .. Patch Set 13: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21605/13/tests/custom_cluster/test_iceberg_with_puffin_stats_startup_flag.py File tests/custom_cluster/test_iceberg_with_puffin_stats_startup_flag.py: http://gerrit.cloudera.org:8080/#/c/21605/13/tests/custom_cluster/test_iceberg_with_puffin_stats_startup_flag.py@52 PS13, Line 52: flake8: W391 blank line at end of file -- To view, visit http://gerrit.cloudera.org:8080/21605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50c1228988960a686d08a9b2942e01e366678866 Gerrit-Change-Number: 21605 Gerrit-PatchSet: 13 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 23 Sep 2024 13:36:33 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Try out fix for KUDU-3610
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21843 ) Change subject: Try out fix for KUDU-3610 .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10964/ -- To view, visit http://gerrit.cloudera.org:8080/21843 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia838346ca3fa85472704fa2391b9714acc402d1d Gerrit-Change-Number: 21843 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Sep 2024 10:33:43 + Gerrit-HasComments: No
[Impala-ASF-CR] Try out fix for KUDU-3610
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21843 ) Change subject: Try out fix for KUDU-3610 .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/17001/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/21843 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia838346ca3fa85472704fa2391b9714acc402d1d Gerrit-Change-Number: 21843 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Sep 2024 06:02:17 + Gerrit-HasComments: No
[Impala-ASF-CR] Try out fix for KUDU-3610
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21843 ) Change subject: Try out fix for KUDU-3610 .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10964/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21843 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia838346ca3fa85472704fa2391b9714acc402d1d Gerrit-Change-Number: 21843 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Sep 2024 05:31:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13388: fix unit-tests of Statestore HA for UBSAN builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21820 ) Change subject: IMPALA-13388: fix unit-tests of Statestore HA for UBSAN builds .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17000/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie59d1e93c635411723f7044da52e4ab19c7d2fac Gerrit-Change-Number: 21820 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Sun, 22 Sep 2024 23:31:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13022: Added infrastructure for implicit casting of functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21335 ) Change subject: IMPALA-13022: Added infrastructure for implicit casting of functions .. Patch Set 22: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16999/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a349673f185463276ad7ddb83f0cfc2d73218c Gerrit-Change-Number: 21335 Gerrit-PatchSet: 22 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Sun, 22 Sep 2024 13:54:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13022: Added infrastructure for implicit casting of functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21335 ) Change subject: IMPALA-13022: Added infrastructure for implicit casting of functions .. Patch Set 21: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16998/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a349673f185463276ad7ddb83f0cfc2d73218c Gerrit-Change-Number: 21335 Gerrit-PatchSet: 21 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Sun, 22 Sep 2024 13:47:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13022: Added infrastructure for implicit casting of functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21335 ) Change subject: IMPALA-13022: Added infrastructure for implicit casting of functions .. Patch Set 22: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21335/22/java/calcite-planner/src/test/java/org/apache/impala/CompatibilityTest.java File java/calcite-planner/src/test/java/org/apache/impala/CompatibilityTest.java: http://gerrit.cloudera.org:8080/#/c/21335/22/java/calcite-planner/src/test/java/org/apache/impala/CompatibilityTest.java@71 PS22, Line 71: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/21335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a349673f185463276ad7ddb83f0cfc2d73218c Gerrit-Change-Number: 21335 Gerrit-PatchSet: 22 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Sun, 22 Sep 2024 13:20:00 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13022: Added infrastructure for implicit casting of functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21335 ) Change subject: IMPALA-13022: Added infrastructure for implicit casting of functions .. Patch Set 21: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21335/21/java/calcite-planner/src/test/java/org/apache/impala/CompatibilityTest.java File java/calcite-planner/src/test/java/org/apache/impala/CompatibilityTest.java: http://gerrit.cloudera.org:8080/#/c/21335/21/java/calcite-planner/src/test/java/org/apache/impala/CompatibilityTest.java@71 PS21, Line 71: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/21335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a349673f185463276ad7ddb83f0cfc2d73218c Gerrit-Change-Number: 21335 Gerrit-PatchSet: 21 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Sun, 22 Sep 2024 13:16:53 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21842 ) Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16997/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d Gerrit-Change-Number: 21842 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sun, 22 Sep 2024 10:23:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-889: Add trim() function matching ANSI SQL definition
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21825 ) Change subject: IMPALA-889: Add trim() function matching ANSI SQL definition .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16996/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c4fa6d0d8d0684c4b6d8dac8fd531d205e4f7b4 Gerrit-Change-Number: 21825 Gerrit-PatchSet: 3 Gerrit-Owner: Mihaly Szjatinya Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mihaly Szjatinya Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Sat, 21 Sep 2024 12:43:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-889: Add trim() function matching ANSI SQL definition
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/21825 )
Change subject: IMPALA-889: Add trim() function matching ANSI SQL definition
..
Patch Set 3:
(3 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python2 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with virtualenv installed.
http://gerrit.cloudera.org:8080/#/c/21825/3/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java
File fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java:
http://gerrit.cloudera.org:8080/#/c/21825/3/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@107
PS3, Line 107: throw new AnalysisException("Function " +
trimFromFnName_.getFunction().toUpperCase()
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21825/3/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@110
PS3, Line 110: if ((trimFromFnName_.getDb() != null) &&
!trimFromFnName_.getDb().equals(BuiltinsDb.NAME)) {
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21825/3/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@120
PS3, Line 120: }
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/21825
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c4fa6d0d8d0684c4b6d8dac8fd531d205e4f7b4
Gerrit-Change-Number: 21825
Gerrit-PatchSet: 3
Gerrit-Owner: Mihaly Szjatinya
Gerrit-Reviewer: Daniel Becker
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Noemi Pap-Takacs
Gerrit-Reviewer: Peter Rozsa
Gerrit-Comment-Date: Sat, 21 Sep 2024 12:13:13 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12686: Switch to toolchain with basic debug info
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21471 ) Change subject: IMPALA-12686: Switch to toolchain with basic debug info .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10963/ -- To view, visit http://gerrit.cloudera.org:8080/21471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b962c350cc5f1f2b24ca7a52b940ec9e87a7745 Gerrit-Change-Number: 21471 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Sat, 21 Sep 2024 03:34:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13397: Use TUniqueIdUtil.PrintId in HeartbeatContext.toString
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21840 ) Change subject: IMPALA-13397: Use TUniqueIdUtil.PrintId in HeartbeatContext.toString .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16995/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9395fab07b5f85342da692a350ca21ec502a1ea Gerrit-Change-Number: 21840 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Sat, 21 Sep 2024 03:07:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13396: Unify tmp dir management in CustomClusterTestSuite
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21836 ) Change subject: IMPALA-13396: Unify tmp dir management in CustomClusterTestSuite .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16994/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dd665e8028b3f03e5e33d572c5e188f85c3bdf5 Gerrit-Change-Number: 21836 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 20 Sep 2024 23:33:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12686: Switch to toolchain with basic debug info
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21471 ) Change subject: IMPALA-12686: Switch to toolchain with basic debug info .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10963/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b962c350cc5f1f2b24ca7a52b940ec9e87a7745 Gerrit-Change-Number: 21471 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 20 Sep 2024 22:21:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 ) Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc .. Patch Set 5: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/799/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/21793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90 Gerrit-Change-Number: 21793 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 20 Sep 2024 22:04:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 ) Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc .. Patch Set 5: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/799/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/21793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90 Gerrit-Change-Number: 21793 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 20 Sep 2024 21:57:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12922: Make batch sizes an optional test dimension
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21337 ) Change subject: IMPALA-12922: Make batch_sizes an optional test dimension .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16993/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39afa892ecf78b717686d59d7fdd1877a64d609f Gerrit-Change-Number: 21337 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 20 Sep 2024 20:14:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13396: Unify tmp dir management in CustomClusterTestSuite
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21836 ) Change subject: IMPALA-13396: Unify tmp dir management in CustomClusterTestSuite .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16992/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dd665e8028b3f03e5e33d572c5e188f85c3bdf5 Gerrit-Change-Number: 21836 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 20 Sep 2024 18:38:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 ) Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16991/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571 Gerrit-Change-Number: 21835 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 20 Sep 2024 18:30:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12732: Docs for MERGE statement
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21834 ) Change subject: IMPALA-12732: Docs for MERGE statement .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/798/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/21834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifadbae34ba802c4d4bd2feeec74f637607f108d7 Gerrit-Change-Number: 21834 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 20 Sep 2024 15:39:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12732: Docs for MERGE statement
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21834 ) Change subject: IMPALA-12732: Docs for MERGE statement .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/798/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/21834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifadbae34ba802c4d4bd2feeec74f637607f108d7 Gerrit-Change-Number: 21834 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 20 Sep 2024 15:33:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 24: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16990/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 24 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Fri, 20 Sep 2024 13:35:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 23: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16989/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 23 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Fri, 20 Sep 2024 13:31:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 23: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21426/23/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/21426/23/tests/shell/test_shell_interactive.py@344 PS23, Line 344: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/21426/23/tests/shell/test_shell_interactive.py@344 PS23, Line 344: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 23 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Fri, 20 Sep 2024 13:01:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12709: Add support for hierarchical metastore event processing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 ) Change subject: IMPALA-12709: Add support for hierarchical metastore event processing .. Patch Set 21: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/16988/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/21031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6 Gerrit-Change-Number: 21031 Gerrit-PatchSet: 21 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Fri, 20 Sep 2024 11:30:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13336: Fix syntax error in creating Iceberg test table on Apache Hive 3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21730 ) Change subject: IMPALA-13336: Fix syntax error in creating Iceberg test table on Apache Hive 3 .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b47d6dc1a2ab63d4ecea476dbab67c1ae8ca490 Gerrit-Change-Number: 21730 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 20 Sep 2024 09:43:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13336: Fix syntax error in creating Iceberg test table on Apache Hive 3
Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/21730 )
Change subject: IMPALA-13336: Fix syntax error in creating Iceberg test table
on Apache Hive 3
..
IMPALA-13336: Fix syntax error in creating Iceberg test table on Apache Hive 3
Apache Hive 3 doesn't support the syntax of STORED BY ICEBERG STORED AS
AVRO. When loading test data on Apache Hive 3, we convert this clause to
STORED BY 'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler'
TBLPROPERTIES('write.format.default'='AVRO')
However, when there is a LOCATION clause in the statement, the
TBLPROPERTIES clause will be put before the LOCATION clause, which
causes the syntax error.
In the CreateTable statement, TBLPROPERTIES clause should be put after
the LOCATION clause. This patch fixes generate-schema-statements.py to
take care of this case.
Tests:
- Verified the SQL files generated by generate-schema-statements.py
Change-Id: I5b47d6dc1a2ab63d4ecea476dbab67c1ae8ca490
Reviewed-on: http://gerrit.cloudera.org:8080/21730
Reviewed-by: Impala Public Jenkins
Tested-by: Impala Public Jenkins
---
M testdata/bin/generate-schema-statements.py
1 file changed, 16 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21730
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b47d6dc1a2ab63d4ecea476dbab67c1ae8ca490
Gerrit-Change-Number: 21730
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21833 ) Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/797/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/21833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4 Gerrit-Change-Number: 21833 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 20 Sep 2024 09:38:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21833 ) Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/797/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/21833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4 Gerrit-Change-Number: 21833 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 20 Sep 2024 09:31:15 + Gerrit-HasComments: No
