[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-15 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..

IMPALA-9025: Handle AnalysisException caused by expr_rewrites
properly

When the optimizer rewrites conjunct exprs with constant values,
a new expr may cause AnalysisException. In this case,
the conjuncts should use the original expr, not the intermediate
expr produced by propagateConstants. Fixed optimizeConjuncts
to handle this scenario properly.

Tests:
Add unit test for alias.
Ran exhaustive tests.

Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Reviewed-on: http://gerrit.cloudera.org:8080/14403
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M testdata/workloads/functional-query/queries/QueryTest/alias.test
2 files changed, 19 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 6
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-15 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 5
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Wed, 16 Oct 2019 02:04:11 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-15 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 5
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 15 Oct 2019 21:44:10 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-15 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 4:

This is the dockerhub outage causing image pull to fail, I will retry


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 15 Oct 2019 21:43:56 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-15 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5094/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 5
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 15 Oct 2019 21:44:11 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-15 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5091/


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 15 Oct 2019 20:59:26 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-15 Thread Yongzhi Chen (Code Review) 
Yongzhi Chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 4:

https://issues.apache.org/jira/browse/IMPALA-9049
https://issues.apache.org/jira/browse/IMPALA-9050
The related flaky tests jiras


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 15 Oct 2019 19:07:51 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-15 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 4:

Can you file JIRAs for the flaky tests (or point to the current ones) if you 
haven't already.


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 15 Oct 2019 16:59:20 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-15 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5091/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 15 Oct 2019 16:42:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-15 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 15 Oct 2019 16:42:18 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-14 Thread Yongzhi Chen (Code Review) 
Yongzhi Chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 3:

The build error seems not related:
beeswax/impala_beeswax.py:519: in __do_rpc
02:40:17 ] raise ImpalaBeeswaxException(self.__build_error_message(b), b)
02:40:17 ] E   ImpalaBeeswaxException: ImpalaBeeswaxException:
02:40:17 ] EINNER EXCEPTION: 
02:40:17 ] EMESSAGE: InconsistentMetadataFetchException: Fetching DATABASE 
failed. Could not find TCatalogObject(type:DATABASE, catalog_version:0, 
db:TDatabase(db_name:test_alter_database_set_owner_1e264a1))


02:40:17 ] raise ImpalaBeeswaxException(self.__build_error_message(b), b)
02:40:17 ] E   ImpalaBeeswaxException: ImpalaBeeswaxException:
02:40:17 ] EINNER EXCEPTION: 
02:40:17 ] EMESSAGE: Unable to open Kudu table: Network error: failed to 
read from TLS socket (remote: 172.18.0.1:7051): Cannot send after transport 
endpoint shutdown (error 108)


-- 
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 3
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Mon, 14 Oct 2019 19:21:52 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-11 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5085/


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 3
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Sat, 12 Oct 2019 02:40:18 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-11 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 3
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Fri, 11 Oct 2019 22:23:36 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-11 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Fri, 11 Oct 2019 22:23:23 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-11 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5085/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 3
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Fri, 11 Oct 2019 22:23:37 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-11 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4784/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Fri, 11 Oct 2019 12:54:30 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-11 Thread Yongzhi Chen (Code Review) 
Yongzhi Chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 2:

(1 comment)

Patch set 2 add the comments. Thanks for the review.

http://gerrit.cloudera.org:8080/#/c/14403/1/testdata/workloads/functional-query/queries/QueryTest/alias.test
File testdata/workloads/functional-query/queries/QueryTest/alias.test:

http://gerrit.cloudera.org:8080/#/c/14403/1/testdata/workloads/functional-query/queries/QueryTest/alias.test@89
PS1, Line 89: # literal alias
> It would be good to include the JIRA here for future reference. Maybe also 
Done



--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Fri, 11 Oct 2019 12:12:39 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-11 Thread Yongzhi Chen (Code Review) 
Hello Anurag Mantripragada, Sahil Takiar, Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14403

to look at the new patch set (#2).

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..

IMPALA-9025: Handle AnalysisException caused by expr_rewrites
properly

When the optimizer rewrites conjunct exprs with constant values,
a new expr may cause AnalysisException. In this case,
the conjuncts should use the original expr, not the intermediate
expr produced by propagateConstants. Fixed optimizeConjuncts
to handle this scenario properly.

Tests:
Add unit test for alias.
Ran exhaustive tests.

Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
---
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M testdata/workloads/functional-query/queries/QueryTest/alias.test
2 files changed, 19 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/14403/2
--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-10 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 1: Code-Review+2

(1 comment)

LGTM. I just have one ask

http://gerrit.cloudera.org:8080/#/c/14403/1/testdata/workloads/functional-query/queries/QueryTest/alias.test
File testdata/workloads/functional-query/queries/QueryTest/alias.test:

http://gerrit.cloudera.org:8080/#/c/14403/1/testdata/workloads/functional-query/queries/QueryTest/alias.test@89
PS1, Line 89: # literal alias
It would be good to include the JIRA here for future reference. Maybe also a 
one line comment explaining the bug too.



--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 10 Oct 2019 23:28:40 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-09 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14403 )

Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4770/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 09 Oct 2019 18:57:42 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-09 Thread Yongzhi Chen (Code Review) 
Yongzhi Chen has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/14403


Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites 
properly
..

IMPALA-9025: Handle AnalysisException caused by expr_rewrites
properly

When the optimizer rewrites conjunct exprs with constant values,
a new expr may cause AnalysisException. In this case,
the conjuncts should use the original expr, not the intermediate
expr produced by propagateConstants. Fixed optimizeConjuncts
to handle this scenario properly.

Tests:
Add unit test for alias.
Ran exhaustive tests.

Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
---
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M testdata/workloads/functional-query/queries/QueryTest/alias.test
2 files changed, 17 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/14403/1
--
To view, visit http://gerrit.cloudera.org:8080/14403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274
Gerrit-Change-Number: 14403
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen