[Impala-ASF-CR] Add raw values to pretty-printed time profiles.
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/12403 ) Change subject: Add raw values to pretty-printed time profiles. .. Abandoned Stale code review -- To view, visit http://gerrit.cloudera.org:8080/12403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I3034482b3643968ac9e931bb28692e68b5a709c2 Gerrit-Change-Number: 12403 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker
[Impala-ASF-CR] Add raw values to pretty-printed time profiles.
Lars Volker has posted comments on this change. (
http://gerrit.cloudera.org:8080/12403 )
Change subject: Add raw values to pretty-printed time profiles.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12403/1/be/src/util/pretty-printer.h
File be/src/util/pretty-printer.h:
http://gerrit.cloudera.org:8080/#/c/12403/1/be/src/util/pretty-printer.h@96
PS1, Line 96: if (verbose) ss << " (" << value << "ns)";
Should we convert them all to a common unit to make parsing even easier?
--
To view, visit http://gerrit.cloudera.org:8080/12403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3034482b3643968ac9e931bb28692e68b5a709c2
Gerrit-Change-Number: 12403
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Lars Volker
Gerrit-Comment-Date: Fri, 08 Feb 2019 09:47:27 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add raw values to pretty-printed time profiles.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12403 ) Change subject: Add raw values to pretty-printed time profiles. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2037/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3034482b3643968ac9e931bb28692e68b5a709c2 Gerrit-Change-Number: 12403 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 08 Feb 2019 05:40:19 + Gerrit-HasComments: No
[Impala-ASF-CR] Add raw values to pretty-printed time profiles.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12403 Change subject: Add raw values to pretty-printed time profiles. .. Add raw values to pretty-printed time profiles. Impala text profiles pretty print time values, like "1h3m" and so on. This is handy, but it makes it miserable to programmatically find, say, large values without writing a parser for the pretty-printer. This commit includes the raw values when printing, with the units those raw values come in. (We don't put the units for "bytes", but whereas most metrics measured in bytes are actually measured in bytes, we mix nano and milli seconds in several places.) Change-Id: I3034482b3643968ac9e931bb28692e68b5a709c2 --- M be/src/util/pretty-printer.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/12403/1 -- To view, visit http://gerrit.cloudera.org:8080/12403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3034482b3643968ac9e931bb28692e68b5a709c2 Gerrit-Change-Number: 12403 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger
