[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. IMPALA-5004: Switch to sorting node for large

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-11-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 10: Tests are passing now. So this patch

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-11-02 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Paul Rogers, Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11698 to look at the new patch set (#9). Change subject: IMPALA-5004: Switch to sorting node for large TopN queries

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 7: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Paul Rogers, Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11698 to look at the new patch set (#7). Change subject: IMPALA-5004: Switch to sorting node for large TopN queries

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-26 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-26 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Paul Rogers, Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11698 to look at the new patch set (#6). Change subject: IMPALA-5004: Switch to sorting node for large TopN queries

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 5: (3 comments) Looks good overall

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 5: Code-Review+1 (2 comments) one question

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 5: (8 comments) Addressed comments and made a

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-24 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Paul Rogers, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11698 to look at the new patch set (#5). Change subject: IMPALA-5004: Switch to sorting node for large TopN queries

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 4: (8 comments)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-23 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 3: (4 comments) Made the following changes: *

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-23 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Paul Rogers, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11698 to look at the new patch set (#4). Change subject: IMPALA-5004: Switch to sorting node for large TopN queries

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-18 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 3: (1 comment) This will be a great change.

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-18 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11698 to look at the new patch set (#3). Change subject: IMPALA-5004: Switch to sorting node for large TopN queries

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. IMPALA-5004: Switch to sorting node for large TopN queries

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11698 Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. IMPALA-5004: Switch to sorting node for large TopN queries