[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2018-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 5: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2018-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2018-01-09 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 5: Tagging in Tim who reviewed the code. Some other commi

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2018-01-09 Thread John Russell (Code Review)
Hello Greg Rahn, sandeep akinapelli, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8768 to look at the new patch set (#5). Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2018-01-09 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/8768

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread John Russell (Code Review)
Hello Greg Rahn, sandeep akinapelli, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8768 to look at the new patch set (#4). Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 4: Code-Review+1 LGTM -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 3: (1 comment) Serves me right for editing the output. (

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8768/3/d

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8768/

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread John Russell (Code Review)
Hello Greg Rahn, sandeep akinapelli, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8768 to look at the new patch set (#3). Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8768

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-10 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8768/2/

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-07 Thread John Russell (Code Review)
Hello Greg Rahn, sandeep akinapelli, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8768 to look at the new patch set (#2). Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 2: Patch set 2 has 'nanoseconds' and 'quarter' removed.

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-05 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 1: Tagging in Alex for ability to +2 after Sandeep and Gr

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-05 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 1: See my note in https://issues.apache.org/jira/browse/I

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-05 Thread John Russell (Code Review)
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8768 Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function Change-Id: Ifcf389